[Bug 7476] New: Files executable that probably should not be
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7476 Bug #: 7476 Summary: Files executable that probably should not be Classification: Unclassified Change sponsored?: Seeking cosponsors Product: Koha Version: master Platform: All OS/Version: All Status: ASSIGNED Severity: normal Priority: P3 Component: Architecture, internals, and plumbing AssignedTo: mjr@ttllp.co.uk ReportedBy: mjr@ttllp.co.uk QAContact: koha.sekjal@gmail.com Created attachment 7390 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7390 xt/find-misplaced-executables The following files are executable and I think they do not need to be. Please find attached an xt test that lists such misplaced executables. ./acqui/pdfformat/layout2pages.pm ./acqui/pdfformat/layout3pages.pm ./etc/zebradb/marc_defs/marc21/biblios/record.abs ./koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl ./koha-tmpl/opac-tmpl/prog/en/css/opac.css ./koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt ./koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt ./koha-tmpl/opac-tmpl/prog/en/includes/opac-facets.inc ./installer/data/mysql/sysprefs.sql ./installer/data/mysql/uk-UA/mandatory/system_preferences_full_optimal_for_install_only.sql ./installer/data/mysql/ru-RU/mandatory/system_preferences_full_optimal_for_install_only.sql ./C4/Auth.pm ./C4/ImportExportFramework.pm ./C4/TTParser.pm ./C4/XSLT.pm -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7476 --- Comment #1 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2012-01-30 21:07:40 UTC --- Created attachment 7391 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7391 Bug 7476 – Remove executable bit from files that probably should not be executed -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7476 MJ Ray (software.coop) <mjr@ttllp.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7476 Aleksa <aleksa@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7391|0 |1 is obsolete| | Status|Needs Signoff |Signed Off AssignedTo|mjr@ttllp.co.uk |aleksa@catalyst.net.nz --- Comment #2 from Aleksa <aleksa@catalyst.net.nz> 2012-01-31 03:19:24 UTC --- Created attachment 7396 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7396 [SIGNED-OFF] 7391: Bug 7476 – Remove executable bit from files that probably should not be executed -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7476 MJ Ray (software.coop) <mjr@ttllp.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mjr@ttllp.co.uk -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7476 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QAContact|koha.sekjal@gmail.com |m.de.rooy@rijksmuseum.nl -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7476 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7390|0 |1 is obsolete| | Attachment #7396|0 |1 is obsolete| | --- Comment #3 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2012-02-03 12:44:11 UTC --- Created attachment 7442 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7442 [PASSED_QA] Patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7476 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #4 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2012-02-03 12:45:11 UTC --- Tested. Works as advertised. Amended patch to correct copy-and-paste comments. Incrementing status.. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7476 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-03 13:28:54 UTC --- patch pushed, but my suggestion would be to also add '!' -name '*.*~' \ and '!' -name '*.old' \ '!' -name '*.bak' \ to the list of excluded files for xt/find-misplaced-executables Do you think it could be a good idea ? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org