[Bug 22269] New: Pay amount - modal confirmation of amount to return to patron should be suppressed if attempting to pay (not collect) more than owed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22269 Bug ID: 22269 Summary: Pay amount - modal confirmation of amount to return to patron should be suppressed if attempting to pay (not collect) more than owed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- To recreate: 1 - Add a fine or find a patron owing money 2 - Go to pay fines, pay amount 3 - Set amount to be paid higher than amount owed 4 - Set amount collected higher than amount paid 5 - Note you get a confirmation modal, confirm 6 - payment fails Expected action would be that modal is prevented or notifies user that they are trying to pay more than owed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22269 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11373 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 [Bug 11373] Add "change calculation" feature to the fine payment forms -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22269 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22269 Bug 22269 depends on bug 11373, which changed state. Bug 11373 Summary: Add "change calculation" feature to the fine payment forms https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22269 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 94785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94785&action=edit Payment fails if amount collected is higher -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22269 --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I'm not sure if this is the same bug as the one I'm experiencing. I'm trying to understand the new "change to give" feature. If I try to pay a 19,33$ charge with a 20$ bill, I get a notification saying I owe 0,67$ to the user, I confirm, and then the payment fails because "You must pay a value less than or equal to 19.33". I attached a gif showing what I mean. To recreate: 1 - Add a fine or find a patron owing money 2 - Go to pay fines, pay amount 3 - Set amount collected higher than amount paid 4 - Note you get a confirmation modal, confirm 5 - payment fails -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22269 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- When I attempt to recreate I get "You must pay a value less than or equal to X", so I think this is no longer a problem? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22269 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Lucas Gass from comment #3)
When I attempt to recreate I get "You must pay a value less than or equal to X", so I think this is no longer a problem?
Indeed, works for me now Caroline, can you check the db values for your patrons charges and ensure they don't owe any partial cents? If not, it may be a math error (floating point owed something like 19.32999999998) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22269 --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Caroline Cyr La Rose from comment #2)
I'm not sure if this is the same bug as the one I'm experiencing.
I'm trying to understand the new "change to give" feature. If I try to pay a 19,33$ charge with a 20$ bill, I get a notification saying I owe 0,67$ to the user, I confirm, and then the payment fails because "You must pay a value less than or equal to 19.33".
I attached a gif showing what I mean.
To recreate: 1 - Add a fine or find a patron owing money 2 - Go to pay fines, pay amount 3 - Set amount collected higher than amount paid 4 - Note you get a confirmation modal, confirm 5 - payment fails
Maybe this one: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26076 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22269 --- Comment #6 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Indeed, it works now. :) Caroline -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22269 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org