[Bug 6285] New: overdues csv columns
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6285 Bug #: 6285 Summary: overdues csv columns Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_4 Platform: All OS/Version: All Status: NEW Severity: minor Priority: P5 Component: Circulation AssignedTo: kyle.m.hall@gmail.com ReportedBy: paul.poulain@biblibre.com QAContact: koha-bugs@lists.koha-community.org CC: gmcharlt@gmail.com uploading the circ overdues result in a csv with columns in a strange order and not the order of the screen This patch reorder the column by putting the usefull ones first (MT6196) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6285 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|kyle.m.hall@gmail.com |paul.poulain@biblibre.com --- Comment #1 from Paul Poulain <paul.poulain@biblibre.com> 2011-04-29 17:37:03 UTC --- Created attachment 4021 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4021 proposed patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6285 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6285 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4021|0 |1 is obsolete| | --- Comment #2 from Magnus Enger <magnus@enger.priv.no> 2011-06-15 14:36:23 UTC --- Created attachment 4482 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4482 Signed-off patch Before applying the patch, :8080/cgi-bin/koha/circ/overdue.pl?op=csv produced a CSV file with the columns in alphabetical order by column name. After applying the patch the same URL produces a CSV file with the columns in the order specified in the patch, which does look better. Signing off! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6285 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@enger.priv.no Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6285 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Passed QA --- Comment #3 from Paul Poulain <paul.poulain@biblibre.com> 2011-08-10 13:03:40 UTC --- QA comment It's a trivial (2 lines) patch, that is usefull for overdues readability. Marking passed QA even it i'm the author, I think it's not worth having 4 eyes validating : Me, Magnus, and Chris (when merging) is enough for a so small patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6285 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Passed QA |Signed Off --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> 2011-08-10 19:02:30 UTC --- The proposal for QA was "a) he would not mark any patch he himself has written as Passed QA b) any patch written by BibLibre would need a signoff from another, external person before he'd test it c) he would start with the patches that have been waiting the longest d) the QAM and RM could reject any "Passed QA" patch if they feel it's not sufficient for whatever reason (which would need to be noted in the bug report)" So even though this is a trivial patch like you say, I would like us to follow the rules we made for ourselves. Ian can you take a look at this too please. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6285 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Passed QA --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-06 12:47:04 UTC --- 2 months later, ian has'nt QAed this one line patch. I mark again as "passed QA", chris you can object again, but in this case, please bug ian ;-) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6285 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Passed QA |Signed Off --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> 2011-10-07 00:40:55 UTC --- Still waiting QA from Ian -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6285 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.walls@bywatersolutions. | |com Patch Status|Signed Off |Passed QA --- Comment #7 from Ian Walls <ian.walls@bywatersolutions.com> 2011-10-18 16:21:05 UTC --- explicitly-defined keys are consistent with data exported. The order is much more useful than alphabetical. Marking as Passed QA. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6285 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Passed QA |Patch Pushed --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> 2011-10-19 03:51:48 UTC --- Pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6285 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P5 - low Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org