http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15243 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15244 Severity|trivial |minor Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15244 [Bug 15244] t/db_dependent/Reserves.t fails with test 14 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15243 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45111|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 45289 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45289&action=edit Bug 15243 - Place a hold on... Fix display issue and improve translatability Temporary patch, will need more work 1.12..2015/mv -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15243 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45290|0 |1 is obsolete| | --- Comment #4 from Marc Véron <veron@veron.ch> --- Created attachment 45292 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45292&action=edit Bug 15243 - Place a hold on... Fix display issue and improve translatability This patch fixes strings in request.tt that are untranslatable because of splitting by html tags inside the strings. Additionally, the value of maxreserves was used in one string, but not filled in every case. That's why the patch introduces a new function GetAllowedReserves in C4/Reserves.pm to retrieve the maximum count of allowed reserves (depending on syspref maxreserves and on issuingrules). To test: - If not yet done, apply patch from Bug 15244 - Run t/db_dependent/Reserves.t, verify that it passes OK - Apply this patch - Run t/db_dependent/Reserves.t again, should pass OK - Set syspref 'maxreserves' to 1 - Try to place a hold for a patron who already has holds - Verify that the warning message displays the value above - Set the syspref to a high value - Try to place a hold for a patron who has reached the maximum allowed holds defined by issuing rules - Verify that the warning message with the maximum number of holds allowed by issuing rules - Try to trigger other warning messages and/or carefully review code in request.tt line 307 and following. Additonal messages to trigger are: - Already in possession - Hold already placed - Age restricted - No items available - Too many holds -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15243 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@univ-lyon3.fr Status|Needs Signoff |Failed QA --- Comment #5 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Tests made on french interface on sandbox (so Reserves.t have not been checked) 1) Too many holds : Seems ok under the aspect of the limit number but part of translation has not been set in staff interface test with maxreserves syspref = 1 message STAFF : Impossible de réserver Trop de réservations : Bruno B121 can only place a maximum of total 1 holds. OPAC Désolé, vous ne pouvez faire plus de 1 réservations. 2) Too many holds : on staff interface the hold is blocked as expected but the limit displayed does not correspond to the one set in circulation rules. on opac, the message is not correct. tested with reserves=2 set in circulations rules, "pukapuka" branch, type LIVRE. maxreserves=10. message STAFF Impossible de réserver Trop de réservations : Bruno B121 can only place a maximum of total 5 holds. OPAC Pas d'exemplaire disponible. 3) Already in possession : ok AllowHoldsOnPatronsPossessions syspref set to "not allow" message STAFF : Impossible de réserver Already in possession: Benjamin B111 has already one item checked out. message OPAC : Désolé, aucune réservation possible sur ces documents. .... Ce titre ne peut pas être réservé car il est déjà en votre possession. 4) Hold already placed : OK as for the message displayed, but here again, part of staff message is not translated. message STAFF : Impossible de réserver Hold already placed: Bruno B121 already has a hold on this item. message OPAC : Vous avez déjà ce titre en réservation. 5) Age restricted and No items available I dont't find how to produce theese messages. Can you give details ? Conclusion : Sorry, I can't sign off because of point 2. Maybe the incorrect translations come from a pure translation error, but maybe they are due to the Html splitting. Aesthetic remark (slightly ergonimic too, even I'm asking too much), that would be better to have only one frame for the messages (the generic and the precise one) like this : Désolé, aucune réservation possible sur ces documents. Ce titre ne peut pas être réservé car il est déjà en votre possession : Chercher la petite bête by Olliver C. rather than this : Désolé, aucune réservation possible sur ces documents. Ce titre ne peut pas être réservé car il est déjà en votre possession. Chercher la petite bête by Olliver C. Olivier Crouzet -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15243 --- Comment #7 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Seems it 's not the same behaviour nor a regression. I retried without the patches 15243 et 15244 for question 2. config : in Circulation rules, set limit at 2 on branch B for category C typedoc T. Maxreserves at 5. I can place a third hold on staff and opac interface as well (?!). I'm not blocked at all. no message. Olivier Crouzet -- You are receiving this mail because: You are watching all bug changes.