[Bug 34227] New: Add persistent selections and batch operations to item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34227 Bug ID: 34227 Summary: Add persistent selections and batch operations to item search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com I would like to add the same system of keeping persistent track of what item selections have been made to the item search results page, just like the patron search results page has. I would also like to add an option for performing batch item modification and batch item deletion using saved selections. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34227 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34227 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 153184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153184&action=edit Bug 34227: Add persistent selections and batch operations to item search This patch modifies the item search results page so that user selections are stored in local storage. This allows the user to make selections on one page of search results, move to another, and continue to make selections. The patch also adds the option to send selected items to batch item modification or batch item deletion. Changes to the patron search results template have been made to make some CSS classes more generic so they can be used by both pages. To test, apply the patch and rebuild the staff interface CSS. - Log in to the staff interface as a user with permission to perform batch item modification and batch item deletion. - Go to item search and perform a search which will return at least two pages of results. - On the search results page you should see a new search header toolbar with some controls: "Select visible rows," "Clear selection," "Export all results to" and "Batch operations" (disabled). - Without making any selections, confirm that the "Export all results to" menu items work correctly to export all results to a CSV or a barcode file. - Confirm that the "Select visible rows" control works as expected, selecting all checkboxes on the current page (and on no other pages) - After selecting all checkboxes the search header controls should be updated: - The "Export all..." button should now show the number of selections: "Export selected results (X) to..." - The batch operations button should be enabled. - There should be a new element labeled "Items selected: X" with a "Clear" link. - If you uncheck any checkboxes the controls should be updated, showing the new count of selected records. - Move to the next page of results and confirm that making selections on this page works to increment all counters - Confirm that the "Export selected.." options work and that your CSV and barcode files now contain only the items you selected. - Test the batch operations menu: - Test that the controls correctly reflect the logged-in user's permissions: - With permission to batch modify items - With permission to batch delete items - With both; with neither - Both menu options should take you to the correct page and the list of submitted items should match your selections. - Test that clicking the "Clear" button next to "Items selected" hides the items selected box and reverts the "Export all" and "Batch operations" buttons to their original state. - Page through the search results to confirm that no checkboxes are checked. - Test that your search selections are really persistent: - Navigate away from the page, return to item search, and perform another search. - The "Item selected" box should still show your previous selections. - Any items you previously selected which are also in this result set should have a checked checkbox. - Click the "Edit search" button from the item search results page and new search with different parameters. - The "Items selected" should still show your previous selections. - Log out of Koha and back in. When you perform an item search now, there should be no "Item selected" - Go to Patrons and test patron searching. As you make selections the "Patrons selected" box should be updated correctly and look correct, matching the one on the item search page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34227 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |samalau@gmail.com Status|Needs Signoff |Failed QA --- Comment #2 from Sam Lau <samalau@gmail.com> --- (In reply to Owen Leonard from comment #1)
- Confirm that the "Export selected.." options work and that your CSV and barcode files now contain only the items you selected.
Failing QA at this step. When nothing is selected, I can export to CSV and Barcode with no problem, but when I have anything selected, clicking the export buttons do nothing for me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34227 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34227 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153184|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 153208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153208&action=edit Bug 34227: Add persistent selections and batch operations to item search This patch modifies the item search results page so that user selections are stored in local storage. This allows the user to make selections on one page of search results, move to another, and continue to make selections. The patch also adds the option to send selected items to batch item modification or batch item deletion. Changes to the patron search results template have been made to make some CSS classes more generic so they can be used by both pages. To test, apply the patch and rebuild the staff interface CSS. - Log in to the staff interface as a user with permission to perform batch item modification and batch item deletion. - Go to item search and perform a search which will return at least two pages of results. - On the search results page you should see a new search header toolbar with some controls: "Select visible rows," "Clear selection," "Export all results to" and "Batch operations" (disabled). - Without making any selections, confirm that the "Export all results to" menu items work correctly to export all results to a CSV or a barcode file. - Confirm that the "Select visible rows" control works as expected, selecting all checkboxes on the current page (and on no other pages) - After selecting all checkboxes the search header controls should be updated: - The "Export all..." button should now show the number of selections: "Export selected results (X) to..." - The batch operations button should be enabled. - There should be a new element labeled "Items selected: X" with a "Clear" link. - If you uncheck any checkboxes the controls should be updated, showing the new count of selected records. - Move to the next page of results and confirm that making selections on this page works to increment all counters - Confirm that the "Export selected.." options work and that your CSV and barcode files now contain only the items you selected. - Test the batch operations menu: - Test that the controls correctly reflect the logged-in user's permissions: - With permission to batch modify items - With permission to batch delete items - With both; with neither - Both menu options should take you to the correct page and the list of submitted items should match your selections. - Test that clicking the "Clear" button next to "Items selected" hides the items selected box and reverts the "Export all" and "Batch operations" buttons to their original state. - Page through the search results to confirm that no checkboxes are checked. - Test that your search selections are really persistent: - Navigate away from the page, return to item search, and perform another search. - The "Item selected" box should still show your previous selections. - Any items you previously selected which are also in this result set should have a checked checkbox. - Click the "Edit search" button from the item search results page and new search with different parameters. - The "Items selected" should still show your previous selections. - Log out of Koha and back in. When you perform an item search now, there should be no "Item selected" - Go to Patrons and test patron searching. As you make selections the "Patrons selected" box should be updated correctly and look correct, matching the one on the item search page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34227 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34227 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153208|0 |1 is obsolete| | --- Comment #4 from Sam Lau <samalau@gmail.com> --- Created attachment 153285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153285&action=edit Bug 34227: Add persistent selections and batch operations to item search This patch modifies the item search results page so that user selections are stored in local storage. This allows the user to make selections on one page of search results, move to another, and continue to make selections. The patch also adds the option to send selected items to batch item modification or batch item deletion. Changes to the patron search results template have been made to make some CSS classes more generic so they can be used by both pages. To test, apply the patch and rebuild the staff interface CSS. - Log in to the staff interface as a user with permission to perform batch item modification and batch item deletion. - Go to item search and perform a search which will return at least two pages of results. - On the search results page you should see a new search header toolbar with some controls: "Select visible rows," "Clear selection," "Export all results to" and "Batch operations" (disabled). - Without making any selections, confirm that the "Export all results to" menu items work correctly to export all results to a CSV or a barcode file. - Confirm that the "Select visible rows" control works as expected, selecting all checkboxes on the current page (and on no other pages) - After selecting all checkboxes the search header controls should be updated: - The "Export all..." button should now show the number of selections: "Export selected results (X) to..." - The batch operations button should be enabled. - There should be a new element labeled "Items selected: X" with a "Clear" link. - If you uncheck any checkboxes the controls should be updated, showing the new count of selected records. - Move to the next page of results and confirm that making selections on this page works to increment all counters - Confirm that the "Export selected.." options work and that your CSV and barcode files now contain only the items you selected. - Test the batch operations menu: - Test that the controls correctly reflect the logged-in user's permissions: - With permission to batch modify items - With permission to batch delete items - With both; with neither - Both menu options should take you to the correct page and the list of submitted items should match your selections. - Test that clicking the "Clear" button next to "Items selected" hides the items selected box and reverts the "Export all" and "Batch operations" buttons to their original state. - Page through the search results to confirm that no checkboxes are checked. - Test that your search selections are really persistent: - Navigate away from the page, return to item search, and perform another search. - The "Item selected" box should still show your previous selections. - Any items you previously selected which are also in this result set should have a checked checkbox. - Click the "Edit search" button from the item search results page and new search with different parameters. - The "Items selected" should still show your previous selections. - Log out of Koha and back in. When you perform an item search now, there should be no "Item selected" - Go to Patrons and test patron searching. As you make selections the "Patrons selected" box should be updated correctly and look correct, matching the one on the item search page. Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34227 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34227 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153285|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 156007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156007&action=edit Bug 34227: Add persistent selections and batch operations to item search This patch modifies the item search results page so that user selections are stored in local storage. This allows the user to make selections on one page of search results, move to another, and continue to make selections. The patch also adds the option to send selected items to batch item modification or batch item deletion. Changes to the patron search results template have been made to make some CSS classes more generic so they can be used by both pages. To test, apply the patch and rebuild the staff interface CSS. - Log in to the staff interface as a user with permission to perform batch item modification and batch item deletion. - Go to item search and perform a search which will return at least two pages of results. - On the search results page you should see a new search header toolbar with some controls: "Select visible rows," "Clear selection," "Export all results to" and "Batch operations" (disabled). - Without making any selections, confirm that the "Export all results to" menu items work correctly to export all results to a CSV or a barcode file. - Confirm that the "Select visible rows" control works as expected, selecting all checkboxes on the current page (and on no other pages) - After selecting all checkboxes the search header controls should be updated: - The "Export all..." button should now show the number of selections: "Export selected results (X) to..." - The batch operations button should be enabled. - There should be a new element labeled "Items selected: X" with a "Clear" link. - If you uncheck any checkboxes the controls should be updated, showing the new count of selected records. - Move to the next page of results and confirm that making selections on this page works to increment all counters - Confirm that the "Export selected.." options work and that your CSV and barcode files now contain only the items you selected. - Test the batch operations menu: - Test that the controls correctly reflect the logged-in user's permissions: - With permission to batch modify items - With permission to batch delete items - With both; with neither - Both menu options should take you to the correct page and the list of submitted items should match your selections. - Test that clicking the "Clear" button next to "Items selected" hides the items selected box and reverts the "Export all" and "Batch operations" buttons to their original state. - Page through the search results to confirm that no checkboxes are checked. - Test that your search selections are really persistent: - Navigate away from the page, return to item search, and perform another search. - The "Item selected" box should still show your previous selections. - Any items you previously selected which are also in this result set should have a checked checkbox. - Click the "Edit search" button from the item search results page and new search with different parameters. - The "Items selected" should still show your previous selections. - Log out of Koha and back in. When you perform an item search now, there should be no "Item selected" - Go to Patrons and test patron searching. As you make selections the "Patrons selected" box should be updated correctly and look correct, matching the one on the item search page. Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34227 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 156008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156008&action=edit Bug 34227: (QA follow-up) Fix translation issue and add a space Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34227 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I really like this feature, but I think it would be nice if there was a way to see the selected items when you are coming back for a second different search. Also I am not sure if the "clear selected" and "clear" links are clear enough in their meaning. But: both are not blocker for me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34227 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34227 Lisette Scheer <lisette.scheer@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette.scheer@bywatersolut | |ions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34227 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Katrin Fischer from comment #7)
But: both are not blocker for me.
Thanks for clarifying. Reading your comments it felt like you PQA on something you wanted to FQA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34227 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34227 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34227 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Keywords| |release-notes-needed Status|Pushed to master |Needs documenting --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34227 --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 158061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158061&action=edit Bug 34227: (follow-up) Adjust selenium tests This patch adjusts the selenium tests to address the renamed ID for the elements. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34227 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com Blocks| |37778 --- Comment #12 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I was trying to document, but ran into bug 37778 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37778 [Bug 37778] Batch item modification and deletion from item search don't work -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34227 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Documentation| |Caroline Cyr La Rose contact| | Status|Needs documenting |RESOLVED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/951 Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34227 Catrina Berka <catrina@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |viktor.sarge@regionhalland. | |se --- Comment #13 from Catrina Berka <catrina@bywatersolutions.com> --- *** Bug 17330 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34227 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38438 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38438 [Bug 38438] Make Add persistent selections and batch operations to item search optional -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34227 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39032 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39032 [Bug 39032] "Items selected" in item search untranslatable -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org