[Bug 26886] New: OPAC suggestions: possible duplicate message should stand out more
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26886 Bug ID: 26886 Summary: OPAC suggestions: possible duplicate message should stand out more Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org I believe this message was styled differently pre Bootstrap update and stood out a bit more visually. To test: - Create a new suggestion in the OPAC for a title named test. - Create another suggestion for "Test". - Verify the duplicate message shows and the suggestion is not saved: A similar document already exists: Test. Click on "Confirm your suggestion" to ignore this message. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26886 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26886 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 112835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112835&action=edit Bug 26886: Correct style of alert-error class in the OPAC This patch makes a minor change to the OPAC SCSS so that instances of "alert-error" classes are styled the same as messages with the Bootstrap 4 "alert-warning" class. This change is simpler than making multiple changes to scripts and templates. To test, apply the patch and try to view a single news item in the OPAC which doesn't exist: /cgi-bin/koha/opac-main.pl?news_id=XXX - You should see a warning message with a pale yellow background, "This news item does not exist." - Submit a suggestion, and then submit another suggestion with the same title. - You should see a warning message, "The suggestion has not been added. A suggestion with this title already exists." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26886 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26886 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112835|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 112911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112911&action=edit Bug 26886: Correct style of alert-error class in the OPAC This patch makes a minor change to the OPAC SCSS so that instances of "alert-error" classes are styled the same as messages with the Bootstrap 4 "alert-warning" class. This change is simpler than making multiple changes to scripts and templates. To test, apply the patch and try to view a single news item in the OPAC which doesn't exist: /cgi-bin/koha/opac-main.pl?news_id=XXX - You should see a warning message with a pale yellow background, "This news item does not exist." - Submit a suggestion, and then submit another suggestion with the same title. - You should see a warning message, "The suggestion has not been added. A suggestion with this title already exists." Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26886 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Testing note: - Need to updated the OPAC CSS - see https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26886 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26886 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112911|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 112955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112955&action=edit Bug 26886: Correct style of alert-error class in the OPAC This patch makes a minor change to the OPAC SCSS so that instances of "alert-error" classes are styled the same as messages with the Bootstrap 4 "alert-warning" class. This change is simpler than making multiple changes to scripts and templates. To test, apply the patch and try to view a single news item in the OPAC which doesn't exist: /cgi-bin/koha/opac-main.pl?news_id=XXX - You should see a warning message with a pale yellow background, "This news item does not exist." - Submit a suggestion, and then submit another suggestion with the same title. - You should see a warning message, "The suggestion has not been added. A suggestion with this title already exists." Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26886 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26886 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org