[Bug 39141] New: Page is blank when visiting Circulation Check In
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39141 Bug ID: 39141 Summary: Page is blank when visiting Circulation Check In Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com
From Koha home click 'Circulation' then 'Check out' You are on a page with a header search, but no content, this can be odd
For contrast: 'Circulation' -> 'Check in' You have a form in the page to return items -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39141 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39141 --- Comment #1 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 178092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178092&action=edit Bug 39141: Add a patron search box on Circulation - Checkout This patch adds a search box when visiting the check out page before a patron has been selected To test: 1 - From Koha home browse to Circulation -> Check out 2 - Note an empty page, though you have the header search forms 3 - Apply patch 4 - Repeate above - now you have a patron search box 5 - Search by name or cardnumber 6 - Confirm search works as expected 7 - Sign off! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39141 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 178095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178095&action=edit Bug 39141: (follow-up) Style input and add autocomplete This patch adds some friendly styling to the new form and adds autocomplete functionality. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39141 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178092|0 |1 is obsolete| | --- Comment #3 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 178121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178121&action=edit Bug 39141: Add a patron search box on Circulation - Checkout This patch adds a search box when visiting the check out page before a patron has been selected To test: 1 - From Koha home browse to Circulation -> Check out 2 - Note an empty page, though you have the header search forms 3 - Apply patch 4 - Repeate above - now you have a patron search box 5 - Search by name or cardnumber 6 - Confirm search works as expected 7 - Sign off! Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39141 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178095|0 |1 is obsolete| | --- Comment #4 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 178122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178122&action=edit Bug 39141: (follow-up) Style input and add autocomplete This patch adds some friendly styling to the new form and adds autocomplete functionality. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39141 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |barbara.johnson@bedfordtx.g | |ov -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39141 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Why not use patron-search-box.inc ? And its permissions check? Also note that it includes an id="findborrower". Why do you change to findborrower_main: - <input autocomplete="off" id="findborrower" name="findborrower" type="text" placeholder="Enter patron card number or partial name" size="40" /> + <input autocomplete="off" id="findborrower_main" name="findborrower" type="text" placeholder="Enter patron card number or partial name" size="40" /> Needs feedback -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39141 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39141 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Marcel de Rooy from comment #5)
Why not use patron-search-box.inc ? And its permissions check?
The markup in patron-search-box.inc is specific to the header search tabs and cannot be easily reused here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39141 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com QA Contact|testopia@bugs.koha-communit |baptiste.wojtkowski@biblibr |y.org |e.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39141 --- Comment #7 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Shouldn't we try and reuse the tool used in reserve/request.pl ? It might be improved in a separate patch later if you don't want to now ; this works and is a good increment. At the moment please reuse the styles used in "check in" for the barcode. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39141 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Page is blank when visiting |Page is blank when visiting |Circulation Check In |Circulation - Check out -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39141 --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Adjusted the title that referred to Check in -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39141 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39141 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178121|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 179318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179318&action=edit Bug 39141: Add a patron search box on Circulation - Checkout This patch adds a search box when visiting the check out page before a patron has been selected To test: 1 - From Koha home browse to Circulation -> Check out 2 - Note an empty page, though you have the header search forms 3 - Apply patch 4 - Repeate above - now you have a patron search box 5 - Search by name or cardnumber 6 - Confirm search works as expected 7 - Sign off! Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39141 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178122|0 |1 is obsolete| | --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 179319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179319&action=edit Bug 39141: (follow-up) Style input and add autocomplete This patch adds some friendly styling to the new form and adds autocomplete functionality. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39141 --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Baptiste Wojtkowski (bwoj) from comment #7)
Shouldn't we try and reuse the tool used in reserve/request.pl ? It might be improved in a separate patch later if you don't want to now ; this works and is a good increment.
At the moment please reuse the styles used in "check in" for the barcode.
Lets do further improvements on follow-up reports. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39141 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|baptiste.wojtkowski@biblibr |m.de.rooy@rijksmuseum.nl |e.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39141 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Page is blank when visiting |Page is blank when visiting |Circulation - Check out |circulation / check out -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39141 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- As this has been like this forever, I feel it qualifies more as an enhancement. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39141 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I made the page heading "Check out" to match the name on the Circulation page and also consistent with "Check in". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39141 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39141 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39141 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Page is blank when visiting |Add search box to checkout |circulation / check out |page Text to go in the| |When visiting the checkouts release notes| |page without having | |selected a patron, the page | |was empty. Now it shows a | |patron search box to help | |in selecting the patron. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39141 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/1080 Documentation| |Caroline Cyr La Rose contact| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39141 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #15 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39141 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #16 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Manual done already. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org