[Bug 18557] New: Mysqlim CURRENT_DATE in Koha::Clubs::get_enrollable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18557 Bug ID: 18557 Summary: Mysqlim CURRENT_DATE in Koha::Clubs::get_enrollable Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: kyle@bywatersolutions.com Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Depends on: 12461 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 [Bug 12461] Add patron clubs feature -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18557 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18557 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 63281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63281&action=edit Bug 18557 - Mysqlim CURRENT_DATE in Koha::Clubs::get_enrollable Test Plan: 1) Apply this patch 2) prove t/db_dependent/Clubs.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18557 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18557 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63281|0 |1 is obsolete| | --- Comment #2 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 63285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63285&action=edit [SIGNED-OFF] Bug 18557 - Mysqlim CURRENT_DATE in Koha::Clubs::get_enrollable Test Plan: 1) Apply this patch 2) prove t/db_dependent/Clubs.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18557 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Kyle, my understanding is that the best would be to use dt_from_string: my $dtf = Koha::Database->new->schema->storage->datetime_parser; then ->search({ date_end => { '>=' => $dtf->format_datetime( dt_from_string() ) } }) Do not you think? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18557 --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #3)
Kyle, my understanding is that the best would be to use dt_from_string:
my $dtf = Koha::Database->new->schema->storage->datetime_parser; then ->search({ date_end => { '>=' => $dtf->format_datetime( dt_from_string() ) } })
Do not you think?
That works for me! Followup incoming! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18557 --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 63290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63290&action=edit Bug 18557 [QA Followup] - Use dt_from_string -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18557 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18557 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63285|0 |1 is obsolete| | Attachment #63290|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 63305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63305&action=edit Bug 18557 - Mysqlim CURRENT_DATE in Koha::Clubs::get_enrollable Test Plan: 1) Apply this patch 2) prove t/db_dependent/Clubs.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18557 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 63306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63306&action=edit Bug 18557 [QA Followup] - Use dt_from_string Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18557 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18557 Bug 18557 depends on bug 12461, which changed state. Bug 12461 Summary: Add patron clubs feature https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18557 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |katrin.fischer@bsz-bw.de --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Depends on bug 12461 which is not part of 16.11.x. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org