[Bug 16808] New: Serial claims: claiming via CSV export doesn't reload the page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16808 Bug ID: 16808 Summary: Serial claims: claiming via CSV export doesn't reload the page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com When using the CSV export for claiming serial issues, with bug 12178 the claim counter is incremented and a claim date set, but this will only be visible after reloading the page manually as the feature itself doesn't reload the page. To avoid confusion and errors using this feature,, the page should reload when the claims data is changed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16808 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12178 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12178 [Bug 12178] Serial claims: exporting late issues with the CSV profile doesn't set the issue claimed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16808 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16808 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16808 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 52809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52809&action=edit Bug 16808 - Serial claims: claiming via CSV export doesn't reload the page When using the CSV export for claiming serial issues, with bug 12178 the claim counter is incremented and a claim date set, but this will only be visible after reloading the page manually as the feature itself doesn't reload the page. To avoid confusion and errors using this feature,, the page should reload when the claims data is changed. Test Plan: 1) Claim some serials 2) Note the page does not reload, the status is not set to 'claimed' 3) Apply this patch 4) Claim some serials 5) Note the page reloads and verify that the status of the selected serials are "claimed" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16808 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16808 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16808 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52809|0 |1 is obsolete| | --- Comment #2 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 53855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53855&action=edit Bug 16808 - Serial claims: claiming via CSV export doesn't reload the page When using the CSV export for claiming serial issues, with bug 12178 the claim counter is incremented and a claim date set, but this will only be visible after reloading the page manually as the feature itself doesn't reload the page. To avoid confusion and errors using this feature,, the page should reload when the claims data is changed. Test Plan: 1) Claim some serials 2) Note the page does not reload, the status is not set to 'claimed' 3) Apply this patch 4) Claim some serials 5) Note the page reloads and verify that the status of the selected serials are "claimed" Signed-off-by: Frédéric Demians <f.demians@tamil.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16808 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The way this patch works creates a warning about resending the page in Firefox 47 (mine is German, so copying the message here probably won't help much). This might turn some users away thinking it's a bug, especially since the message appears before the download with a warning sound. Is there a better way to achieve that? Could we not just reload the page like other forms do? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16808 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The warning reads something like this: this will make firefox reload the page and will cause all actions to be repeated (like a search or an ordering process) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16808 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com --- Comment #5 from Josef Moravec <josef.moravec@gmail.com> --- We could change the vendor selecting form method from post to get - it should allow to avoid this message... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16808 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16808 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I've tested by changing to GET and the error message in Firefox remains. Could we trigger relaod of the page server side? Use Ajax? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16808 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20614 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org