[Bug 24627] New: Selecting Club for which to place the hold is missing Box to Select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24627 Bug ID: 24627 Summary: Selecting Club for which to place the hold is missing Box to Select Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: kelly@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Created attachment 98686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98686&action=edit select In almost all places in Koha, when a user is given a list of options in the Hold Menu, the option to choose is indicated with either a button to pick or a circle to check. This is indicating a choice has been made. When picking which Club to place a book club book for, there is no indication, that a choice can be made. Yes, the club can be chosen (by clicking the words) but it is not the usual way for Koha, and I think users will be confused. See screenshot. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24627 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Selecting Club for which to |Correct style of clubs |place the hold is missing |search results during hold |Box to Select |process Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Component|Hold requests |Templates Version|19.11 |master --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- It is the usual way if we look at the way patrons are chosen from search results during the hold process. The difference is that search results table of Clubs doesn't have the hover style to help indicate that the rows are clickable. I'm updating the but title to reflect this. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24627 --- Comment #2 from Kelly McElligott <kelly@bywatersolutions.com> --- Thanks Owen! I had a hard time figuring out the correct words to make this understandable. If others don't have an issue with this way to click, that if fine, I felt it was odd. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24627 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24627 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24627 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 98713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98713&action=edit Bug 24627: Correct style of clubs search results during hold process This patch updates some markup and CSS so that the process of selecting a club from search results during the hold process looks the same as when selecting a patron: Club names should be links (like patron names are) and the table row should have a hover color to help indicate that it is clickable. This patch also changes the markup of the Patrons/Clubs tabs a little bit to make the information clearer: Superfluous Bootstrap-related tab markup has been removed, and the patron and club search results have been moved into their respective tab containers. This means that if you search for a patron but then switch to the clubs tab the patron list doesn't still display. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) - You should have more than one patron club defined. - Begin the process of placing a hold on a title. - Test the process of searching for both patrons and clubs. - In each case the name (patron or club) should be an active link. - Hovering your mouse over the table rows should change the row background to yellow. - Clicking the other tab at this stage should hide the search results from your last search. - Whether you click the linked name or elsewhere in the table row you should be correctly redirected to the next step in the holds process. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24627 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |lisetteslatah@gmail.com --- Comment #4 from Lisette Scheer <lisetteslatah@gmail.com> --- It works except 2 different links are generated for clubs. If you click directly on the club name, you get this: http://localhost:8081/cgi-bin/koha/reserve/%2Fcgi-bin%2Fkoha%2Freserve%2Freq... If you click anywhere else on the table line you get this: http://localhost:8081/cgi-bin/koha/reserve/request.pl?club=2&biblionumbe... Only the 2nd one works for me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24627 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98713|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 100043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100043&action=edit Bug 24627: Correct style of clubs search results during hold process This patch updates some markup and CSS so that the process of selecting a club from search results during the hold process looks the same as when selecting a patron: Club names should be links (like patron names are) and the table row should have a hover color to help indicate that it is clickable. This patch also changes the markup of the Patrons/Clubs tabs a little bit to make the information clearer: Superfluous Bootstrap-related tab markup has been removed, and the patron and club search results have been moved into their respective tab containers. This means that if you search for a patron but then switch to the clubs tab the patron list doesn't still display. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) - You should have more than one patron club defined. - Begin the process of placing a hold on a title. - Test the process of searching for both patrons and clubs. - In each case the name (patron or club) should be an active link. - Hovering your mouse over the table rows should change the row background to yellow. - Clicking the other tab at this stage should hide the search results from your last search. - Whether you click the linked name or elsewhere in the table row you should be correctly redirected to the next step in the holds process. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24627 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24627 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24627 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100043|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 100306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100306&action=edit Bug 24627: Correct style of clubs search results during hold process This patch updates some markup and CSS so that the process of selecting a club from search results during the hold process looks the same as when selecting a patron: Club names should be links (like patron names are) and the table row should have a hover color to help indicate that it is clickable. This patch also changes the markup of the Patrons/Clubs tabs a little bit to make the information clearer: Superfluous Bootstrap-related tab markup has been removed, and the patron and club search results have been moved into their respective tab containers. This means that if you search for a patron but then switch to the clubs tab the patron list doesn't still display. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) - You should have more than one patron club defined. - Begin the process of placing a hold on a title. - Test the process of searching for both patrons and clubs. - In each case the name (patron or club) should be an active link. - Hovering your mouse over the table rows should change the row background to yellow. - Clicking the other tab at this stage should hide the search results from your last search. - Whether you click the linked name or elsewhere in the table row you should be correctly redirected to the next step in the holds process. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24627 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24627 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100306|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 100701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100701&action=edit Bug 24627: Correct style of clubs search results during hold process This patch updates some markup and CSS so that the process of selecting a club from search results during the hold process looks the same as when selecting a patron: Club names should be links (like patron names are) and the table row should have a hover color to help indicate that it is clickable. This patch also changes the markup of the Patrons/Clubs tabs a little bit to make the information clearer: Superfluous Bootstrap-related tab markup has been removed, and the patron and club search results have been moved into their respective tab containers. This means that if you search for a patron but then switch to the clubs tab the patron list doesn't still display. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) - You should have more than one patron club defined. - Begin the process of placing a hold on a title. - Test the process of searching for both patrons and clubs. - In each case the name (patron or club) should be an active link. - Hovering your mouse over the table rows should change the row background to yellow. - Clicking the other tab at this stage should hide the search results from your last search. - Whether you click the linked name or elsewhere in the table row you should be correctly redirected to the next step in the holds process. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24627 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24627 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24627 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|20.05.00 |20.05.00, 19.11.05 released in| | --- Comment #9 from Joy Nelson <joy@bywatersolutions.com> --- Backported to 19.11.x branch for 19.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24627 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- not needed in 19.05.x, no backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24627 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29195 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24627 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29521 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29521 [Bug 29521] Patron Club name hyperlinks not operational + weird CSS behavior -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org