[Bug 31519] New: Unused template parameters in request.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31519 Bug ID: 31519 Summary: Unused template parameters in request.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: joonas.kylmala@iki.fi QA Contact: testopia@bugs.koha-community.org reserve/request.pl sets SuspendHoldsIntranet and AutoResumeSuspendedHolds template parameters which are not used in any templates or template includes. Those should be removed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31519 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31519 --- Comment #1 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 140199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140199&action=edit Bug 31519: Remove unused SuspendHoldsIntranet and AutoResumeSuspendedHolds variables If you grep koha-tmpl/intranet-tmpl/prog/en for those you will see there are no references for those. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31519 --- Comment #2 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 140200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140200&action=edit Bug 31519: Move preference fetching directly to be done in the template Since we are not in a loop or using this multiple times it's simple to do it this way, helps with changing the template code in the future too since if we want to remove this syspref variable we know it is only used in this one particular place. To test: 1) Grep for reserve_in_future and make sure there are no matches after applying this patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31519 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |joonas.kylmala@iki.fi |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31519 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31519 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140199|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 140741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140741&action=edit Bug 31519: Remove unused SuspendHoldsIntranet and AutoResumeSuspendedHolds variables If you grep koha-tmpl/intranet-tmpl/prog/en for those you will see there are no references for those. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31519 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140200|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 140742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140742&action=edit Bug 31519: Move preference fetching directly to be done in the template Since we are not in a loop or using this multiple times it's simple to do it this way, helps with changing the template code in the future too since if we want to remove this syspref variable we know it is only used in this one particular place. To test: 1) Grep for reserve_in_future and make sure there are no matches after applying this patch Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31519 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #5 from David Nind <david@davidnind.com> --- Have signed off, but noted that there are two occurrences after running git grep reserve_in_future that relate to the OPAC: root@kohadevbox:koha(bz31519)$ git grep reserve_in_future koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt: [% IF ( reserve_in_future ) %] opac/opac-reserve.pl: reserve_in_future => 1, I'm assuming that's because this bug is only making changes to the staff interface. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31519 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31519 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31519 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140741|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 141534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141534&action=edit Bug 31519: Remove unused SuspendHoldsIntranet and AutoResumeSuspendedHolds variables If you grep koha-tmpl/intranet-tmpl/prog/en for those you will see there are no references for those. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31519 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140742|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 141535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141535&action=edit Bug 31519: Move preference fetching directly to be done in the template Since we are not in a loop or using this multiple times it's simple to do it this way, helps with changing the template code in the future too since if we want to remove this syspref variable we know it is only used in this one particular place. To test: 1) Grep for reserve_in_future and make sure there are no matches after applying this patch Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31519 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31519 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31519 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org