[Bug 31360] New: Add biblio_id to after_item_action hook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31360 Bug ID: 31360 Summary: Add biblio_id to after_item_action hook Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org Trivial one liner. Add biblionumber too when calling the after_item_action plugin. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31360 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31360 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31360 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 139118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139118&action=edit Bug 31360: Add biblio_id to after_item_action hook No test plan. Just adding an parameter that may or may not be useful for the attached plugin. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31360 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Why? Cannot you access it with $item->biblionumber? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31360 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- See commit 7d35052a14df66e9c5fe5d70378d36a6b1edb94d Bug 23463: Move plugin hook We kept item_id for backward compatibility, but now you can access all item's attributes using 'item'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31360 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31360 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #2)
Why? Cannot you access it with $item->biblionumber?
It would need plugin changes that already assume presence of biblio_id just as the biblio hooks offer. (In reply to Jonathan Druart from comment #3)
See commit 7d35052a14df66e9c5fe5d70378d36a6b1edb94d Bug 23463: Move plugin hook
We kept item_id for backward compatibility, but now you can access all item's attributes using 'item'.
If we allow item_id for backward compatiblity, this could be done for biblio_id too. No big deal? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31360 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Marcel de Rooy from comment #4)
(In reply to Jonathan Druart from comment #2)
Why? Cannot you access it with $item->biblionumber?
It would need plugin changes that already assume presence of biblio_id just as the biblio hooks offer.
Are you expecting Koha core to fix plugin's code that has always been broken? :D
(In reply to Jonathan Druart from comment #3)
See commit 7d35052a14df66e9c5fe5d70378d36a6b1edb94d Bug 23463: Move plugin hook
We kept item_id for backward compatibility, but now you can access all item's attributes using 'item'.
If we allow item_id for backward compatiblity, this could be done for biblio_id too. No big deal?
but biblio_id never existed there... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31360 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|In Discussion |RESOLVED --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Okay the battle is lost :) I'll look at the plugin. See you next time. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org