[Bug 30849] New: Make pending patron modification notices on staff main page number of modifications at logged in branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30849 Bug ID: 30849 Summary: Make pending patron modification notices on staff main page number of modifications at logged in branch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com On the staff main page pending suggestions show some like: Suggestions pending approval: Centerville: 2 / All libraries: 100 It would be nice if we could do the same thing with pending patron modifications Patrons requesting modifications: Centerville: 2 / All libraries: 100 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30849 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30849 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 135823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135823&action=edit Bug 30849: show pending modifications by branch To test: 1. Add some borrower modifications from the OPAC from patrons that belong to some different libraries. 2. On the staff client mainpage (mainpage.pl) you should see a link 'Patrons requesting modifications:' but no way of knowing if they are patrons from your logged in branch or not 3. Apply patch, restart_all 4. Try step 2 again and now you should see something like 'Patrons requesting modifications: Centerville: 1 / All libraries: 2'; 5. Trying and and fulfilling some modifcations and make sure the numbers on mainpage.pl are always correct. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30849 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30849 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135823|0 |1 is obsolete| | --- Comment #2 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 137644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137644&action=edit Bug 30849: show pending modifications by branch To test: 1. Add some borrower modifications from the OPAC from patrons that belong to some different libraries. 2. On the staff client mainpage (mainpage.pl) you should see a link 'Patrons requesting modifications:' but no way of knowing if they are patrons from your logged in branch or not 3. Apply patch, restart_all 4. Try step 2 again and now you should see something like 'Patrons requesting modifications: Centerville: 1 / All libraries: 2'; 5. Trying and and fulfilling some modifcations and make sure the numbers on mainpage.pl are always correct. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30849 Daniel Jones <daniel.jones@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |daniel.jones@cheshireshared | |services.gov.uk Status|Needs Signoff |Signed Off --- Comment #3 from Daniel Jones <daniel.jones@cheshiresharedservices.gov.uk> --- Works as described, great idea for a feature. I noticed this creates two links that both lead to the same location. At first glance it looks like the first link will only take you to patrons of that library who require approval. Maybe if it was all one link it would be clearer that the destination is the same. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30849 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 1) I am not sure if we don't give off the wrong impression here. The link for "my library" and "all libraries" is the same, because the patron modification page doesn't filter. But I think having 2 links would give off the impression that they behave differently. Would it be possible to create a link that filters? Or maybe we keep the link on the Patrons requesting... and not on the numbers. 2) We don't take IndependentBranchesPatronModifications into account. I believe if that is 'on' we should only show the library count and could hide the all libraries one. 3) When there are no modification requests for the current library, it reads: Patrons requesting modifications: Centerville: / All libraries: 1 For suggestions we show 0 here, which is a little nicer. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30849 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30849 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137644|0 |1 is obsolete| | --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 190826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190826&action=edit Bug 30849: show pending modifications by branch To test: 1. Add some borrower modifications from the OPAC from patrons that belong to some different libraries. 2. On the staff client mainpage (mainpage.pl) you should see a link 'Patrons requesting modifications:' but no way of knowing if they are patrons from your logged in branch or not 3. Apply patch, restart_all 4. Try step 2 again and now you should see something like 'Patrons requesting modifications: Centerville: 1 / All libraries: 2'; 5. Turn on IndependentBranchesPatronModifications. 6. Log in as a superlibrarian, you should see branch specific and All libraries requests. 7. Log in as a non-superlibrarian, you should only see requests for your branch. 8. Trying and and fulfilling some modifcations and make sure the numbers on mainpage.pl are always correct. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30849 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190826|0 |1 is obsolete| | --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 190828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190828&action=edit Bug 30849: show pending modifications by branch To test: 1. Add some borrower modifications from the OPAC from patrons that belong to some different libraries. 2. On the staff client mainpage (mainpage.pl) you should see a link 'Patrons requesting modifications:' but no way of knowing if they are patrons from your logged in branch or not 3. Apply patch, restart_all 4. Try step 2 again and now you should see something like 'Patrons requesting modifications: Centerville: 1 / All libraries: 2'; 5. Turn on IndependentBranchesPatronModifications. 6. Log in as a superlibrarian, you should see branch specific and All libraries requests. 7. Log in as a non-superlibrarian, you should only see requests for your branch. 8. Trying and and fulfilling some modifcations and make sure the numbers on mainpage.pl are always correct. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30849 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190828|0 |1 is obsolete| | --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 190840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190840&action=edit Bug 30849: show pending modifications by branch To test: 1. Add some borrower modifications from the OPAC from patrons that belong to some different libraries. 2. On the staff client mainpage (mainpage.pl) you should see a link 'Patrons requesting modifications:' but no way of knowing if they are patrons from your logged in branch or not 3. Apply patch, restart_all 4. Try step 2 again and now you should see something like 'Patrons requesting modifications: Centerville: 1 / All libraries: 2'; 5. Turn on IndependentBranchesPatronModifications. 6. Log in as a superlibrarian, you should see branch specific and All libraries requests. 7. Log in as a non-superlibrarian, you should only see requests for your branch. 8. Trying and and fulfilling some modifcations and make sure the numbers on mainpage.pl are always correct. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30849 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190840|0 |1 is obsolete| | --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 190842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190842&action=edit Bug 30849: show pending modifications by branch To test: 1. Add some borrower modifications from the OPAC from patrons that belong to some different libraries. 2. On the staff client mainpage (mainpage.pl) you should see a link 'Patrons requesting modifications:' but no way of knowing if they are patrons from your logged in branch or not 3. Apply patch, restart_all 4. Try step 2 again and now you should see something like 'Patrons requesting modifications: Centerville: 1 / All libraries: 2'; 5. Turn on IndependentBranchesPatronModifications. 6. Log in as a superlibrarian, you should see branch specific and All libraries requests. 7. Log in as a non-superlibrarian, you should only see requests for your branch. 8. Trying and and fulfilling some modifcations and make sure the numbers on mainpage.pl are always correct. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30849 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36063 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36063 [Bug 36063] Add Holds to Pull info to intranet-main page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30849 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Make pending patron |Make 'pending patron |modification notices on |modification notices' on |staff main page number of |staff home page 'number of |modifications at logged in |modifications at logged in |branch |library' --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Had to read the description a few times until I got it, hope this improves readability a little :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30849 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |nick@bywatersolutions.com --- Comment #10 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- The general count is: my $pending_borrower_modifications = Koha::Patron::Modifications->pending_count($branch); branch comes from: 75 my $branch = 76 ( C4::Context->preference("IndependentBranchesPatronModifications") 77 || C4::Context->preference("IndependentBranches") ) 78 && !$flags->{'superlibrarian'} 79 ? C4::Context->userenv()->{'branch'} 80 : undef; Then in the template: [% IF Koha.Preference('IndependentBranchesPatronModifications') && !CAN_user_superlibrarian %] Seems like that search can drop the $branch and we can use $local_pendingmodifications_count in the template Otherwise for independent branches we are doing the same branch limited search twice -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30849 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190842|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30849 Catrina Berka <catrina@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |catrina@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30849 --- Comment #11 from Catrina Berka <catrina@bywatersolutions.com> --- Not sure what got this hung up but it would be a nice feature for libraries with many branches and consortia -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30849 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190842|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30849 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30849 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190842|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30849 --- Comment #12 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 201465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201465&action=edit Bug 30849: show pending modifications by branch To test: 1. Add some borrower modifications from the OPAC from patrons that belong to some different libraries. 2. On the staff client mainpage (mainpage.pl) you should see a link 'Patrons requesting modifications:' but no way of knowing if they are patrons from your logged in branch or not 3. Apply patch, restart_all 4. Try step 2 again and now you should see something like 'Patrons requesting modifications: Centerville: 1 / All libraries: 2'; 5. Turn on IndependentBranchesPatronModifications. 6. Log in as a superlibrarian, you should see branch specific and All libraries requests. 7. Log in as a non-superlibrarian, you should only see requests for your branch. 8. Trying and and fulfilling some modifcations and make sure the numbers on mainpage.pl are always correct. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30849 --- Comment #13 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- I believe I addressed all of Kartin and Nick's concerns now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30849 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org