[Bug 18484] New: opac-advsearch.tt missing closing div tag for <div class= "container-fluid">
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18484 Bug ID: 18484 Summary: opac-advsearch.tt missing closing div tag for <div class="container-fluid"> Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: barton@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org I ran the opac advanced search page through https://validator.w3.org/ It gave a fatal error on the closing </form> tag following </div> <!-- / .main --> due to a missing </div> tag which should match <div class="container-fluid">. This is happening in master, and goes back at least as far as 3.18. It doesn't affect the rendering of the page, as far as I can tell. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18484 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18484 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|opac-advsearch.tt missing |opac-advsearch.tt missing |closing div tag for <div |closing div tag for |class="container-fluid"> |.container-fluid -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18484 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18484 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 62608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62608&action=edit Bug 18484 - opac-advsearch.tt missing closing div tag for .container-fluid This patch corrects HTML validation errors by adding back a missing </div> which was removed accidentally by Bug 9043 (2014!). This patch also removes "border" attributes from <img> tags because the attribute is obsolete. To test, apply the patch and test the validity of the OPAC's advanced search page. The only error should be one about 'Bad value "api-server,"' which isn't really resolvable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18484 Barton Chittenden <barton@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18484 Barton Chittenden <barton@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62608|0 |1 is obsolete| | --- Comment #2 from Barton Chittenden <barton@bywatersolutions.com> --- Created attachment 62650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62650&action=edit Bug 18484 - opac-advsearch.tt missing closing div tag for .container-fluid This patch corrects HTML validation errors by adding back a missing </div> which was removed accidentally by Bug 9043 (2014!). This patch also removes "border" attributes from <img> tags because the attribute is obsolete. To test, apply the patch and test the validity of the OPAC's advanced search page. The only error should be one about 'Bad value "api-server,"' which isn't really resolvable. Signed-off-by: Barton Chittenden <barton@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18484 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18484 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62650|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 62748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62748&action=edit Bug 18484 - opac-advsearch.tt missing closing div tag for .container-fluid This patch corrects HTML validation errors by adding back a missing </div> which was removed accidentally by Bug 9043 (2014!). This patch also removes "border" attributes from <img> tags because the attribute is obsolete. To test, apply the patch and test the validity of the OPAC's advanced search page. The only error should be one about 'Bad value "api-server,"' which isn't really resolvable. Signed-off-by: Barton Chittenden <barton@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18484 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18484 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.08. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18484 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18484 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> --- Pushed to 3.22.x for 3.22.21 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18484 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #7 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.13 release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org