[Bug 28125] New: All OPAC holds blocked when OPACHiddenItems contains incorrect values
From bug 15448, we're now checking OPACHiddenItems to see if something is hidden before we allow a hold on it. However, the manner in which that check is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28125 Bug ID: 28125 Summary: All OPAC holds blocked when OPACHiddenItems contains incorrect values Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 15448 performed causes a problem if the syspref contains incorrect values. To recreate: - make sure OPACHiddenItems is empty - find a holdable item on the OPAC, confirm you can place a hold on it - enter "itemlost: [AB]" in OPACHiddenItems (an incorrect value because itemlost can only contain 1 bit) - confirm your item is not hidden from the OPAC but you are told it is not available for holds You'll see the same behavior if you use an incorrect field name, like "lost" or "itemtype." Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15448 [Bug 15448] Placing hold on specific items doesn't enforce OpacHiddenItems -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28125 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28125 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 119513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119513&action=edit Bug 28125: Display a warning on the about page for OPACHiddenItems is needed If OPACHiddenItems is containing badly construct it will lead to inconsistent behaviours. For instance the holds view will not display any items, when the detail page will display all of them (because we are not using the same code, we are in transition to merge it). This patch suggests to add a warning to the about page in case the query generated by Koha::Items->filter_by_visible_in_opac produces a warning -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28125 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The only thing I can think of is to display a warning to the about page. Would that work for you, Andrew? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28125 --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 119534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119534&action=edit Message larger than table Seems reasonable! The real pain here is that it took a while to figure out that this system preference was the cause of the error, so a warning is definitely helpful. I've got a really picky display complaint, though. On Chrome, the warning message ends up a little longer than the table itself and doesn't look good. Can you make the table resize to fit the message? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28125 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119513|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 119539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119539&action=edit Bug 28125: Display a warning on the about page for OPACHiddenItems is needed If OPACHiddenItems is containing badly construct it will lead to inconsistent behaviours. For instance the holds view will not display any items, when the detail page will display all of them (because we are not using the same code, we are in transition to merge it). This patch suggests to add a warning to the about page in case the query generated by Koha::Items->filter_by_visible_in_opac produces a warning -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28125 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Andrew Fuerste-Henry from comment #3)
I've got a really picky display complaint, though. On Chrome, the warning message ends up a little longer than the table itself and doesn't look good. Can you make the table resize to fit the message?
There was a td instead of a th, should be fixed now! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28125 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28125 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119539|0 |1 is obsolete| | --- Comment #6 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 119540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119540&action=edit Bug 28125: Display a warning on the about page for OPACHiddenItems is needed If OPACHiddenItems is containing badly construct it will lead to inconsistent behaviours. For instance the holds view will not display any items, when the detail page will display all of them (because we are not using the same code, we are in transition to merge it). This patch suggests to add a warning to the about page in case the query generated by Koha::Items->filter_by_visible_in_opac produces a warning Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28125 --- Comment #7 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28125 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28125 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119540|0 |1 is obsolete| | --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 119682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119682&action=edit Bug 28125: Display a warning on the about page for OPACHiddenItems is needed If OPACHiddenItems is containing badly construct it will lead to inconsistent behaviours. For instance the holds view will not display any items, when the detail page will display all of them (because we are not using the same code, we are in transition to merge it). This patch suggests to add a warning to the about page in case the query generated by Koha::Items->filter_by_visible_in_opac produces a warning Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28125 --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 119683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119683&action=edit Bug 28125: (QA follow-up) Fix missing filter Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28125 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28125 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28125 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27662 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28125 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Patches have been squashed is master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28125 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00 |21.05.00,20.11.06 released in| | Status|Pushed to master |Pushed to stable --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28125 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28359 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28125 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28125 Bug 28125 depends on bug 15448, which changed state. Bug 15448 Summary: Placing hold on specific items doesn't enforce OpacHiddenItems https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15448 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28125 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31473 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31473 [Bug 31473] Test about bad OpacHiddenItems conf fragile -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org