[Bug 28123] New: Commas in file names of uploaded files cause inconsistently broken 856$u links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28123 Bug ID: 28123 Summary: Commas in file names of uploaded files cause inconsistently broken 856$u links Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl To recreate: - have a file with a comma in its name - enable the upload plugin on the 856$u in a framework - edit a record in that framework, upload your file in the 856$u - go to your record in the OPAC, click the link for the 856$u - get the error "This page isn't [catalog name] sent an invalid response. ERR_RESPONSE_HEADERS_MULTIPLE_CONTENT_DISPOSITION" This error is inconsistent. It might be simply that it works in Firefox but not in Chrome. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28123 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Working OK for me on master, tested with Firefox and Chromium (87). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28123 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #2 from David Cook <dcook@prosentient.com.au> --- Ah yes I know this problem from working on DSpace. I think that it's a Chrome-only bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28123 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- This is actually just a problem for PDF downloads. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28123 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28123 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- Created attachment 119494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119494&action=edit Bug 28123: Quote filename value in Content-Disposition header Chrome throws a ERR_RESPONSE_HEADERS_MULTIPLE_CONTENT_DISPOSITION error if a Content-Disposition header includes an unquoted filename that contains commas. This patch adds quotes around the filename in the Content-Disposition header, which fixes the problem. Test plan: 0. Do not apply the patch yet 1. Obtain a PDF and rename it to include a comma in its name 2. Enable the upload.pl plugin in the 856$u of the Default framework 3. Add/edit a record in the Default Framework and upload a file using the 856$u upload plugin. 4. Click on the resulting file URL in the saved file 5. Note the error ERR_RESPONSE_HEADERS_MULTIPLE_CONTENT_DISPOSITION is returned instead of the file 6. Apply the patch and restart your Plack instance 7. Click on the resulting file URL in the saved file 8. Note that you now get the PDF file instead of the error -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28123 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |dcook@prosentient.com.au |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28123 --- Comment #5 from David Cook <dcook@prosentient.com.au> --- Created attachment 119495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119495&action=edit Bug 28123: Fix expected value in unit test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28123 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28123 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119494|0 |1 is obsolete| | Attachment #119495|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 119610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119610&action=edit Bug 28123: Quote filename value in Content-Disposition header Chrome throws a ERR_RESPONSE_HEADERS_MULTIPLE_CONTENT_DISPOSITION error if a Content-Disposition header includes an unquoted filename that contains commas. This patch adds quotes around the filename in the Content-Disposition header, which fixes the problem. Test plan: 0. Do not apply the patch yet 1. Obtain a PDF and rename it to include a comma in its name 2. Enable the upload.pl plugin in the 856$u of the Default framework 3. Add/edit a record in the Default Framework and upload a file using the 856$u upload plugin. 4. Click on the resulting file URL in the saved file 5. Note the error ERR_RESPONSE_HEADERS_MULTIPLE_CONTENT_DISPOSITION is returned instead of the file 6. Apply the patch and restart your Plack instance 7. Click on the resulting file URL in the saved file 8. Note that you now get the PDF file instead of the error Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28123 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 119611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119611&action=edit Bug 28123: Fix expected value in unit test Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28123 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28123 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119610|0 |1 is obsolete| | --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 119684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119684&action=edit Bug 28123: Quote filename value in Content-Disposition header Chrome throws a ERR_RESPONSE_HEADERS_MULTIPLE_CONTENT_DISPOSITION error if a Content-Disposition header includes an unquoted filename that contains commas. This patch adds quotes around the filename in the Content-Disposition header, which fixes the problem. Test plan: 0. Do not apply the patch yet 1. Obtain a PDF and rename it to include a comma in its name 2. Enable the upload.pl plugin in the 856$u of the Default framework 3. Add/edit a record in the Default Framework and upload a file using the 856$u upload plugin. 4. Click on the resulting file URL in the saved file 5. Note the error ERR_RESPONSE_HEADERS_MULTIPLE_CONTENT_DISPOSITION is returned instead of the file 6. Apply the patch and restart your Plack instance 7. Click on the resulting file URL in the saved file 8. Note that you now get the PDF file instead of the error Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28123 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119611|0 |1 is obsolete| | --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 119685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119685&action=edit Bug 28123: Fix expected value in unit test Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28123 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28123 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28123 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28123 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|21.05.00 |21.05.00,20.11.05 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28123 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00,20.11.05 |21.05.00,20.11.05,20.05.11 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #12 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 20.05.x for 20.05.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28123 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |victor@tuxayo.net Status|Pushed to oldstable |RESOLVED --- Comment #13 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org