[Bug 35493] New: Housebound roles show as a collapsed field option when checked in CollapseFieldsPatronAddForm, even if housebound is off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35493 Bug ID: 35493 Summary: Housebound roles show as a collapsed field option when checked in CollapseFieldsPatronAddForm, even if housebound is off Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com To recreate: 1. HouseboundModule - disabled 2. CollapseFieldsPatronAddForm, add 'Housebound roles' 3. Edit/create a patron. 4. Notice the useless Housebound roles link at the top of the page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35493 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | Patch complexity|--- |Trivial patch Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35493 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35493 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 159600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159600&action=edit Bug 35493: Do not show housebound roles as collapsible unless the housebound module is on To test: 1. HouseboundModule - disabled 2. CollapseFieldsPatronAddForm, add 'Housebound roles' 3. Edit/create a patron. 4. Notice the useless Housebound roles link at the top of the page 5. APPLY PATCH 6. Try 1 - 3 again, this time no Housebound roles at the top ( Show collapsed fields ) 7. Turn on HouseboundModule and make sure it now shows -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35493 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35493 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159600|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 159608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159608&action=edit Bug 35493: Do not show housebound roles as collapsible unless the housebound module is on To test: 1. HouseboundModule - disabled 2. CollapseFieldsPatronAddForm, add 'Housebound roles' 3. Edit/create a patron. 4. Notice the useless Housebound roles link at the top of the page 5. APPLY PATCH 6. Try 1 - 3 again, this time no Housebound roles at the top ( Show collapsed fields ) 7. Turn on HouseboundModule and make sure it now shows Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35493 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- I've signed off, as it does what it says in the test plan. Should the rules be in the system preference? That is: if an option for CollapseFieldsPatronAddForm is "not valid", for example like housebound roles that requires HouseboundModule, then it is greyed out/not able to be selected? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35493 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159608|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 160009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160009&action=edit Bug 35493: Do not show housebound roles as collapsible unless the housebound module is on To test: 1. HouseboundModule - disabled 2. CollapseFieldsPatronAddForm, add 'Housebound roles' 3. Edit/create a patron. 4. Notice the useless Housebound roles link at the top of the page 5. APPLY PATCH 6. Try 1 - 3 again, this time no Housebound roles at the top ( Show collapsed fields ) 7. Turn on HouseboundModule and make sure it now shows Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35493 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Trivial patch working as designed. No regressions, QA scripts happy. Passing QA Whilst I agree with David, it would be nice if the sysprefs themselves were a bit more reactive to the value's of prefs they depend on, there's no real avenue to doing this as they currently stand. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35493 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35493 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35493 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|24.05.00 |24.05.00,23.11.02 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35493 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00,23.11.02 |24.05.00,23.11.02,23.05.08 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 23.05.x for upcoming 23.05.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35493 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35493 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org