SELECT * FROM smtp_servers; => SUCCESS: The password you chose is there

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27060 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 113846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113846&action=edit Bug 27060: Handle password changes more robustly This patch makes the changes in the password input trigger an event that marks the password as changed. This way we don't need to compare with the "****" string in the controller. A convenient link for restoring the original password is added with a proper description that marks the password as untouched, also restoring the "****" value. To test: 1. Apply this patch 2. Have an SMTP server set 3. Open for edition 4. In paralell, have a terminal with $ koha-mysql kohadev 5. Edit the password, save => SUCCESS: The password is there 6. Edit the password, choose to reset it to the one in the DB, save => SUCCESS: The password hasn't been changed! 7. Edit the password, put ****. save => SUCCESS: The password has been updated to **** 8. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

SELECT * FROM smtp_servers; => SUCCESS: The password you chose is there

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27060 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113846|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 113881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113881&action=edit Bug 27060: Handle password changes more robustly This patch makes the changes in the password input trigger an event that marks the password as changed. This way we don't need to compare with the "****" string in the controller. A convenient link for restoring the original password is added with a proper description that marks the password as untouched, also restoring the "****" value. To test: 1. Apply this patch 2. Have an SMTP server set 3. Open for edition 4. In paralell, have a terminal with $ koha-mysql kohadev 5. Edit the password, save => SUCCESS: The password is there 6. Edit the password, choose to reset it to the one in the DB, save => SUCCESS: The password hasn't been changed! 7. Edit the password, put ****. save => SUCCESS: The password has been updated to **** 8. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27060 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice little usability enhancement here.. signing off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27060 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, I think instead of "clear password changes" (which sounds like it will empty the field), "undo password changes" would be better, what do you think? But: it doesn't always appear to work right. What I think it should do: - Edit an existing SMTP server - Change the password - Clear the changes - Save - Password in the db remains unchanged I think this happens if you only add something to the password instead of completely replacing it. I also had multiple occasions where *** appeared in the password. To test: - Set password to password. - Update to password1 - hit clear icon, save. - password in db is now: ****1 I am not sure this works right. A suggestion: When you click into the password field, it could empty out so you have to type in the password in full. This would also mean, that the "Undo" link would have a visual effect, right now you can't really tell if it worked. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27060 alexaung <aungmo@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aungmo@gmail.com --- Comment #5 from alexaung <aungmo@gmail.com> --- I have checked and confirmed that the port for the other services is the same as Google (port 587). All these services are working on my local machine, and I can even send emails on the same server as Koha using swaks. Therefore, I believe the issue is not related to port blocking. -- You are receiving this mail because: You are watching all bug changes.