[Bug 18439] New: Resend button for notices being hidden by CSS and never unhidden
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18439 Bug ID: 18439 Summary: Resend button for notices being hidden by CSS and never unhidden Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org To recreate: Enable EnhancedMessagingPreferences Ensure you have some sent or failed notices View notices tab and don't see a 'resend' button Inspect the status column, note a hidden for containing the 'resend' button -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18439 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lari.taskula@jns.fi, | |nick@bywatersolutions.com Depends on| |12426 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 [Bug 12426] Allow resending of emails from the notices tab in the patron account -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18439 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18439 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 62226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62226&action=edit Bug 18439 - Resend button for notices being hidden by CSS and never unhidden Current jQuery is not unhiding resend button, this patch adds an id and a toggle command To test: 1 - Enable EnhancedMessagingPreferences 2 - Find a patron with sent or failed messages 3 - Note you can expand message, but not resend 4 - Apply patch 5 - Note that on expanding message a 'Resend' button appears 6 - Ensure resend button operates as expected -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18439 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62226|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 62227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62227&action=edit Bug 18439 - Resend button for notices being hidden by CSS and never unhidden Current jQuery is not unhiding resend button, this patch adds an id and a toggle command To test: 1 - Enable EnhancedMessagingPreferences 2 - Find a patron with sent or failed messages 3 - Note you can expand message, but not resend 4 - Apply patch 5 - Note that on expanding message a 'Resend' button appears 6 - Ensure resend button operates as expected Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18439 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18439 Lari Taskula <lari.taskula@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62227|0 |1 is obsolete| | --- Comment #3 from Lari Taskula <lari.taskula@jns.fi> --- Created attachment 62265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62265&action=edit Bug 18439 - Resend button for notices being hidden by CSS and never unhidden Current jQuery is not unhiding resend button, this patch adds an id and a toggle command To test: 1 - Enable EnhancedMessagingPreferences 2 - Find a patron with sent or failed messages 3 - Note you can expand message, but not resend 4 - Apply patch 5 - Note that on expanding message a 'Resend' button appears 6 - Ensure resend button operates as expected Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Lari Taskula <lari.taskula@jns.fi> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18439 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18439 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62265|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 62317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62317&action=edit Bug 18439 - Resend button for notices being hidden by CSS and never unhidden Current jQuery is not unhiding resend button, this patch adds an id and a toggle command To test: 1 - Enable EnhancedMessagingPreferences 2 - Find a patron with sent or failed messages 3 - Note you can expand message, but not resend 4 - Apply patch 5 - Note that on expanding message a 'Resend' button appears 6 - Ensure resend button operates as expected Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Lari Taskula <lari.taskula@jns.fi> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18439 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Depends on| |11274 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Caused by bug 11274. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11274 [Bug 11274] Sent Notices Tab Not Working Correctly -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18439 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18439 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Nick! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18439 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.07. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18439 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #8 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.12 release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18439 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #9 from Julian Maurice <julian.maurice@biblibre.com> --- Pushed to 3.22.x for 3.22.21 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18439 --- Comment #10 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Julian Maurice from comment #9)
Pushed to 3.22.x for 3.22.21
Wrong bug, sorry. This patch is not needed in 3.22.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18439 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|Oldversions |--- Blocks| |36810 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36810 [Bug 36810] Resend button for notices being hidden by CSS and never unhidden -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org