https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19390 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19390 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19390 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 77706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77706&action=edit Bug 19390: Make jQuery selector more specific, so OPAC view link can open in new tab The OPAC view link in the staff result list already had a target="_blank", but it didn't work, because of the JavaScript for the result list browser in staff. The JavaSript code was looking for the links to the detail page in staff and this also selected the link to the detail page in OPAC. By changing detail.pl to \detail.pl opac-detail.pl will no longer be selected. To test: - Search in the staff interface - Click "OPAC view" links in staff result lists - Click "OPAC view' links in detai page - Verify both now open in a new tab - Click other links and test that navigation (previous, next, return to results) works as expected - Inside the staff client, you should see something like searchid=scs_1533922927978 added to the URLs -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19390 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77706|0 |1 is obsolete| | --- Comment #2 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 77713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77713&action=edit Bug 19390: Make jQuery selector more specific, so OPAC view link can open in new tab The OPAC view link in the staff result list already had a target="_blank", but it didn't work, because of the JavaScript for the result list browser in staff. The JavaSript code was looking for the links to the detail page in staff and this also selected the link to the detail page in OPAC. By changing detail.pl to \detail.pl opac-detail.pl will no longer be selected. To test: - Search in the staff interface - Click "OPAC view" links in staff result lists - Click "OPAC view' links in detai page - Verify both now open in a new tab - Click other links and test that navigation (previous, next, return to results) works as expected - Inside the staff client, you should see something like searchid=scs_1533922927978 added to the URLs Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Followed the test plan and it works. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19390 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Works as expected, no regressions found. Passing QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19390 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19390 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.11.x for 17.11.10 -- You are receiving this mail because: You are watching all bug changes.