[Bug 8946] New: Wrong label and missing values in UNIMARC coded fields advanced search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8946 Priority: P5 - low Change sponsored?: --- Bug ID: 8946 Assignee: gmcharlt@gmail.com Summary: Wrong label and missing values in UNIMARC coded fields advanced search Severity: minor Classification: Unclassified OS: All Reporter: mathieu.saby@univ-rennes2.fr Hardware: All Status: ASSIGNED Version: unspecified Component: Searching Product: Koha Hi In the 2 subtypes_unimarc.inc template files for opac and staff interface, there are 2 little mistakes : - label "Feschrift Ind." for the index "Literature-Code" (fiction, short stories etc) => Should be "Literary genre" or something like that. - option value Frequency-code:i = Other => Should be Frequency-code:z = Other There is a also a few typos, and some missing values for some indexes : Material-type index (s, t), Literature-Code (i), ctype (v, w), Type-Of-Serial (e,f,g) M. Saby Rennes 2 University -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8946 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |mathieu.saby@univ-rennes2.f | |r -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8946 --- Comment #1 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Created attachment 12936 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12936&action=edit [PATCH] Bug 8946: corrections in inc files for UNIMARC coded fields advanced search In subtypes_unimarc.inc files for opac and staff interface, this patch : - fix 1 wrong code (Frequency-code:i = Other should be z) - fix the label "Feschrift Ind." => "Literary genre" - add some values for Material-type index (s, t), Literature-Code (i), ctype (v, w), Type-Of-Serial (e,f,g) - fix a few typos - change the order of some values (u values) To test, check if the new values are visible in the opac and staff interface. M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8946 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8946 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |rel_3_12 --- Comment #2 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- String changes. Will hold for post-3.10.0. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8946 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12936|0 |1 is obsolete| | --- Comment #3 from Mason James <mtj@kohaaloha.com> --- Created attachment 13415 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13415&action=edit Bug 8946: corrections in inc files for UNIMARC coded fields advanced search In subtypes_unimarc.inc files for opac and staff interface, this patch - fix 1 wrong code (Frequency-code:i = Other should be z) - fix the label "Feschrift Ind." to "Literary genre" - add some values for Material-type index (s, t), Literature-Code (i), ctype (v, w), Type-Of-Serial (e,f,g) - fix a few typos - change the order of some values (u values) To test, check if the new values are visible in the opac and staff interface. Signed-off-by: Mason James <mtj@kohaaloha.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8946 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mtj@kohaaloha.com --- Comment #4 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #3)
Created attachment 13415 [details] Bug 8946: corrections in inc files for UNIMARC coded fields advanced search
To test, check if the new values are visible in the opac and staff interface.
Signed-off-by: Mason James <mtj@kohaaloha.com>
verified new values are visible in opac and staff interface -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8946 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com Patch complexity|--- |Trivial patch --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: * despite it's size, this patch is really small * template only * passes koha-qa.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8946 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13415|0 |1 is obsolete| | --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 13782 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13782&action=edit Bug 8946: corrections in inc files for UNIMARC coded fields advanced search In subtypes_unimarc.inc files for opac and staff interface, this patch - fix 1 wrong code (Frequency-code:i = Other should be z) - fix the label "Feschrift Ind." to "Literary genre" - add some values for Material-type index (s, t), Literature-Code (i), ctype (v, w), Type-Of-Serial (e,f,g) - fix a few typos - change the order of some values (u values) To test, check if the new values are visible in the opac and staff interface. Signed-off-by: Mason James <mtj@kohaaloha.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8946 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |paul.poulain@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8946 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |jcamins@cpbibliography.com --- Comment #7 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8946 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz Version|3.12 |3.10 --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- Bugfix, mixed the string freeze for 3.10.0, pushed to 3.10.x will be in 3.10.1 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8946 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.10 |3.8 --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.8 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8946 --- Comment #10 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- There is a typo in my patch. I am making a followup. M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8946 --- Comment #11 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Created attachment 14620 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14620&action=edit letter v between 2 option tag In HTML code generated for advanced search, a useless "v" letter is visible between 2 <option> tag. This patch suppress "v" letter is outside <option> markup (and cosmetic change : lowercase "Adult" in public types) To test : check HTML code generated by advanced search. M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8946 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I imagine you'll need to submit that as a new bug with the new patch as the current patch has already been pushed.. It should get signed off and pushed very quickly though if it's a single character change. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8946 --- Comment #13 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Thank you. The RM confirmed : "Yes please. The way to set the status back to "Needs signoff" is to reset it to "ASSIGNED" first, then switch it to "Needs signoff," but one of my new policies is that follow-ups must be done on new bugs once a patch has been pushed to master. Regards, Jared" So I will make a new bug M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8946 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14620|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org