[Bug 31483] New: Minor UI problem in opac-reset-password.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31483 Bug ID: 31483 Summary: Minor UI problem in opac-reset-password.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org When EnableExpiredPasswordReset is enabled, patrons can access a page to reset their password. In this page, the grey box that normally contains the breadcrumbs encompasses the whole form. To test: 1) Enable EnableExpiredPasswordReset 2) Find a patron and change their password so you know what it is supposed to be 3) In the database, expire the patron's password, e.g. UPDATE borrowers SET password_expiration_date = '2022-08-22' where borrowernumber = 21; 4) Go to the OPAC, try to log in with the patron's credentials 5) Click Reset your password => Note that the form is in the grey breadcrumbs box, you can compare with any other OPAC page, the grey box should only contain the breadcrumbs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31483 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31382 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31382 [Bug 31382] Cannot reach password reset page when password expired -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31483 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 139970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139970&action=edit Bug 31483: Correct tiny HTML error on password reset page To test: 1) Enable EnableExpiredPasswordReset 2) Find a patron and change their password so you know what it is supposed to be 3) In the database, expire the patron's password, e.g. UPDATE borrowers SET password_expiration_date = '2022-08-22' where borrowernumber = 21; 4) Go to the OPAC, try to log in with the patron's credentials 5) Click Reset your password => Note that the form is in the grey breadcrumbs box, you can compare with any other OPAC page, the grey box should only contain the breadcrumbs 6) Apply patch 7) Try steps 4-5 again. The gray breadcrumbs box should be for breadcrumbs only! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31483 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |lucas@bywatersolutions.com Status|NEW |Needs Signoff Severity|enhancement |trivial CC| |lucas@bywatersolutions.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31483 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31483 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139970|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 139979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139979&action=edit Bug 31483: Correct tiny HTML error on password reset page To test: 1) Enable EnableExpiredPasswordReset 2) Find a patron and change their password so you know what it is supposed to be 3) In the database, expire the patron's password, e.g. UPDATE borrowers SET password_expiration_date = '2022-08-22' where borrowernumber = 21; 4) Go to the OPAC, try to log in with the patron's credentials 5) Click Reset your password => Note that the form is in the grey breadcrumbs box, you can compare with any other OPAC page, the grey box should only contain the breadcrumbs 6) Apply patch 7) Try steps 4-5 again. The gray breadcrumbs box should be for breadcrumbs only! Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31483 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |joonas.kylmala@iki.fi --- Comment #3 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Please close the ol tag explicitly with </ol>. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31483 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31483 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139979|0 |1 is obsolete| | --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 139993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139993&action=edit Bug 31483: Fix breadcrumbs on password reset page To test: 1) Enable EnableExpiredPasswordReset 2) Find a patron and change their password so you know what it is supposed to be 3) In the database, expire the patron's password, e.g. UPDATE borrowers SET password_expiration_date = '2022-08-22' where borrowernumber = 21; 4) Go to the OPAC, try to log in with the patron's credentials 5) Click Reset your password => Note that the form is in the grey breadcrumbs box, you can compare with any other OPAC page, the grey box should only contain the breadcrumbs 6) Apply patch 7) Try steps 4-5 again. The gray breadcrumbs box should be for breadcrumbs only! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31483 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- The patch was made on top of your own changes, thus doesn't apply. Can you resubmit the patch against master branch? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31483 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31483 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139993|0 |1 is obsolete| | --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 140019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140019&action=edit Bug 31483: Close <ol> tag properly on password reset page To test: 1) Enable EnableExpiredPasswordReset 2) Find a patron and change their password so you know what it is supposed to be 3) In the database, expire the patron's password, e.g. UPDATE borrowers SET password_expiration_date = '2022-08-22' where borrowernumber = 21; 4) Go to the OPAC, try to log in with the patron's credentials 5) Click Reset your password => Note that the form is in the grey breadcrumbs box, you can compare with any other OPAC page, the grey box should only contain the breadcrumbs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31483 --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Wow, you'd think I'd be able to properly close an HTML tag in less then 3 patches, alas. Thanks, Joonas. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31483 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31483 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140019|0 |1 is obsolete| | --- Comment #8 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 140043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140043&action=edit Bug 31483: Close <ol> tag properly on password reset page To test: 1) Enable EnableExpiredPasswordReset 2) Find a patron and change their password so you know what it is supposed to be 3) In the database, expire the patron's password, e.g. UPDATE borrowers SET password_expiration_date = '2022-08-22' where borrowernumber = 21; 4) Go to the OPAC, try to log in with the patron's credentials 5) Click Reset your password => Note that the form is in the grey breadcrumbs box, you can compare with any other OPAC page, the grey box should only contain the breadcrumbs Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31483 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |joonas.kylmala@iki.fi |y.org | Status|Signed Off |Passed QA --- Comment #9 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Trivial syntax error fix, straight to PQA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31483 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31483 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31483 Bug 31483 depends on bug 31382, which changed state. Bug 31382 Summary: Cannot reach password reset page when password expired https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31382 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31483 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.11.00 |22.11.00, 22.05.07 released in| | --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.07 release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31483 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki@biblibre.com Status|Pushed to stable |Pushed to oldstable --- Comment #12 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- depends on bz31382, can't backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31483 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org