[Bug 17539] New: t/db_dependent/Reserves.t is failing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17539 Bug ID: 17539 Summary: t/db_dependent/Reserves.t is failing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: lari.taskula@jns.fi QA Contact: gmcharlt@gmail.com 1..72 ok 1 - use C4::Reserves; ok 2 - CheckReserves Test 1 ok 3 - CheckReserves() include reserve_id in its response ok 4 - CheckReserves Test 2 ok 5 - CheckReserves Test 3 ok 6 - GetReservesControlBranch returns item home branch when set to ItemHomeLibrary ok 7 - GetReservesControlBranch returns patron home branch when set to PatronLibrary ok 8 - Item is correctly waiting ok 9 - Item is correctly priority 1 ok 10 - Item is correctly priority 2 ok 11 - GetWaiting got only the waiting reserve ok 12 - GetWaiting got the reserve for the correct borrower Undefined subroutine &C4::Circulation::GetItem called at /home/ubuntu/kohaclone/C4/Circulation.pm line 1852. # Looks like you planned 72 tests but ran 12. # Looks like your test exited with 255 just after 12. I went back in the version history until the test passed this point, and it seems issues began after commit bf1563e60b31244f4ea977eb84954fb8501ed59a from Bug 14610; this commit on top looks to be failing with error Undefined subroutine &C4::Circulation::GetItemnumberFromBarcode called at /home/ubuntu/kohaclone/C4/Circulation.pm line 1853. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17539 Lari Taskula <lari.taskula@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |lari.taskula@jns.fi -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17539 --- Comment #1 from Lari Taskula <lari.taskula@jns.fi> --- Created attachment 57094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57094&action=edit Bug 17539: Fix Undefined subroutine &C4::Circulation::GetItem error perl t/db_dependent/Reserves.t 1..72 ok 1 - use C4::Reserves; ok 2 - CheckReserves Test 1 ok 3 - CheckReserves() include reserve_id in its response ok 4 - CheckReserves Test 2 ok 5 - CheckReserves Test 3 ok 6 - GetReservesControlBranch returns item home branch when set to ItemHomeLibrary ok 7 - GetReservesControlBranch returns patron home branch when set to PatronLibrary ok 8 - Item is correctly waiting ok 9 - Item is correctly priority 1 ok 10 - Item is correctly priority 2 ok 11 - GetWaiting got only the waiting reserve ok 12 - GetWaiting got the reserve for the correct borrower Undefined subroutine &C4::Circulation::GetItem called at /home/ubuntu/kohaclone/C4/Circulation.pm line 1853. This patch fixes this error. The solution was to use C4::Reserves before C4::Items. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17539 --- Comment #2 from Lari Taskula <lari.taskula@jns.fi> --- Created attachment 57095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57095&action=edit Bug 17539: Fix Already in a transaction error perl t/db_dependent/Reserves.t 1..72 ok 1 - use C4::Reserves; ok 2 - CheckReserves Test 1 ... ok 52 - Reserve in waiting status cant be canceled ok 53 - Reserving an ageRestricted Biblio without a borrower dateofbirth succeeds DBD::mysql::db begin_work failed: Already in a transaction at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1489. DBD::mysql::db begin_work failed: Already in a transaction at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1489. at /usr/share/perl5/DBIx/Class/Schema.pm line 1080. ... Koha::Object::store('Koha::Patron=HASH(0x9e43b20)') called at /home/ubuntu/kohaclone/C4/Members.pm line 542 C4::Members::ModMember('borrowernumber', 658535, 'dateofbirth', '2001-11-02') called at t/db_dependent/Reserves.t line 516 This patch fixes this issue by replacing dbh autocommit=0 with txn_begin. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17539 Lari Taskula <lari.taskula@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17539 --- Comment #3 from Lari Taskula <lari.taskula@jns.fi> --- Created attachment 57096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57096&action=edit Bug 17539: Fix failing Reserves.t tests if category enrolmentfee > 0 To test: 1. Set patron category "S" with enrolmentfee 1 2. perl t/db_dependent/Reserves.t 3. Observe following errors: not ok 59 - Bug 14464 - No fines at beginning ok 60 - Bug 14464 - 1st reserve correctly created ok 61 - Bug 14968 - Keep found column from reserve not ok 62 - Bug 14464 - No fines after cancelling reserve with no charge configured ok 63 - Bug 14464 - 2nd reserve correctly created not ok 64 - Bug 14464 - No fines after cancelling reserve with no charge desired ok 65 - Bug 14464 - 1st reserve correctly created not ok 66 - Bug 14464 - Fine applied after cancelling reserve with charge desired and configured 4. Apply patch 5. perl t/db_dependent/Reserves.t 6. Observe test pass -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17539 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Depends on| |14610 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 [Bug 14610] Add ability to place article requests in Koha -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17539 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Lari, good catch. But still fail for me: Tag "" is not a valid tag. at t/db_dependent/Reserves.t line 510. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17539 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- There is already an use_ok in the Reserves test. If you add another use, maybe change use_ok to require_ok ? Did the same somewhere else.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17539 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #5)
There is already an use_ok in the Reserves test. If you add another use, maybe change use_ok to require_ok ? Did the same somewhere else..
Since we have tests for these modules, I am not sure the use_ok are really useful. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17539 Lari Taskula <lari.taskula@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57094|0 |1 is obsolete| | --- Comment #7 from Lari Taskula <lari.taskula@jns.fi> --- Created attachment 57127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57127&action=edit Bug 17539: Fix Undefined subroutine &C4::Circulation::GetItem error perl t/db_dependent/Reserves.t 1..72 ok 1 - use C4::Reserves; ok 2 - CheckReserves Test 1 ok 3 - CheckReserves() include reserve_id in its response ok 4 - CheckReserves Test 2 ok 5 - CheckReserves Test 3 ok 6 - GetReservesControlBranch returns item home branch when set to ItemHomeLibrary ok 7 - GetReservesControlBranch returns patron home branch when set to PatronLibrary ok 8 - Item is correctly waiting ok 9 - Item is correctly priority 1 ok 10 - Item is correctly priority 2 ok 11 - GetWaiting got only the waiting reserve ok 12 - GetWaiting got the reserve for the correct borrower Undefined subroutine &C4::Circulation::GetItem called at /home/ubuntu/kohaclone/C4/Circulation.pm line 1853. This patch fixes this error. The solution was to use C4::Reserves before C4::Items. Also due to this edit, change use_ok to require_ok -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17539 Lari Taskula <lari.taskula@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57095|0 |1 is obsolete| | --- Comment #8 from Lari Taskula <lari.taskula@jns.fi> --- Created attachment 57128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57128&action=edit Bug 17539: Fix Already in a transaction error perl t/db_dependent/Reserves.t 1..72 ok 1 - use C4::Reserves; ok 2 - CheckReserves Test 1 ... ok 52 - Reserve in waiting status cant be canceled ok 53 - Reserving an ageRestricted Biblio without a borrower dateofbirth succeeds DBD::mysql::db begin_work failed: Already in a transaction at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1489. DBD::mysql::db begin_work failed: Already in a transaction at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1489. at /usr/share/perl5/DBIx/Class/Schema.pm line 1080. ... Koha::Object::store('Koha::Patron=HASH(0x9e43b20)') called at /home/ubuntu/kohaclone/C4/Members.pm line 542 C4::Members::ModMember('borrowernumber', 658535, 'dateofbirth', '2001-11-02') called at t/db_dependent/Reserves.t line 516 This patch fixes this issue by replacing dbh autocommit=0 with txn_begin. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17539 Lari Taskula <lari.taskula@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57096|0 |1 is obsolete| | --- Comment #9 from Lari Taskula <lari.taskula@jns.fi> --- Created attachment 57129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57129&action=edit Bug 17539: Fix failing Reserves.t tests if category enrolmentfee > 0 To test: 1. Set patron category "S" with enrolmentfee 1 2. perl t/db_dependent/Reserves.t 3. Observe following errors: not ok 59 - Bug 14464 - No fines at beginning ok 60 - Bug 14464 - 1st reserve correctly created ok 61 - Bug 14968 - Keep found column from reserve not ok 62 - Bug 14464 - No fines after cancelling reserve with no charge configured ok 63 - Bug 14464 - 2nd reserve correctly created not ok 64 - Bug 14464 - No fines after cancelling reserve with no charge desired ok 65 - Bug 14464 - 1st reserve correctly created not ok 66 - Bug 14464 - Fine applied after cancelling reserve with charge desired and configured 4. Apply patch 5. perl t/db_dependent/Reserves.t 6. Observe test pass -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17539 --- Comment #10 from Lari Taskula <lari.taskula@jns.fi> --- (In reply to Jonathan Druart from comment #4)
Lari, good catch. But still fail for me: Tag "" is not a valid tag. at t/db_dependent/Reserves.t line 510. Strange! For me it seems to be working. Just a guess, could it be issue with caching as warned at lines 57-58, that set the kohafield for line 509: 57: # Somewhat arbitrary field chosen for age restriction unit tests. Must be added to db before the framework is cached 58: $dbh->do("update marc_subfield_structure set kohafield='biblioitems.agerestriction' where tagfield='521' and tagsubfield='a'"); ... 509: my ( $ageres_tagid, $ageres_subfieldid ) = GetMarcFromKohaField( "biblioitems.agerestriction" ); 510: $record->append_fields( MARC::Field->new($ageres_tagid, '', '', $ageres_subfieldid => 'PEGI 16') );
(In reply to Marcel de Rooy from comment #5)
There is already an use_ok in the Reserves test. If you add another use, maybe change use_ok to require_ok ? Did the same somewhere else.. I squashed this into the first patch. Thanks!
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17539 --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Lari Taskula from comment #10)
Strange! For me it seems to be working. Did not see that one too yesterday..
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17539 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57127|0 |1 is obsolete| | --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 57134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57134&action=edit Bug 17539: Fix Undefined subroutine &C4::Circulation::GetItem error perl t/db_dependent/Reserves.t 1..72 ok 1 - use C4::Reserves; ok 2 - CheckReserves Test 1 ok 3 - CheckReserves() include reserve_id in its response ok 4 - CheckReserves Test 2 ok 5 - CheckReserves Test 3 ok 6 - GetReservesControlBranch returns item home branch when set to ItemHomeLibrary ok 7 - GetReservesControlBranch returns patron home branch when set to PatronLibrary ok 8 - Item is correctly waiting ok 9 - Item is correctly priority 1 ok 10 - Item is correctly priority 2 ok 11 - GetWaiting got only the waiting reserve ok 12 - GetWaiting got the reserve for the correct borrower Undefined subroutine &C4::Circulation::GetItem called at /home/ubuntu/kohaclone/C4/Circulation.pm line 1853. This patch fixes this error. The solution was to use C4::Reserves before C4::Items. Also due to this edit, change use_ok to require_ok Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17539 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57128|0 |1 is obsolete| | --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 57135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57135&action=edit Bug 17539: Fix Already in a transaction error perl t/db_dependent/Reserves.t 1..72 ok 1 - use C4::Reserves; ok 2 - CheckReserves Test 1 ... ok 52 - Reserve in waiting status cant be canceled ok 53 - Reserving an ageRestricted Biblio without a borrower dateofbirth succeeds DBD::mysql::db begin_work failed: Already in a transaction at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1489. DBD::mysql::db begin_work failed: Already in a transaction at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1489. at /usr/share/perl5/DBIx/Class/Schema.pm line 1080. ... Koha::Object::store('Koha::Patron=HASH(0x9e43b20)') called at /home/ubuntu/kohaclone/C4/Members.pm line 542 C4::Members::ModMember('borrowernumber', 658535, 'dateofbirth', '2001-11-02') called at t/db_dependent/Reserves.t line 516 This patch fixes this issue by replacing dbh autocommit=0 with txn_begin. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17539 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57129|0 |1 is obsolete| | --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 57136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57136&action=edit Bug 17539: Fix failing Reserves.t tests if category enrolmentfee > 0 To test: 1. Set patron category "S" with enrolmentfee 1 2. perl t/db_dependent/Reserves.t 3. Observe following errors: not ok 59 - Bug 14464 - No fines at beginning ok 60 - Bug 14464 - 1st reserve correctly created ok 61 - Bug 14968 - Keep found column from reserve not ok 62 - Bug 14464 - No fines after cancelling reserve with no charge configured ok 63 - Bug 14464 - 2nd reserve correctly created not ok 64 - Bug 14464 - No fines after cancelling reserve with no charge desired ok 65 - Bug 14464 - 1st reserve correctly created not ok 66 - Bug 14464 - Fine applied after cancelling reserve with charge desired and configured 4. Apply patch 5. perl t/db_dependent/Reserves.t 6. Observe test pass Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17539 --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 57137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57137&action=edit Bug 17539: (QA followup) Silence warnings Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17539 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17539 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17539 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57134|0 |1 is obsolete| | --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 57151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57151&action=edit Bug 17539: Fix Undefined subroutine &C4::Circulation::GetItem error perl t/db_dependent/Reserves.t 1..72 ok 1 - use C4::Reserves; ok 2 - CheckReserves Test 1 ok 3 - CheckReserves() include reserve_id in its response ok 4 - CheckReserves Test 2 ok 5 - CheckReserves Test 3 ok 6 - GetReservesControlBranch returns item home branch when set to ItemHomeLibrary ok 7 - GetReservesControlBranch returns patron home branch when set to PatronLibrary ok 8 - Item is correctly waiting ok 9 - Item is correctly priority 1 ok 10 - Item is correctly priority 2 ok 11 - GetWaiting got only the waiting reserve ok 12 - GetWaiting got the reserve for the correct borrower Undefined subroutine &C4::Circulation::GetItem called at /home/ubuntu/kohaclone/C4/Circulation.pm line 1853. This patch fixes this error. The solution was to use C4::Reserves before C4::Items. Also due to this edit, change use_ok to require_ok Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17539 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57135|0 |1 is obsolete| | --- Comment #17 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 57152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57152&action=edit Bug 17539: Fix Already in a transaction error perl t/db_dependent/Reserves.t 1..72 ok 1 - use C4::Reserves; ok 2 - CheckReserves Test 1 ... ok 52 - Reserve in waiting status cant be canceled ok 53 - Reserving an ageRestricted Biblio without a borrower dateofbirth succeeds DBD::mysql::db begin_work failed: Already in a transaction at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1489. DBD::mysql::db begin_work failed: Already in a transaction at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1489. at /usr/share/perl5/DBIx/Class/Schema.pm line 1080. ... Koha::Object::store('Koha::Patron=HASH(0x9e43b20)') called at /home/ubuntu/kohaclone/C4/Members.pm line 542 C4::Members::ModMember('borrowernumber', 658535, 'dateofbirth', '2001-11-02') called at t/db_dependent/Reserves.t line 516 This patch fixes this issue by replacing dbh autocommit=0 with txn_begin. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17539 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57136|0 |1 is obsolete| | --- Comment #18 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 57153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57153&action=edit Bug 17539: Fix failing Reserves.t tests if category enrolmentfee > 0 To test: 1. Set patron category "S" with enrolmentfee 1 2. perl t/db_dependent/Reserves.t 3. Observe following errors: not ok 59 - Bug 14464 - No fines at beginning ok 60 - Bug 14464 - 1st reserve correctly created ok 61 - Bug 14968 - Keep found column from reserve not ok 62 - Bug 14464 - No fines after cancelling reserve with no charge configured ok 63 - Bug 14464 - 2nd reserve correctly created not ok 64 - Bug 14464 - No fines after cancelling reserve with no charge desired ok 65 - Bug 14464 - 1st reserve correctly created not ok 66 - Bug 14464 - Fine applied after cancelling reserve with charge desired and configured 4. Apply patch 5. perl t/db_dependent/Reserves.t 6. Observe test pass Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17539 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57137|0 |1 is obsolete| | --- Comment #19 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 57154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57154&action=edit Bug 17539: (QA followup) Silence warnings Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17539 --- Comment #20 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 57155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57155&action=edit Bug 17539: [QA Follow-up] Move handle after schema Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17539 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|gmcharlt@gmail.com |m.de.rooy@rijksmuseum.nl Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17539 --- Comment #21 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Ok so I tried it again: It pass with an usual install (using the interface), but it did not with the new populate_db.pl script. The bug is somewhere else, sorry! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17539 --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #21)
Ok so I tried it again: It pass with an usual install (using the interface), but it did not with the new populate_db.pl script. The bug is somewhere else, sorry!
Argh, actually I cannot recreate with populate_db.pl neither! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17539 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #23 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Lari, Tomas, Marcel! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17539 --- Comment #24 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I did a full prove t/db_dependent, and got: t/db_dependent/Reserves.t ................................ 28/72 C4::Context->userenv not defined! at /home/vagrant/kohaclone/C4/Items.pm line 2267. Use of uninitialized value $tagno in concatenation (.) or string at /usr/share/perl5/MARC/Field.pm line 83. Tag "" is not a valid tag. at t/db_dependent/Reserves.t line 526. # Looks like your test exited with 255 just after 52. t/db_dependent/Reserves.t ................................ Dubious, test returned 255 (wstat 65280, 0xff00) Just after, trying to recreate: prove t/db_dependent/Reserves.t t/db_dependent/Reserves.t .. 1/72 C4::Context->userenv not defined! at /home/vagrant/kohaclone/C4/Items.pm line 2267. t/db_dependent/Reserves.t .. ok All tests successful. Files=1, Tests=72, 3 wallclock secs ( 0.02 usr 0.01 sys + 1.42 cusr 0.78 csys = 2.23 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17539 --- Comment #25 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #24)
I did a full prove t/db_dependent, and got:
t/db_dependent/Reserves.t ................................ 28/72 C4::Context->userenv not defined! at /home/vagrant/kohaclone/C4/Items.pm line 2267. Use of uninitialized value $tagno in concatenation (.) or string at /usr/share/perl5/MARC/Field.pm line 83. Tag "" is not a valid tag. at t/db_dependent/Reserves.t line 526. # Looks like your test exited with 255 just after 52. t/db_dependent/Reserves.t ................................ Dubious, test returned 255 (wstat 65280, 0xff00)
Just after, trying to recreate: prove t/db_dependent/Reserves.t t/db_dependent/Reserves.t .. 1/72 C4::Context->userenv not defined! at /home/vagrant/kohaclone/C4/Items.pm line 2267. t/db_dependent/Reserves.t .. ok All tests successful. Files=1, Tests=72, 3 wallclock secs ( 0.02 usr 0.01 sys + 1.42 cusr 0.78 csys = 2.23 CPU) Result: PASS
What is the connection between these issues and the use of kohadevbox ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17539 --- Comment #26 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Jenkins doesn't use kohadevbox and shows the same behavior. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17539 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21133 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org