[Bug 19361] New: Linking an authorised value category to a field in a framework can lose data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361 Bug ID: 19361 Summary: Linking an authorised value category to a field in a framework can lose data Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: liz@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl If you link an authorised value to a framework after you have done data entry on the same field, editing the record with the new authorised value drop down, and not filling it in will lose the data in the field. To reproduce: choose a free entry MARC field and add a record with some data in that field. create an authorised value category and link it to that field in a framework edit your record with the authorised value link now defined, do not select an authorised value from the field, and save it note that the data for that field is now gone. I have only heard this reported on 16.05, but it very well may be in Master. It would pay to check. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361 --- Comment #1 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 67385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67385&action=edit Bug 19361 - Display the value of a MARC field in dropdown box after it is linked to an authorised value This patch displays the previously entered input of a MARC subfield (inputted before an authorised value was linked to the MARC field) in the new authorised value dropdown so that it can be resubmitted and not lost from the database. Test plan: 1. Create a record and write a value into the Edition 942$e MARC field and submit form 2. Create a new authorised value category and link it to the same Edition MARC subfield 3. Load the MARC record again and notice that the Edition field is now an empty dropdown box. Also for future reference in this test note the values in the 942$2 and 942$c dropdown boxes 4. Query the biblio_metadata table with the biblionumber of the record that you created in step 1 and notice that the value you entered in step 1 into the Edition (<subfield_code="e") still exists 5. Submit the form 6. Repeat step 4 and notice that <subfield_code="e" line no longer exists as the existing data for the edition MARC subfield has been lost by linking a new authorised value category to the edition subfield 7. Apply patch 8. Repeat steps 1 but this time write a value into the Classification part MARC subfield 9. Repeat step 2 but link the new authorised value category to the Classification part MARC subfield 10. Repeat step 3 and notice that the value you wrote into the Classification part subfield is displayed in the dropdown box (selected by default), along with a message in brackets informing you that this value is not an authorised value 11. Note that the other dropdown boxes 942$2 and 942$c both display the same values as in step 3 12. Submit the form 13. Query the biblio_metadata table and notice that the <subfield_code="h" line still exists with the value you entered and that was shown in the dropdown box As this is quite a complex test plan, I have done my best to keep it as simple as possible, however if you are confused please let me know and I am more than happy to clarify Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley@catalyst.net.nz Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361 Dominic Pichette <dominic.pichette@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dominic.pichette@inlibro.co | |m --- Comment #2 from Dominic Pichette <dominic.pichette@inlibro.com> --- Created attachment 67652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67652&action=edit screenshot of MARC during step 10 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361 Dominic Pichette <dominic.pichette@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Dominic Pichette <dominic.pichette@inlibro.com> --- I just attached a screen shot of the result I get at step 10. It doesn't seem to have changed since I can see what i first wrote in the field inside the dropdown. Also, (<subfield_code="e") line is absent from the database after submitting the form... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361 --- Comment #4 from Dominic Pichette <dominic.pichette@inlibro.com> --- meant to write "I can't see what I first wrote in the field..." -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361 --- Comment #5 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 67655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67655&action=edit Screenshot of success! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com Status|Failed QA |Signed Off --- Comment #6 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Hi Alex, I tested your patch both in 16.05 ans in the master. It didn't work in 16.05. I didn't see the old value as the default in the drop down menu. I think it has to do with the db structure that is different. In 16.05 there is no biblio_metadata. The MARC information is stored in the biblioitems table in the marc field. In the master, everything work as you described it. I attached a screenshot of the field with the value followed by the mention that it is not authorized. However, I would change the phrasing to "This is a previously entered..." instead of "previous". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67385|0 |1 is obsolete| | --- Comment #7 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 67657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67657&action=edit Bug 19361 - Display the value of a MARC field in dropdown box after it is linked to an authorised value This patch displays the previously entered input of a MARC subfield (inputted before an authorised value was linked to the MARC field) in the new authorised value dropdown so that it can be resubmitted and not lost from the database. Test plan: 1. Create a record and write a value into the Edition 942$e MARC field and submit form 2. Create a new authorised value category and link it to the same Edition MARC subfield 3. Load the MARC record again and notice that the Edition field is now an empty dropdown box. Also for future reference in this test note the values in the 942$2 and 942$c dropdown boxes 4. Query the biblio_metadata table with the biblionumber of the record that you created in step 1 and notice that the value you entered in step 1 into the Edition (<subfield_code="e") still exists 5. Submit the form 6. Repeat step 4 and notice that <subfield_code="e" line no longer exists as the existing data for the edition MARC subfield has been lost by linking a new authorised value category to the edition subfield 7. Apply patch 8. Repeat steps 1 but this time write a value into the Classification part MARC subfield 9. Repeat step 2 but link the new authorised value category to the Classification part MARC subfield 10. Repeat step 3 and notice that the value you wrote into the Classification part subfield is displayed in the dropdown box (selected by default), along with a message in brackets informing you that this value is not an authorised value 11. Note that the other dropdown boxes 942$2 and 942$c both display the same values as in step 3 12. Submit the form 13. Query the biblio_metadata table and notice that the <subfield_code="h" line still exists with the value you entered and that was shown in the dropdown box As this is quite a complex test plan, I have done my best to keep it as simple as possible, however if you are confused please let me know and I am more than happy to clarify Sponsored-By: Catalyst IT Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361 --- Comment #8 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Thanks Caroline I am attaching a amendment with the new wording now -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361 --- Comment #9 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 67658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67658&action=edit Bug 19361 - Followup altered wording of the default value Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Assignee|koha-bugs@lists.koha-commun |alexbuckley@catalyst.net.nz |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #10 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- It's ok now! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67658|0 |1 is obsolete| | --- Comment #11 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 67955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67955&action=edit Bug 19361 - Followup altered wording of the default value Sponsored-By: Catalyst IT Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA: Looking here now -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: The problem described in the first comment does not really seem a problem to me. This is just what authorized values mean. The value is controlled now; and you should not be able to save another value. Note that if you change it here, why not change it in the items form or even other places? I think this exception needs more discussion/consensus. Maybe raise it on the dev list or a dev meeting. And what do librarians want here? Furthermore I would not hardcode the [% ELSIF mv.default != 'ddc' %] exception. Same thing is true when you delete a value from the auth values while still having the value in your data. Should Koha warn you for that or not allow it ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Version|16.05 |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #14 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Looking over this bug report again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #15 from David Cook <dcook@prosentient.com.au> --- (In reply to Marcel de Rooy from comment #13)
QA Comment: The problem described in the first comment does not really seem a problem to me. This is just what authorized values mean. The value is controlled now; and you should not be able to save another value. Note that if you change it here, why not change it in the items form or even other places? I think this exception needs more discussion/consensus. Maybe raise it on the dev list or a dev meeting.
Hmm, I figure if it's a controlled field, you shouldn't be able to save a non-controlled value, but I think the behaviour right now might be to silently delete the existing data. Flagging that the current data isn't authorized and that they must use an authorized value is probably the optimal path forward? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361 --- Comment #16 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Many thanks David for your thoughts, much appreciated! I think you're idea of flagging that the current data is not authorised and prompt to choose another authorised value is an excellent compromise so at least the library staff member is made aware and the data is not just silently lost. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361 --- Comment #17 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Any other/opposing thoughts anyone else? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Flagging sounds like a good idea and it should not let you save until you have resolved the issues. Sometimes it would be nice if we could allow a mix of authorised values and free text entry, like we allow for the suggestion reason in the staff interface. You can either choose from a list or do a free text entry picking "other reason". But that would definitely be a new feature and separate bug. And not sure if "Select2" supports that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicolas.legrand@bulac.fr --- Comment #19 from Nicolas Legrand <nicolas.legrand@bulac.fr> --- (In reply to Alex Buckley from comment #17)
Any other/opposing thoughts anyone else?
A gut yor Alex, I've asked people at Bulac library, though we don't catalogue with Koha, this answer is more about modifying items. My colleagues feel it's safer to keep the old value by default and let the librarian decide what to do. So your work is seen as a better behaviour! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361 --- Comment #20 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Thanks very much for sharing your thoughts Katrin and Nicolas, much appreciated! It sounds like the consensus is flagging that the data will be lost is the way to go. But that a nice future enhancement would be to allow librarians to choose to allow free text values in a linked field. I'll work on adding flagging alert to this patchset. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361 --- Comment #21 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 105848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105848&action=edit [ALTERNATIVE-PATCH] Bug 19361: Add a tooltip warning if value not in AV list (This patch depends on bug 25728) When cataloguing it may happen that a previous value of a subfield is not longer in the list of AVs. Prior to this patch the value was removed. This patch suggests to display a tooltip next to the problematic subfield. If nothing is done, the value is kept. This patch work when cataloguing a bibliographic record, and adding/editing items. It could be implemented easily for authority cataloguing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #21)
Created attachment 105848 [details] [review] [ALTERNATIVE-PATCH] Bug 19361: Add a tooltip warning if value not in AV list
(This patch depends on bug 25728)
When cataloguing it may happen that a previous value of a subfield is not longer in the list of AVs.
Prior to this patch the value was removed.
This patch suggests to display a tooltip next to the problematic subfield. If nothing is done, the value is kept.
This patch work when cataloguing a bibliographic record, and adding/editing items.
It could be implemented easily for authority cataloguing.
This is my try: https://snipboard.io/Eso74Y.jpg -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67657|0 |1 is obsolete| | Attachment #67955|0 |1 is obsolete| | Attachment #105848|0 |1 is obsolete| | --- Comment #23 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 142158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142158&action=edit Bug 19361: Display unauthorized values when cataloging and add a warning This patch adds a warning and tool tip when an unauthorised vlaue is encountered during item or biblio editing, and adds the value to the list to allow preserving the value (in case the librarian is only editing another part of the record, or there is some reason to retain) To test: 1 - Edit a record in advanced cataloging editor 2 - Under settings click 'Show fields verbatim' 3 - Edit 942$c to 'HAM' or some other invalid itemtype 4 - Save record 5 - sudo koha-mysql kohadev UPDATE items SET location = 'HAM' WHERE biblionumber = {biblionumber from above} 6 - Edit the biblio and items, confirm the HAM value shows in dropdowns -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361 --- Comment #24 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 142159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142159&action=edit Bug 19361: Fix advanced cataloging editor dropdowns -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #25 from Nick Clemens <nick@bywatersolutions.com> --- Trying to revive this - feel free to take back if you want Alex -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142158|0 |1 is obsolete| | --- Comment #26 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Created attachment 142208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142208&action=edit Bug 19361: Display unauthorized values when cataloging and add a warning This patch adds a warning and tool tip when an unauthorised vlaue is encountered during item or biblio editing, and adds the value to the list to allow preserving the value (in case the librarian is only editing another part of the record, or there is some reason to retain) To test: 1 - Edit a record in advanced cataloging editor 2 - Under settings click 'Show fields verbatim' 3 - Edit 942$c to 'HAM' or some other invalid itemtype 4 - Save record 5 - sudo koha-mysql kohadev UPDATE items SET location = 'HAM' WHERE biblionumber = {biblionumber from above} 6 - Edit the biblio and items, confirm the HAM value shows in dropdowns Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142159|0 |1 is obsolete| | --- Comment #27 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Created attachment 142209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142209&action=edit Bug 19361: Fix advanced cataloging editor dropdowns Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31422 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber@kit.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Assignee|alexbuckley@catalyst.net.nz |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #28 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- FAIL koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc OK filters FAIL forbidden patterns forbidden pattern: simple-quote string (line 125) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|m.de.rooy@rijksmuseum.nl |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Having a look here - I'll fix the QA script in a follow-up patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142208|0 |1 is obsolete| | Attachment #142209|0 |1 is obsolete| | --- Comment #30 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 148377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148377&action=edit Bug 19361: Display unauthorized values when cataloging and add a warning This patch adds a warning and tool tip when an unauthorised vlaue is encountered during item or biblio editing, and adds the value to the list to allow preserving the value (in case the librarian is only editing another part of the record, or there is some reason to retain) To test: 1 - Edit a record in advanced cataloging editor 2 - Under settings click 'Show fields verbatim' 3 - Edit 942$c to 'HAM' or some other invalid itemtype 4 - Save record 5 - sudo koha-mysql kohadev UPDATE items SET location = 'HAM' WHERE biblionumber = {biblionumber from above} 6 - Edit the biblio and items, confirm the HAM value shows in dropdowns Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361 --- Comment #31 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 148378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148378&action=edit Bug 19361: Fix advanced cataloging editor dropdowns Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361 --- Comment #32 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 148379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148379&action=edit Bug 19361: (QA follow-up) Make sure translatable string is wrapped in double quotes This fixes the QA script complaint: FAIL koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc FAIL forbidden patterns forbidden pattern: simple-quote string (line 125) Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361 --- Comment #33 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 148380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148380&action=edit Bug 19361: (QA follow-up) Make sure "Not an authorised value" appears in the pull down This is to make sure that the small icon with the additional tooltip style explanation is not as easily missed. Also updates text slightly: * Pull downs: "X (Not an authorised value)" * Tooltip: "The current value X is not configured for the authorised value category controlling this subfield" Switches from exclamation triangle to the more "alerting" exclamation-triangle :) Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361 --- Comment #34 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361 --- Comment #35 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32748 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32748 [Bug 32748] Library limitations will cause data loss when editing items -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org