[Bug 17344] New: Can't set guarantor in quick add brief form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17344 Bug ID: 17344 Summary: Can't set guarantor in quick add brief form Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When using the quick add feature it's not possible to add a guarantor. To test: - Use quick add form to add a "Kid" (sample patron category) - "Set patron" and search for a patron to link with - Click "choose" - Verify that the guarantor fields in the form remain empty - Open 'full form' - notice some information is there -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17344 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |3534 Severity|normal |major CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |nick@bywatersolutions.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 [Bug 3534] Patron quick add form -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17344 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think we should try and fix this fast, as quick add is a prominent feature in the new release. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17344 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Working on this, but I have a question: Guarantor form also adds some address info - Would it be enough to add note to quick add form that this info will be added/saved and to see full form to edit - or should we make these fields (streetnumber, address,address2, city,state,zipcode,country,branchcode) displayed by default on a form with guarantor selector? (In reply to Katrin Fischer from comment #1)
I think we should try and fix this fast, as quick add is a prominent feature in the new release.
-- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17344 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- What about if we simply remove the support of guarantor for the quick add form? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17344 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, I wouldn't display by default, a note would work for me. I am not sure how hard it is to do, but we put some time and effort in to make it work for guarantors, so not sure we should remove it right away. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17344 --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 57674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57674&action=edit Bug 17344 - Can't set guarantor in quick add brief form This patch updates the guarantor form to work with the quick add form To test: 1 - Quick add a 'Kid' patron (or other patron type that may have guarantor) 2 - Verify form appears as expected 3 - Test that you can add a patron manually or using selector 4 - Test that deletion works as expected 5 - Test 3 and 4 from the full version of the form 6 - Save or cancel and add a new patron using the full form only 7 - Verify that adding/deleting guarantor works with no errors 8 - Sign off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17344 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17344 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17344 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57674|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 57678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57678&action=edit [SIGNED-OFF] Bug 17344 - Can't set guarantor in quick add brief form This patch updates the guarantor form to work with the quick add form To test: 1 - Quick add a 'Kid' patron (or other patron type that may have guarantor) 2 - Verify form appears as expected 3 - Test that you can add a patron manually or using selector 4 - Test that deletion works as expected 5 - Test 3 and 4 from the full version of the form 6 - Save or cancel and add a new patron using the full form only 7 - Verify that adding/deleting guarantor works with no errors 8 - Sign off Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17344 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Nick, At several places you are using a "quick_add_form" selector, this does not look right. As you are using the id (#) you should not need to specify anything else. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17344 --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- It is a consequence of cloning the fields, there are doubled ids. I am open to suggestions but this was the easy/fast way to repair this part of the feature. (In reply to Jonathan Druart from comment #7)
Nick, At several places you are using a "quick_add_form" selector, this does not look right. As you are using the id (#) you should not need to specify anything else.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17344 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17344 --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 57705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57705&action=edit Bug 17344 - Followup to fix selectors Add '#' selector to several tags Fix some spacing Remove duplicated line To highlight that all is working set PatronQuickAddFields as below for testing: streetnumber|address|address2|city|state|zipcode|country|branchcode -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17344 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I don't think we need "#quick_add_form #streetnumber" as a selector, "#streetnumber" should be enough. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17344 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17344 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57678|0 |1 is obsolete| | Attachment #57705|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57708&action=edit Bug 17344 - Can't set guarantor in quick add brief form This patch updates the guarantor form to work with the quick add form To test: 1 - Quick add a 'Kid' patron (or other patron type that may have guarantor) 2 - Verify form appears as expected 3 - Test that you can add a patron manually or using selector 4 - Test that deletion works as expected 5 - Test 3 and 4 from the full version of the form 6 - Save or cancel and add a new patron using the full form only 7 - Verify that adding/deleting guarantor works with no errors 8 - Sign off Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17344 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57709&action=edit Bug 17344 - Followup to fix selectors Add '#' selector to several tags Fix some spacing Remove duplicated line To highlight that all is working set PatronQuickAddFields as below for testing: streetnumber|address|address2|city|state|zipcode|country|branchcode Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17344 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Note that some things should be rewritten here. We should not have 2 elements with the same id at the same time in the DOM, this is semantically wrong. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17344 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #13)
Note that some things should be rewritten here. We should not have 2 elements with the same id at the same time in the DOM, this is semantically wrong.
It also makes jQuery grumpy - you can't select using the id then in my experience. We have some other places in acq where this happens or happened. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17344 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05! Thanks Nick! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17344 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x, will be in 16.11.01! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17344 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19249 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org