[Bug 16208] New: Can't delete a library EAN if the EAN value is empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16208 Bug ID: 16208 Summary: Can't delete a library EAN if the EAN value is empty Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/admin/edi_ean_accounts.pl OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Blocks: 7736 In testing the new EDI pages I tried adding a "Library EAN" with no fields filled out (other than the pre-filled options). The record saved successfully with empty values for EAN and description. When I went to test deletion of one of these records I got an error: Can't call method "delete" on an undefined value at /admin/edi_ean_accounts.pl line 112. I notice the link to delete passes the ean value (which is empty in my test): /admin/edi_ean_accounts.pl?op=delete_confirm&branchcode=APL&ean= I assume this is the reason for the error. If the edifact_ean table has a primary key (ee_id), why not use that for deletion? Should the EAN field be required? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 [Bug 7736] Edifact QUOTE and ORDER functionality -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16208 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|7736 | Depends on| |7736 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 [Bug 7736] Edifact QUOTE and ORDER functionality -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16208 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16208 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 50355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50355&action=edit Bug 16208 - Can't delete a library EAN if the EAN value is empty Test Plan: 1) Create an empty EAN 2) Attempt to delete it, you should get an error 3) Apply this patch 4) Attempt to delete the EAN, you should now be able to -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16208 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50355|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 50356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50356&action=edit Bug 16208 - Can't delete a library EAN if the EAN value is empty Test Plan: 1) Create an empty EAN 2) Attempt to delete it, you should get an error 3) Apply this patch 4) Attempt to delete the EAN, you should now be able to -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16208 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16208 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16256 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16256 [Bug 16256] Can't edit library EAN if you leave EAN empty -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16208 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Bug 16206, "Corrections to templates related new EDI feature" is Passed QA. Could this patch be rebased on top of that? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16208 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16206 CC| |chris@bigballofwax.co.nz Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16206 [Bug 16206] Corrections to templates related new EDI feature -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16208 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16208 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50356|0 |1 is obsolete| | --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 50367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50367&action=edit Bug 16208 - Can't delete a library EAN if the EAN value is empty Test Plan: 1) Create an empty EAN 2) Attempt to delete it, you should get an error 3) Apply this patch 4) Attempt to delete the EAN, you should now be able to Signed-off-by: Chris Cormack <chrisc@catalyst.net.z> This depends on bug 16206 being pushed, or you need to apply that patch first -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16208 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16208 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50367|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 50380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50380&action=edit [PASSED QA] Bug 16208 - Can't delete a library EAN if the EAN value is empty Test Plan: 1) Create an empty EAN 2) Attempt to delete it, you should get an error 3) Apply this patch 4) Attempt to delete the EAN, you should now be able to Signed-off-by: Chris Cormack <chrisc@catalyst.net.z> This depends on bug 16206 being pushed, or you need to apply that patch first Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> https://bugs.koha-community.org/show_bug.cgi?id=16256 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16208 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sorry... but I just noticed: it didn't delete! When confirming yes, nothing happens.
From the logs: [Tue Apr 19 07:49:37.687937 2016] [cgi:error] [pid 17497] [client 127.0.0.1:37847] AH01215: [Tue Apr 19 07:49:37 2016] edi_ean_accounts.pl: DBIx::Class::ResultSet::_build_unique_cond(): NULL/undef values supplied for requested unique constraint 'primary' (NULL values in column(s): 'ee_id'). This is almost certainly not what you wanted, though you can set DBIC_NULLABLE_KEY_NOWARN to disable this warning. at /home/katrin/kohaclone/admin/edi_ean_accounts.pl line 140, referer: http://localhost:8080/cgi-bin/koha/admin/edi_ean_accounts.pl
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16208 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Looking at the form for confirming deletion shows the hidden value for ean to be still empty: <input type="hidden" name="ean" value="" /> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16208 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16208 --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 50394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50394&action=edit Bug 16208 [QA Followup] - Fix incorrect form parameter names -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16208 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16208 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50380|0 |1 is obsolete| | Attachment #50394|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 50445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50445&action=edit [PASSED QA] Bug 16208 - Can't delete a library EAN if the EAN value is empty Test Plan: 1) Create an empty EAN 2) Attempt to delete it, you should get an error 3) Apply this patch 4) Attempt to delete the EAN, you should now be able to Signed-off-by: Chris Cormack <chrisc@catalyst.net.z> This depends on bug 16206 being pushed, or you need to apply that patch first Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> https://bugs.koha-community.org/show_bug.cgi?id=16256 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16208 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 50446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50446&action=edit [PASSED QA] Bug 16208 [QA Followup] - Fix incorrect form parameter names Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16208 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #11 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16208 Bug 16208 depends on bug 16206, which changed state. Bug 16206 Summary: Corrections to templates related new EDI feature https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16206 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16208 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |julian.maurice@biblibre.com --- Comment #12 from Julian Maurice <julian.maurice@biblibre.com> --- Not needed in stable versions, status changed to RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org