https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23248 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|oleonard@myacpl.org |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23248 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91156|0 |1 is obsolete| | --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 91157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91157&action=edit Bug 23248: Avoid opac-ISBDdetail.pl breaking on invalid biblionumber This patch makes opac-ISBDdetail.pl redirect to a 404 page (as it should) in the event of a bad biblionumber passed. To test: - Open your browser on a known record detail page (OPAC) - Switch to the ISBD view => SUCCESS: It shows - Alter the biblionumber on the URL into an obviously non-existent biblionumber (e.g. very high value) => FAIL: Internal errors are shown - Apply this patch - Reload the bad biblionumber ISBD view => SUCCESS: Browser is redirected to the 404 page as it should - Sign off :-=> FAIL: Internal errors are shown - Apply this patch - Reload the bad biblionumber ISBD view => SUCCESS: Browser is redirected to the 404 page as it should - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23248 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com, mtompset@hotmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23248 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91157|0 |1 is obsolete| | --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 91293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91293&action=edit Bug 23248: Avoid opac-ISBDdetail.pl breaking on invalid biblionumber This patch makes opac-ISBDdetail.pl redirect to a 404 page (as it should) in the event of a bad biblionumber passed. To test: - Open your browser on a known record detail page (OPAC) - Switch to the ISBD view => SUCCESS: It shows - Alter the biblionumber on the URL into an obviously non-existent biblionumber (e.g. very high value) => FAIL: Internal errors are shown - Apply this patch - Reload the bad biblionumber ISBD view => SUCCESS: Browser is redirected to the 404 page as it should - Sign off :-=> FAIL: Internal errors are shown - Apply this patch - Reload the bad biblionumber ISBD view => SUCCESS: Browser is redirected to the 404 page as it should - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23248 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91293|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 91311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91311&action=edit Bug 23248: Avoid opac-ISBDdetail.pl breaking on invalid biblionumber This patch makes opac-ISBDdetail.pl redirect to a 404 page (as it should) in the event of a bad biblionumber passed. To test: - Open your browser on a known record detail page (OPAC) - Switch to the ISBD view => SUCCESS: It shows - Alter the biblionumber on the URL into an obviously non-existent biblionumber (e.g. very high value) => FAIL: Internal errors are shown - Apply this patch - Reload the bad biblionumber ISBD view => SUCCESS: Browser is redirected to the 404 page as it should - Sign off :-=> FAIL: Internal errors are shown - Apply this patch - Reload the bad biblionumber ISBD view => SUCCESS: Browser is redirected to the 404 page as it should - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23248 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23248 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23248 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- missing dependencies, wont backport to 18.11.x -- You are receiving this mail because: You are watching all bug changes.