[Bug 8576] New: Software error on authority edition when using merge
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8576 Priority: P5 - low Change sponsored?: --- Bug ID: 8576 CC: m.de.rooy@rijksmuseum.nl Assignee: gmcharlt@gmail.com Summary: Software error on authority edition when using merge Severity: critical Classification: Unclassified OS: All Reporter: fridolyn.somers@biblibre.com Hardware: All Status: NEW Version: master Component: Cataloging Product: Koha When using the update of biblios on authorities edition (managed by 'dontmerge' syspref), and when biblionumber is on a control field (< 10) : When editing or creating an authority, you get a software error : "Software error: Control fields (generally, just tags below 010) do not have subfields, use data() at /usr/share/perl5/MARC/Record.pm line 239 For help, ..." This comes from the fact that, to find biblionumber in a record, one must check if biblio.biblionumber is mapped on a control field to call "$record->field($tagfield)->data" instead if "$record->subfield($tagfield,$tagsubfield)". It was also missing in batchImportMARCWithBiblionumbers.pl. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8576 --- Comment #1 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- To reproduce the bug, use a used authority, in order to perform the merge. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8576 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt@gmail.com |fridolyn.somers@biblibre.co | |m --- Comment #2 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 11387 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11387&action=edit Proposed patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8576 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P2 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8576 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11387|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 11404 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11404&action=edit Bug 8576: Software error on authority edition when using merge Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8576 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8576 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj@kohaaloha.com --- Comment #4 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #3)
Created attachment 11404 [details] Bug 8576: Software error on authority edition when using merge
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
looks good, passing QA on this mason@xen1:~/git/head$ koha-qa.pl - 7a6718d Bug 8576: Software error on authority edition when using merge C4/AuthoritiesMarc.pm misc/batchImportMARCWithBiblionumbers.pl - perlcritic-progressive tests... OK - perl -c syntax tests... OK - xt/tt_valid.t tests... OK - xt/author/vaild-template.t tests... OK -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8576 --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x will be in 3.8.4 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8576 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable CC| |paul.poulain@biblibre.com --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed on master today, already pushed on stable, changing status to "pushed to stable" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8576 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |rel_3_8 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org