https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31846 --- Comment #1 from David Gustafsson <glasklas@gmail.com> --- Created attachment 141998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141998&action=edit Bug 31846: Add syspref for serials search results limit To test: 1) Make sure SerialsSearchResultsLimit syspref is unset or set to 0. 2) Perform an advanced search on serials without any conditions and confirm all serials are listed as expected. 3) Set SerialsSearchResultsLimit to a value less the the number of total subscriptions, perform the search again, and confirm that the number of serials has been limited to the set value. 4) Ensure all tests pass in t/db_dependent/Serials.t Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31846 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141998|0 |1 is obsolete| | --- Comment #2 from David Gustafsson <glasklas@gmail.com> --- Created attachment 141999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141999&action=edit Bug 31846: Add syspref for serials search results limit To test: 1) Make sure SerialsSearchResultsLimit syspref is unset or set to 0. 2) Perform an advanced search on serials without any conditions and confirm all serials are listed as expected. 3) Set SerialsSearchResultsLimit to a value less the the number of total subscriptions, perform the search again, and confirm that the number of serials has been limited to the set value. 4) Ensure all tests pass in t/db_dependent/Serials.t Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31846 --- Comment #4 from David Gustafsson <glasklas@gmail.com> --- (In reply to Katrin Fischer from comment #3)

That is something we don't do in Koha so far afaik. I wonder if moving the search to the API as it was done for the order receive page and the patron search would not be a better way forward here to fix this issue?

Yes, but that would require a lot more work, especially since SearchSubscriptions relies on custom queries and in practice does use the Koha::Subscriptions DBIx interface. If someone would like to refactor the search page that would perhaps be preferable, but this is quite a simple fix and think could still be useful until someone puts in the effort. The current fix works for our current needs, without it a staff interface user could presently accidentally put such a high load on the server to cause a temporary system outage. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31846 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Assignee|koha-bugs@lists.koha-commun |glasklas@gmail.com |ity.org | --- Comment #6 from David Nind <david@davidnind.com> --- I've added David Gustafsson as the assignee. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31846 --- Comment #8 from David Nind <david@davidnind.com> --- Hi Kelly. Since you've signed it off, you should change the status in Bugzilla to 'Signed Off'. That way you will get the credit in the dashboard! David -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31846 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31846 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154563|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 157102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157102&action=edit Bug 31846: Add syspref for serials search results limit To test: 1) Make sure SerialsSearchResultsLimit syspref is unset or set to 0. 2) Perform an advanced search on serials without any conditions and confirm all serials are listed as expected. 3) Set SerialsSearchResultsLimit to a value less the the number of total subscriptions, perform the search again, and confirm that the number of serials has been limited to the set value. 4) Ensure all tests pass in t/db_dependent/Serials.t Sponsored-by: Gothenburg University Library Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31846 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to David Gustafsson from comment #4)

(In reply to Katrin Fischer from comment #3)

...

That is something we don't do in Koha so far afaik. I wonder if moving the search to the API as it was done for the order receive page and the patron search would not be a better way forward here to fix this issue?

Yes, but that would require a lot more work, especially since SearchSubscriptions relies on custom queries and in practice does use the Koha::Subscriptions DBIx interface. If someone would like to refactor the search page that would perhaps be preferable, but this is quite a simple fix and think could still be useful until someone puts in the effort. The current fix works for our current needs, without it a staff interface user could presently accidentally put such a high load on the server to cause a temporary system outage.

There was some controversy here if we should implement it or not - Kyle, could you give your opinion? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31846 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31846 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31846 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com Status|Needs documenting |RESOLVED Documentation| |Caroline Cyr La Rose contact| | Resolution|--- |FIXED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/793 -- You are receiving this mail because: You are watching all bug changes.