[Bug 34375] New: Shipping fund in an invoice defaults to the first fund from the list rather than 'no fund' after receiving.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34375 Bug ID: 34375 Summary: Shipping fund in an invoice defaults to the first fund from the list rather than 'no fund' after receiving. Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: lucy.vaux-harvey@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org To recreate: Go to a vendor record in Acquisitions and then Receive Shipment Enter an invoice number Leave the Shipping cost empty and Shipping Fund as 'No fund' Receive some orders or go straight to Finish receiving Notice the Shipping fund has defaulted to the first fund in the alphabetical list of funds. It is not possible to select 'No fund' and the selected fund is recorded in shipmentcost_budgetid incorrectly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34375 Stephen Graham <s.graham4@herts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |s.graham4@herts.ac.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34375 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com, | |matt.blenkinsop@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34375 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #1 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Caused by a local customer customisation, no need for a bug report :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34375 --- Comment #2 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Ignore previous comment, there was an issue in 22.11.06 - now fixed as of 22.11.07 onwards -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34375 Ray Delahunty <r.delahunty@arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |r.delahunty@arts.ac.uk Resolution|INVALID |--- Status|RESOLVED |REOPENED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34375 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Ray, are you already on version 22.11.07 as Matt mentioned and the bug is still present? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34375 --- Comment #4 from Ray Delahunty <r.delahunty@arts.ac.uk> --- Created attachment 158266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158266&action=edit Screen grabs -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34375 --- Comment #5 from Ray Delahunty <r.delahunty@arts.ac.uk> --- We moved from 21.11 to 22.11.07 in July. We have taken 2 monthly patches and are now on 22.11.09 but we have stopped taking monthly patches as we have had some local fixes undone by the patches. The problem is visible in 22.11.09 but either the fix wasn’t right in 22.11.07 or one of the patches may have broken it. Yes, ‘No fund’ appears at the top of the pulldown when the invoice is created and no items have been received but once the receiving is finished, the ‘No fund’ is replaced with the alphabetically highest fund (ASCC, in our case). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34375 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Status|REOPENED |NEW --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I can this is still a bug in 22.11.10. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34375 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Hi Ray, I put a fix onto your test server in ticket 48643 to see if this resolved the issue - for some reason the ticket was set to "Paused" so I'm not sure if that response ever got through to your end. Could you or Steven have a play on the test server and see if the patch gives you the expected behaviour? If it does then I'll upload it here and we can get it pushed through. Thanks! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34375 --- Comment #8 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Apologies, I have just realised that ticket 48643 was a different customer raising the same issue! I've added the same fix into your test server Ray - let me know if it fixes the issue :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34375 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34375 --- Comment #9 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 158497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158497&action=edit Bug 34375: Fix the option to provide no fund in budget dropdown Currently it is not possible to use the No fund option as the dropwdown will default to the first budget in the list. This patch re-adds this option so that the defaulting behaviour is fixed Test plan: 1) Go to a vendor record in Acquisitions and then Receive Shipment 2) Enter an invoice number 3) Leave the Shipping cost empty and Shipping Fund as 'No fund' 4) Receive some orders or go straight to Finish receiving 5) Notice the Shipping fund has defaulted to the first fund in the alphabetical list of funds. It is not possible to select 'No fund' and the selected fund is recorded in shipmentcost_budgetid incorrectly. 6) Apply patch 7) Repeat steps 1-5 and this time the No fund option should be used correctly -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34375 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158497|0 |1 is obsolete| | --- Comment #10 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 158513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158513&action=edit Bug 34375: Fix the option to provide no fund in budget dropdown Currently it is not possible to use the No fund option as the dropwdown will default to the first budget in the list. This patch re-adds this option so that the defaulting behaviour is fixed Test plan: 1) Go to a vendor record in Acquisitions and then Receive Shipment 2) Enter an invoice number 3) Leave the Shipping cost empty and Shipping Fund as 'No fund' 4) Receive some orders or go straight to Finish receiving 5) Notice the Shipping fund has defaulted to the first fund in the alphabetical list of funds. It is not possible to select 'No fund' and the selected fund is recorded in shipmentcost_budgetid incorrectly. 6) Apply patch 7) Repeat steps 1-5 and this time the No fund option should be used correctly Signed-off-by: Georgia Newman <g.newman@arts.ac.uk> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34375 Georgia Newman <g.newman@arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |g.newman@arts.ac.uk Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34375 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34375 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158513|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158557&action=edit Bug 34375: Fix the option to provide no fund in budget dropdown Currently it is not possible to use the No fund option as the dropwdown will default to the first budget in the list. This patch re-adds this option so that the defaulting behaviour is fixed Test plan: 1) Go to a vendor record in Acquisitions and then Receive Shipment 2) Enter an invoice number 3) Leave the Shipping cost empty and Shipping Fund as 'No fund' 4) Receive some orders or go straight to Finish receiving 5) Notice the Shipping fund has defaulted to the first fund in the alphabetical list of funds. It is not possible to select 'No fund' and the selected fund is recorded in shipmentcost_budgetid incorrectly. 6) Apply patch 7) Repeat steps 1-5 and this time the No fund option should be used correctly Signed-off-by: Georgia Newman <g.newman@arts.ac.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34375 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Shipping fund in an invoice |Shipping fund in an invoice |defaults to the first fund |defaults to the first fund |from the list rather than |from the list rather than |'no fund' after receiving. |'no fund' after receiving Version|22.11 |master QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34375 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34375 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34375 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|23.11.00 |23.11.00,23.05.06 released in| | Status|Pushed to master |Pushed to stable --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.06 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34375 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.11.00,23.05.06 |23.11.00,23.05.06,22.11.12 released in| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34375 --- Comment #14 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Nice work everyone! Pushed to 22.11.x for next release -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org