[Bug 8276] New: circ history not sorting right
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8276 Priority: P5 - low Change sponsored?: --- Bug ID: 8276 CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Assignee: koha-bugs@lists.koha-community.org Summary: circ history not sorting right Severity: normal Classification: Unclassified OS: All Reporter: nengard@gmail.com Hardware: All Status: NEW Version: master Component: Circulation Product: Koha Created attachment 10390 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10390&action=edit sort error When you're on the patron's circulation history in the staff client the far right column is sorting by month/day in descending order, but year is ascending. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8276 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell@ptfs-europe. | |com --- Comment #1 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Can you retest this? I think the patch associated with bug 8017 has fixed by removing some of the sorting layers that were over-complicating. It seems ok in my test. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8276 --- Comment #2 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Actually I can reproduce it... When there are items checked out it ceases sorting by date and searches by string to accomodate the text 'Checked out'. If borrower has no current issues its correct. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8276 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Can you retest this? The handling of date sorting has changed since the last comment was added so I'm not sure if this bug is still valid. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8276 --- Comment #4 from Colin Campbell <colin.campbell@ptfs-europe.com> --- On an admittedly small sample dates look ok. Strange behaviour with checked out items .... they always sort as being the earliest if you sort on that column (the sorting value is set to '00-00-0000' The patron's history is more intuitive, these appear as 'checked out' and characters being > numbers always sort as newer. If folk agree that making the two screens consustent is a good idea, I'll submit the patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8276 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8276 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37406 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37406&action=edit Bug 8276: circ history - checked out items are later If the sort is done on "checkin on", the items currently checked out should be list after all others. Test plan: 1/ Go on the checkout history page for a record with checked out items 2/ Sort on the "checkin on" column and confirm that the checked out items are sorted after/before others depending on the sort order (asc/desc). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8276 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m CC| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8276 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8276 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37406|0 |1 is obsolete| | --- Comment #6 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 37847 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37847&action=edit [SIGNED-OFF] Bug 8276: circ history - checked out items are later If the sort is done on "checkin on", the items currently checked out should be list after all others. Test plan: 1/ Go on the checkout history page for a record with checked out items 2/ Sort on the "checkin on" column and confirm that the checked out items are sorted after/before others depending on the sort order (asc/desc). Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8276 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8276 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37847|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 38141 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38141&action=edit [PASSED QA] Bug 8276: circ history - checked out items are later If the sort is done on "checkin on", the items currently checked out should be list after all others. Test plan: 1/ Go on the checkout history page for a record with checked out items 2/ Sort on the "checkin on" column and confirm that the checked out items are sorted after/before others depending on the sort order (asc/desc). Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8276 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 38142 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38142&action=edit Follow-up: Remove stry </td> Removes an additional </td> tag that isn't needed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8276 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org