[Bug 16089] New: Acquisitions -> Invoice broken by Bug 15084
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16089 Bug ID: 16089 Summary: Acquisitions -> Invoice broken by Bug 15084 Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/acqui/invoice.pl?invoiceid=X OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org I'm getting an error from acqui/invoice.pl: Software error: Can't use string ("Koha::Acquisition::Currency") as a HASH ref while "strict refs" in use at /Koha/Object.pm line 248. git bisect points to Bug 15084 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16089 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #1 from Marc Véron <veron@veron.ch> --- Confirmed. Log says: [Thu Mar 17 15:25:50 2016] invoice.pl: Use of uninitialized value in addition (+) at /usr/share/kohaclone/acqui/invoice.pl line 164., referer: http://192.168.1.24:8080/cgi-bin/koha/acqui/invoices.pl?op=do_search [Thu Mar 17 15:25:50 2016] invoice.pl: Use of uninitialized value in addition (+) at /usr/share/kohaclone/acqui/invoice.pl line 164., referer: http://192.168.1.24:8080/cgi-bin/koha/acqui/invoices.pl?op=do_search [Thu Mar 17 15:25:50 2016] invoice.pl: Can't use string ("Koha::Acquisition::Currency") as a HASH ref while "strict refs" in use at /usr/share/kohaclone/Koha/Object.pm line 248., referer: http://192.168.1.24:8080/cgi-bin/koha/acqui/invoices.pl?op=do_search -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16089 --- Comment #2 from Marc Véron <veron@veron.ch> --- Seems to be related to invoice.pl line 181: currency => Koha::Acquisition::Currency->get_active->currency, If I comment out this line, the error disappears. However, curency is used 3 times in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16089 --- Comment #3 from Marc Véron <veron@veron.ch> --- Created attachment 49272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49272&action=edit Bug 16089: Acquisitions -> Invoice broken by Bug 15084 To test: - Reproduce error described in first comment. - Apply patch - Try to reproduce error. Page will display as expected. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16089 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch Assignee|koha-bugs@lists.koha-commun |veron@veron.ch |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16089 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16089 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49272|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 49275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49275&action=edit [SIGNED-OFF] Bug 16089: Acquisitions -> Invoice broken by Bug 15084 To test: - Reproduce error described in first comment. - Apply patch - Try to reproduce error. Page will display as expected. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16089 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Another issue I just noticed, and I assume it is at least related. In the table of invoice details where it used to show the currency code Total tax exc. (USD) it now reads Total tax exc. (Koha::Acquisition::Currency=HASH(0x7587d38)) A separate issue, or the fix is incomplete? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16089 --- Comment #6 from Marc Véron <veron@veron.ch> --- Created attachment 49278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49278&action=edit Bug 16089: (Follow up) Display currency symbol properly This patch fixes the display of the currency symbol on invoice.tt See comment #5 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16089 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16089 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Depends on| |15084 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16089 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16089 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49275|0 |1 is obsolete| | Attachment #49278|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 49305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49305&action=edit Bug 16089: Acquisitions -> Invoice broken by Bug 15084 To test: - Reproduce error described in first comment. - Apply patch - Try to reproduce error. Page will display as expected. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16089 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 49306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49306&action=edit Bug 16089: (Follow up) Display currency symbol properly This patch fixes the display of the currency symbol on invoice.tt See comment #5 Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16089 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Severity|major |blocker -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16089 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Thanks Marc for the patch, and Owen for the catch! :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16089 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15084 | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16089 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- git grep 'Currency->get_active' does not return any results with this patch applied. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16089 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #11 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16089 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #12 from Julian Maurice <julian.maurice@biblibre.com> --- Does not concern stable versions, status changed to RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16089 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|Oldversions |--- -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org