[Bug 38186] New: Cancelling a hold from the holds over tab shouldn't trigger "return to home" transfer on a lost item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38186 Bug ID: 38186 Summary: Cancelling a hold from the holds over tab shouldn't trigger "return to home" transfer on a lost item Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: emily.lamancusa@montgomerycountymd.gov QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Sometimes, when cancelling waiting holds that have expired, the book on hold cannot be found on the holds shelf. In this case, the librarian would mark the item missing/lost and cancel the hold. However, if the librarian sets the lost status first and then cancels the hold on an item that would normally trigger a "return to home" transfer, the transfer still gets triggered and the lost status is removed, which is confusing and inaccurate. If the item is already marked as lost, it should stay lost and shouldn't generate a transfer. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38186 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |emily.lamancusa@montgomeryc |ity.org |ountymd.gov -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38186 --- Comment #1 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 172821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172821&action=edit Bug 38186: Don't initiate transfer when cancelling hold on lost item To test: 0. In the Circulation Rules, set the default return policy to "item returns home (default settings have this already) 1. Find an item belonging to a branch other than the logged-in branch 2. Place a hold on that biblio record for pickup at the logged-in branch 3. Check in the item to set the hold to waiting 4. Set the expiration date to a date in the past To do this in KTD: ktd --shell koha-mysql kohadev UPDATE reserves SET expirationdate = < yesterday's date >; 5. Set a lost status on the item 6. Go to Circulation > Holds awaiting pickup --> The hold should appear on the "holds waiting past their expiration date" tab 7. Click the "Cancel and return to <homebranch>" button next to the hold 8. Open the biblio record for the item --> Note that the lost status is gone and the item shows as in-transit 9. Apply patch 10. Repeat steps 2-8 on the same item --> This time, the item is still lost and is not in-transit -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38186 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38186 --- Comment #2 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Really, this whole workflow could use some refactoring... Fixing this obvious bug for now, but I'll try to make time to come back to this next cycle. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38186 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38186 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172821|0 |1 is obsolete| | --- Comment #3 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 174433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174433&action=edit Bug 38186: Don't initiate transfer when cancelling hold on lost item To test: 0. In the Circulation Rules, set the default return policy to "item returns home (default settings have this already) 1. Find an item belonging to a branch other than the logged-in branch 2. Place a hold on that biblio record for pickup at the logged-in branch 3. Check in the item to set the hold to waiting 4. Set the expiration date to a date in the past To do this in KTD: ktd --shell koha-mysql kohadev UPDATE reserves SET expirationdate = < yesterday's date >; 5. Set a lost status on the item 6. Go to Circulation > Holds awaiting pickup --> The hold should appear on the "holds waiting past their expiration date" tab 7. Click the "Cancel and return to <homebranch>" button next to the hold 8. Open the biblio record for the item --> Note that the lost status is gone and the item shows as in-transit 9. Apply patch 10. Repeat steps 2-8 on the same item --> This time, the item is still lost and is not in-transit Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38186 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38186 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174433|0 |1 is obsolete| | --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 174537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174537&action=edit Bug 38186: Don't initiate transfer when cancelling hold on lost item To test: 0. In the Circulation Rules, set the default return policy to "item returns home (default settings have this already) 1. Find an item belonging to a branch other than the logged-in branch 2. Place a hold on that biblio record for pickup at the logged-in branch 3. Check in the item to set the hold to waiting 4. Set the expiration date to a date in the past To do this in KTD: ktd --shell koha-mysql kohadev UPDATE reserves SET expirationdate = < yesterday's date >; 5. Set a lost status on the item 6. Go to Circulation > Holds awaiting pickup --> The hold should appear on the "holds waiting past their expiration date" tab 7. Click the "Cancel and return to <homebranch>" button next to the hold 8. Open the biblio record for the item --> Note that the lost status is gone and the item shows as in-transit 9. Apply patch 10. Repeat steps 2-8 on the same item --> This time, the item is still lost and is not in-transit Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38186 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |chris@bigballofwax.co.nz |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38186 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38186 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38186 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38186 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|24.11.00 |24.11.00,24.05.06 released in| | CC| |lucas@bywatersolutions.com --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38186 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_05_candidate | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38186 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- This makes sens, but I prefer not impact 23.11.x for stability -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org