[Bug 7422] New: Prevent creation of vendors with the same name
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7422 Bug #: 7422 Summary: Prevent creation of vendors with the same name Classification: Unclassified Change sponsored?: --- Product: Koha Version: unspecified Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions AssignedTo: henridamien@koha-fr.org ReportedBy: adrien.saurat@biblibre.com QAContact: ian.walls@bywatersolutions.com It's now possible to create 2 or more vendors with exactly the same name. It would be good to prevent this by adding a check during the creation of a new vendor. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7422 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7422 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|henridamien@koha-fr.org |adrien.saurat@biblibre.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7422 --- Comment #1 from Adrien SAURAT <adrien.saurat@biblibre.com> 2012-01-10 14:55:14 UTC --- Created attachment 7104 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7104 proposed patch Ensures that : - name is not a space only string - name is unique - name does not contain quotation marks All controls on client side (JavaScript alert). -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7422 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7422 Duncan <duncan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7104|0 |1 is obsolete| | --- Comment #2 from Duncan <duncan@catalyst.net.nz> 2012-01-11 01:21:58 UTC --- Created attachment 7105 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7105 Patch to ensure vendor names are unique and do not contain " or only spaces. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7422 Duncan <duncan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |duncan@catalyst.net.nz Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7422 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |paul.poulain@biblibre.com --- Comment #3 from Paul Poulain <paul.poulain@biblibre.com> 2012-01-17 17:19:05 UTC --- QA comment: #1 no SQL in .pl script (see guidelines) #2 I really don't like how this script works: it load all bookseller names in the page, I'll ask for someone else QA, but I tend to say "failed QA" marking failed QA for #1, #2 can have another opinion (ian ?) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7422 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7105|0 |1 is obsolete| | --- Comment #4 from Adrien SAURAT <adrien.saurat@biblibre.com> 2012-01-18 10:44:36 UTC --- Created attachment 7213 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7213 proposed patch #2 New patch correcting problems #1 and #2 mentionned by Paul. Ajax implemented: a new script "check_duplicate_bookseller_ajax.pl" is added (perltidy applied on it). -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7422 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7422 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P5 - low Status|Needs Signoff |Failed QA Version|unspecified |master --- Comment #5 from Owen Leonard <oleonard@myacpl.org> 2012-01-19 21:02:34 UTC --- This seems to be working well for adding a new vendor: I was correctly prevented from adding a vendor with a duplicate name. But when I went back to try to edit a vendor record I was given the same warning. The script must be able to tell when checking is appropriate: - New vendors - Changes to the name of an existing vendor ...and to not check when: - Making changes to aspects of a vendor record besides the name. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7422 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7213|0 |1 is obsolete| | --- Comment #6 from Adrien SAURAT <adrien.saurat@biblibre.com> 2012-01-20 12:04:11 UTC --- Created attachment 7254 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7254 proposed patch #3 Corrected the behaviour when editing an existing vendor. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7422 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7422 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7254|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> 2012-01-20 13:40:41 UTC --- Created attachment 7255 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7255 Signed-off patch Successfully tested these cases: - Editing an existing vendor - Creating a new vendor with a duplicate name - Creating a new vendor with quotes in the name - Creating a new vendor with only spaces - Creating a new vendor with a valid name -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7422 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7422 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QAContact|koha.sekjal@gmail.com |m.de.rooy@rijksmuseum.nl -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7422 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #8 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2012-02-03 11:16:28 UTC --- QA Comment: Adrien, thanks for submitting this patch. I would prefer however to do the check for a duplicate vendor more economical. With the call to GetBookSellers, you ask for all records. And then you make an exact comparison in perl. In that case you could just pass the string to GetBookSellers too! On the other hand, if I have a vendor like Erasmus BV and I am testing for Erasmus, I would be happy if I at least would be warned for it. You now give OK for that situation since you only test exact equivalence. Hoping that you could make some adjustments in this direction. Changing status to reflect that. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7422 --- Comment #9 from Adrien SAURAT <adrien.saurat@biblibre.com> 2012-02-03 15:46:33 UTC --- Thanks, it would be a good idea indeed to display a warning in this case, I'll go this way. I'll have to see if the default JS pop up window can handle a "OK/Cancel" behaviour. Let me know if there is a standard way to handle this kind of case in Koha. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7422 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-13 12:49:33 UTC --- (In reply to comment #8)
On the other hand, if I have a vendor like Erasmus BV and I am testing for Erasmus, I would be happy if I at least would be warned for it. You now give OK for that situation since you only test exact equivalence. I disagree: atm, some libraries must create "similar" vendors, like "Erasmus books" and "Erasmus DVD" because Koha don't handle multiple VAT rates. In france, books have a VAT of 5.5% while DVDs have a 19.6% So libraries must create more than 1 "Erasmus" bookseller.
There is another test case: networks with independantbranches, where 3 libraries can have different "Erasmus" booksellers because each of them has a separate contract, different contact,... So I think the test should just be strict. And the library that started with this topic wanted to addresse "strict" duplicate of vendors. Having "similar" checking is another topic imo (it's not a bad idea, but would address a different problem) Switching back to "signed-off", for Marcel to QA again. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7422 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #11 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2012-02-27 08:15:40 UTC --- Thanks for your reactions. My first comment still applies and IMO blocks this patch. It is really not necessary to ask Koha for all booksellers and compare them in perl, especially when you only want a exact equivalence. Please change the argument to GetBookSellers. Secondly, I was not saying that you should not be able to create similar vendors like Erasmus 1 and Erasmus 2, but it would be beneficial to warn for such occurrences. I agree that it formally is outside the scope of this report. So please focus on the first point. Changing status to reflect current request. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7422 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7255|0 |1 is obsolete| | --- Comment #12 from Adrien SAURAT <adrien.saurat@biblibre.com> --- Created attachment 7978 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7978&action=edit proposed patch #2 Corrected patch for the 1st mentioned point. I still had to keep a perl check because GetBookSeller, when fed with a parameter like "Vendor1" will return not only "Vendor1" but also "Vendor12". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7422 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7422 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: It's not clear for me or not complete. If you don't want 2 vendors with the same name, you have to have a unique key on the aqbooksellers.name field in the DB. But why set this constraint ? I'm ok to inform the user if 2 names are similars but not to forbid this way. I think there is no problem in Koha if 2 vendors have the same name (about functionally). Passed Failed QA, but need additionnal QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7422 --- Comment #14 from Adrien SAURAT <adrien.saurat@biblibre.com> --- Where should we go then? I created this patch because one of our librarians asked for this but maybe it's not really useful. Do we keep the idea? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7422 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7422 Sophie MEYNIEUX <sophie.meynieux@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sophie.meynieux@biblibre.co | |m Assignee|adrien.saurat@biblibre.com |christophe.croullebois@bibl | |ibre.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7422 Alessandra Carassiti <a.carassiti@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |a.carassiti@cineca.it -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7422 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED CC| |paola.rossi@cineca.it Resolution|--- |WONTFIX --- Comment #15 from Paola Rossi <paola.rossi@cineca.it> --- There was no discussion about the topic after comment 14. So I pass this bug from "In discussion" to "Resolved - Wontfix" status. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org