[Bug 29758] New: CGI::param in list context in boraccount.pl warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29758 Bug ID: 29758 Summary: CGI::param in list context in boraccount.pl warning Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: tomascohen@gmail.com Reporter: evelyn@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Found the following warning in plack intranet error log: CGI::param called in list context from boraccount.pl line 58, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 412. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29758 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com --- Comment #1 from Liz Rea <wizzyrea@gmail.com> --- Just kinda feels like something we should fix, yknow? :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29758 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|21.05 |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29758 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 128907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128907&action=edit Bug 29758: Get rid of warning in members/boraccount.pl This patch removes a noisy warning found in production logs. To test: 1. Run: $ tail -f /var/log/koha/kohadev/plack-intranet-error.log 2. Open the 'Accounting' tab for a patron, then click on 'Transactions' => FAIL: You see this kind of warning in the logs: [WARN] CGI::param called in list context from... 3. Apply this patch 4. Repeat 2 (change tab and go back) => SUCCESS: No more warning! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29758 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch CC| |tomascohen@gmail.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29758 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29771 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29771 [Bug 29771] Get rid of CGI::param in list context warnings [UMBRELLA] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29758 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29758 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128907|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 128940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128940&action=edit Bug 29758: Get rid of warning in members/boraccount.pl This patch removes a noisy warning found in production logs. To test: 1. Run: $ tail -f /var/log/koha/kohadev/plack-intranet-error.log 2. Open the 'Accounting' tab for a patron, then click on 'Transactions' => FAIL: You see this kind of warning in the logs: [WARN] CGI::param called in list context from... 3. Apply this patch 4. Repeat 2 (change tab and go back) => SUCCESS: No more warning! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29758 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This removes the cause of release notes| |warning messages ([WARN] | |CGI::param called in list | |context from...) in the | |plack-intranet-error.log | |when accessing the | |accounting transactions tab | |for a patron. CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29758 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29758 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128940|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 129192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129192&action=edit Bug 29758: Get rid of warning in members/boraccount.pl This patch removes a noisy warning found in production logs. To test: 1. Run: $ tail -f /var/log/koha/kohadev/plack-intranet-error.log 2. Open the 'Accounting' tab for a patron, then click on 'Transactions' => FAIL: You see this kind of warning in the logs: [WARN] CGI::param called in list context from... 3. Apply this patch 4. Repeat 2 (change tab and go back) => SUCCESS: No more warning! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29758 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29758 --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29758 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |kyle@bywatersolutions.com Version(s)|22.05.00 |22.05.00,21.11.03 released in| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29758 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com Status|Pushed to stable |Pushed to oldstable Version(s)|22.05.00,21.11.03 |22.05.00,21.11.03,21.05.11 released in| | --- Comment #7 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29758 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED CC| |victor@tuxayo.net --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org