[Bug 21064] New: Advanced cataloging editor - rancor - check for changes should return 'undefined' instead of 'undef'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21064 Bug ID: 21064 Summary: Advanced cataloging editor - rancor - check for changes should return 'undefined' instead of 'undef' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl undef causes a JS error, undefined seems to be the correct term to use -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21064 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21064 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 76882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76882&action=edit Bug 21064: Use undefined instead of undef To test: 1 - Load the advanced cataloging editor 2 - Refresh the page several times 3 - Check the JS console, you shoudl see an error: 'undef is not defined' 4 - Apply patch 5 - Try again, should be no error -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21064 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | Depends on| |19267 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19267 [Bug 19267] Advanced Editor - Rancor - Add warning before leaving page if there are unsaved modifications -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21064 Pierre-Luc Lapointe <pierre-luc.lapointe@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76882|0 |1 is obsolete| | --- Comment #2 from Pierre-Luc Lapointe <pierre-luc.lapointe@inLibro.com> --- Created attachment 76963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76963&action=edit Bug 21064: Use undefined instead of undef To test: 1 - Load the advanced cataloging editor 2 - Refresh the page several times 3 - Check the JS console, you shoudl see an error: 'undef is not defined' 4 - Apply patch 5 - Try again, should be no error Signed-off-by: Pierre-Luc Lapointe <pierreluc.lapointe@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21064 Pierre-Luc Lapointe <pierre-luc.lapointe@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pierre-luc.lapointe@inLibro | |.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21064 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21064 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76963|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 77065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77065&action=edit Bug 21064: Use undefined instead of undef To test: 1 - Load the advanced cataloging editor 2 - Refresh the page several times 3 - Check the JS console, you shoudl see an error: 'undef is not defined' 4 - Apply patch 5 - Try again, should be no error Signed-off-by: Pierre-Luc Lapointe <pierreluc.lapointe@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21064 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21064 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21064 Bug 21064 depends on bug 19267, which changed state. Bug 19267 Summary: Advanced Editor - Rancor - Add warning before leaving page if there are unsaved modifications https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19267 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21064 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.11.x for 17.11.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21064 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org