[Bug 9245] New: Visual Bug under fines tab
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9245 Bug ID: 9245 Summary: Visual Bug under fines tab Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.8 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: jesse@bywatersolutions.com CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Created attachment 13947 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13947&action=edit Fine Tab Fines tab showing active I found that if you are on the Fines "Account" tab, the Fines tab on the side of the display shows active, but if you are on the Pay Fines tab, Manual Invoice tab, or Create Manual Credit tabs, the Fines tab on the side no longer shows active. I think this is a visual bug. It should show active no matter what fines tab you are in. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9245 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13947|0 |1 is obsolete| | --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 13948 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13948&action=edit Fines tab -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9245 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #2 from Nicole C. Engard <nengard@gmail.com> --- This is still an issue in master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9245 --- Comment #3 from Viktor Sarge <viktor.sarge@regionhalland.se> --- Created attachment 28862 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28862&action=edit 9245 Fixes visual bux with fines tab not highlighting This patch makes shure that mancredit.pl, maninvoice.pl and pay.pl passes the value "finesview=1" that makes the tab active. Test plan: 1) Go to a library user and the fines tab. Note that the "Fines" tab loses it's highlight when you click "Pay fines", "Create manual invoice" and "Create manual credit". 2) Install the patch. 3) Redo the first step and make shure that the left menu tab "Fines" is now highlighted all the time. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9245 Viktor Sarge <viktor.sarge@regionhalland.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |viktor.sarge@regionhalland. | |se -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9245 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9245 --- Comment #4 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 28874 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28874&action=edit [SIGNED-OFF] 9245 Fixes visual bux with fines tab not highlighting This patch makes shure that mancredit.pl, maninvoice.pl and pay.pl passes the value "finesview=1" that makes the tab active. Test plan: 1) Go to a library user and the fines tab. Note that the "Fines" tab loses it's highlight when you click "Pay fines", "Create manual invoice" and "Create manual credit". 2) Install the patch. 3) Redo the first step and make shure that the left menu tab "Fines" is now highlighted all the time. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9245 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28862|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9245 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #5 from Christopher Brannon <cbrannon@cdalibrary.org> --- Viktor, looks like we have the same issue we had on bug 12332. Please start the commit message of your patches by "Bug XXXXX". Otherwise the sandboxes cannot signoff them. Thanks. Christopher -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9245 --- Comment #6 from Viktor Sarge <viktor.sarge@regionhalland.se> --- (In reply to Christopher Brannon from comment #5)
Viktor, looks like we have the same issue we had on bug 12332. Please start the commit message of your patches by "Bug XXXXX". Otherwise the sandboxes cannot signoff them. Thanks.
Christopher
Yes I missed formatting the first line with "Bug XXXX" in my first five patches. Would I mess up anything if I resubmit those that are not yet signed off with a correct first line? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9245 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9245 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28874|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 28981 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28981&action=edit 9245 Fixes visual bux with fines tab not highlighting This patch makes shure that mancredit.pl, maninvoice.pl and pay.pl passes the value "finesview=1" that makes the tab active. Test plan: 1) Go to a library user and the fines tab. Note that the "Fines" tab loses it's highlight when you click "Pay fines", "Create manual invoice" and "Create manual credit". 2) Install the patch. 3) Redo the first step and make shure that the left menu tab "Fines" is now highlighted all the time. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9245 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- I developed exactly the same fix yesterday on bug 12447. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9245 --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- *** Bug 12447 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9245 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Version|3.8 |master Assignee|koha-bugs@lists.koha-commun |viktor.sarge@regionhalland. |ity.org |se QA Contact| |jonathan.druart@biblibre.co | |m Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9245 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Viktor! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9245 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #11 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to 3.16.x for inclusion in 3.16.2. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org