https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35237 --- Comment #1 from Courtney Brown <courtneybrown@catalyst.net.nz> --- Created attachment 184253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184253&action=edit BUG: 35237 Duplicate ids in markup of patron card form updated to have unique IDs. Test plan: 1. Head to 'tool's then 'patronn card creator' 2. Click on 'Layouts' underneath 'Manage' 3. Click on 'Edit' 4. Inspect the page and check that the ids for Page side are unique. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35237 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184253|0 |1 is obsolete| | --- Comment #2 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 184421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184421&action=edit Bug 35237: Give patron card layout form elements unique IDs This patch ensures the following patron card layout form fields use unique IDs: - page side - guide box - guide grid This semantically links the options to their labels so is more accessible for screen readers and keyboard navigation. The patch also adds a 'default' option to the original labels so they can become useful elements on the form rather than just text labels. Test plan: 1. Head to 'tools' then 'patron card creator' 2. Click on 'Layouts' underneath 'Manage' 3. Click on 'Edit' 4. Confirm it's easy to tell which options are available and chosen for page side, guide box, and guide grid 5. Click on the text labels for the options i.e. front, back, on, off. Confirm the relevant radio button is selected Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35237 Noah <noah.tremblay@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184421|0 |1 is obsolete| | --- Comment #3 from Noah <noah.tremblay@inlibro.com> --- Created attachment 186246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186246&action=edit Bug 35237: Give patron card layout form elements unique IDs This patch ensures the following patron card layout form fields use unique IDs: - page side - guide box - guide grid This semantically links the options to their labels so is more accessible for screen readers and keyboard navigation. The patch also adds a 'default' option to the original labels so they can become useful elements on the form rather than just text labels. Test plan: 1. Head to 'tools' then 'patron card creator' 2. Click on 'Layouts' underneath 'Manage' 3. Click on 'Edit' 4. Confirm it's easy to tell which options are available and chosen for page side, guide box, and guide grid 5. Click on the text labels for the options i.e. front, back, on, off. Confirm the relevant radio button is selected Sponsored-by: Catalyst IT Signed-off-by: noah <noah@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35237 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- - <label for="page_side">Page side: </label> + <label for="page_side_front">Page side: </label> Not sure about this change. Why front here? + <label for="page_side_front">Front: <input type="radio" name="page_side" id="page_side_front" value="F" /></label> Why include the input in the label ? Please explain. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35237 Harrison Hawkins <harrisonhawkins@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff CC| |harrisonhawkins@catalyst.ne | |t.nz --- Comment #7 from Harrison Hawkins <harrisonhawkins@catalyst.net.nz> --- (In reply to Marcel de Rooy from comment #5)

- <label for="page_side">Page side: </label> + <label for="page_side_front">Page side: </label> Not sure about this change. Why front here?

+ <label for="page_side_front">Front: <input type="radio" name="page_side" id="page_side_front" value="F" /></label> Why include the input in the label ?

Please explain.

In response to your first comment we have changed the labels for page side, guide box, guide grid. In response to second comment about inputs in labels we have noticed this formatting is elsewhere in koha for example see below: koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt: <label><input type="radio" name="branch" value="homebranch" /> Home library</label> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35237 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Comma delimited| |Catalyst list of Sponsors| | Sponsorship status|--- |Sponsored CC| |aleisha@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35237 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186246|0 |1 is obsolete| | Attachment #191736|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 191806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191806&action=edit Bug 35237: Give patron card layout form elements unique IDs This patch ensures the following patron card layout form fields use unique IDs: - page side - guide box - guide grid This semantically links the options to their labels so is more accessible for screen readers and keyboard navigation. The patch also adds a 'default' option to the original labels so they can become useful elements on the form rather than just text labels. Test plan: 1. Head to 'tools' then 'patron card creator' 2. Click on 'Layouts' underneath 'Manage' 3. Click on 'Edit' 4. Confirm it's easy to tell which options are available and chosen for page side, guide box, and guide grid 5. Click on the text labels for the options i.e. front, back, on, off. Confirm the relevant radio button is selected Sponsored-by: Catalyst IT Signed-off-by: noah <noah@inlibro.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35237 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 191808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191808&action=edit Bug 35237: (QA follow-up) Set label for attribute to first radio input Labels with a "for" attribute should reference an existing input, so we should keep the "Page side," "Guide box," and "Guide grid" for attribute pointing to the first corresponding radio input in that row. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35237 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191806|0 |1 is obsolete| | --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 195250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195250&action=edit Bug 35237: Give patron card layout form elements unique IDs This patch ensures the following patron card layout form fields use unique IDs: - page side - guide box - guide grid This semantically links the options to their labels so is more accessible for screen readers and keyboard navigation. The patch also adds a 'default' option to the original labels so they can become useful elements on the form rather than just text labels. Test plan: 1. Head to 'tools' then 'patron card creator' 2. Click on 'Layouts' underneath 'Manage' 3. Click on 'Edit' 4. Confirm it's easy to tell which options are available and chosen for page side, guide box, and guide grid 5. Click on the text labels for the options i.e. front, back, on, off. Confirm the relevant radio button is selected Sponsored-by: Catalyst IT Signed-off-by: noah <noah@inlibro.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35237 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191808|0 |1 is obsolete| | --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 195252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195252&action=edit Bug 35237: (QA follow-up) Set label for attribute to first radio input Labels with a "for" attribute should reference an existing input, so we should keep the "Page side," "Guide box," and "Guide grid" for attribute pointing to the first corresponding radio input in that row. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35237 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35237 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.05.00 |26.05.00,25.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35237 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #16 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 25.05.x unless requested -- You are receiving this mail because: You are watching all bug changes.