[Bug 24144] New: regressions.t tests have not been updated after bug 23836
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24144 Bug ID: 24144 Summary: regressions.t tests have not been updated after bug 23836 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Depends on: 23836 t/db_dependent/www/regressions.t .. # Failed test '302 for biblionumber with matching URI' # at t/db_dependent/www/regressions.t line 105. # got: '404' # expected: '302' # Failed test '302 for itemnumber with matching URI' # at t/db_dependent/www/regressions.t line 109. # got: '404' # expected: '302' # Failed test '302 for biblionumber with matching URI' # at t/db_dependent/www/regressions.t line 120. # got: '404' # expected: '302' # Failed test '302 for itemnumber with matching URI' # at t/db_dependent/www/regressions.t line 124. # got: '404' # expected: '302' # Failed test '302 for biblionumber with matching URI' # at t/db_dependent/www/regressions.t line 135. # got: '404' # expected: '302' # Failed test '302 for itemnumber with matching URI' # at t/db_dependent/www/regressions.t line 139. # got: '404' # expected: '302' # Looks like you failed 6 tests of 36. t/db_dependent/www/regressions.t .. 1/1 # Failed test 'open redirection vulnerabilities in tracklinks' # at t/db_dependent/www/regressions.t line 141. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24144 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24144 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95928&action=edit Bug 24144: (bug 23836 follow-up) Fix regressions.t tests Bug 24144 changes the behavior for tracklinks.pl but did not adjust the tests. We must then expect 404 if the pref is turned off. Also mock_preference cannot work (we are hitting the web server and so need to set the value in DB and flush the L1 caches) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24144 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95928|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 95929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95929&action=edit Bug 24144: (bug 23836 follow-up) Fix regressions.t tests Bug 23836 changes the behavior for tracklinks.pl but did not adjust the tests. We must then expect 404 if the pref is turned off. Also mock_preference cannot work (we are hitting the web server and so need to set the value in DB and flush the L1 caches) Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24144 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize@ptfs-europe | |.com --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for the quick fix Jonathan, Passing QA and Pushing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24144 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24144 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24144 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24144 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com, | |kyle@bywatersolutions.com, | |lucas@bywatersolutions.com, | |nick@bywatersolutions.com Keywords| |rel_19_05_candidate, | |rel_19_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24144 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.05.00 |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24144 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|20.05.00 |20.05.00, 19.11.01 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24144 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.11.x for 19.11.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24144 --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.06 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org