[Bug 19876] New: Koha::Account->pay() does not exit specific fine loop when balance is used up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19876 Bug ID: 19876 Summary: Koha::Account->pay() does not exit specific fine loop when balance is used up Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org If a patron selects specific fines to pay and enters an amount less than all of those fines the loop will continue through all fines. This can be problematic for lost fines which are not paid or not paid fully as they will be marked 'Paid for...' and returned -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19876 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- To recreate: 1 - Create a manual fine for a patron (or find one with fines) 2 - Check out an item to this patron 3 - Ensure the item has a lost charge 4 - Mark the item lost via a method that will not check it in (MarkLostItemsAsReturned syspref) 5 - Note the item is checked out to patron and they are charged 6 - From patron go to Accounting->Make a payment, select all, 'Pay selected' 7 - Enter an amount less than the value of the first fine and pay 8 - Payments are calculated correctly, however, the item is now checked in 9 - View the item on the 'items' tab of the biblio 10 - The 'Paid for?' section notes the item has been paid for 11 - Pay a partial amount again 12 - Paid for now has doubled info -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19876 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19876 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19876 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This could be solved by replacing ->pay for ->add_credit + ->apply (they were designed for that). I'll take a look! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19876 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Hi Tomas, do you plan to work on this one? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19876 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #3)
Hi Tomas, do you plan to work on this one?
Not in a short term. Ask Martin, as he was working on replacement methods. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19876 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- In the described case, the API for adding credits against a list of debit lines could be used, and it wouldn't suffer from this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19876 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14825 CC| |martin.renvoize@ptfs-europe | |.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19876 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|tomascohen@gmail.com |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19876 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- UX question.. currently, we just work through the selected items in the order they're sent to the routine I believe.. should there be a precedence for what types of charges are paid off first? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19876 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |enhancement --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- The bug here was inadvertently fixed by bug 22982 in which a check on amountoutstanding was introduced. We should still short-circuit the loop at some point to prevent needless processing, but at this point that change is now an architectural enhancement rather a major bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19876 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|ASSIGNED |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19876 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|martin.renvoize@ptfs-europe |koha-bugs@lists.koha-commun |.com |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org