[Bug 18502] New: koha-shell broken on dev installs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18502 Bug ID: 18502 Summary: koha-shell broken on dev installs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt@gmail.com Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org CC: robin@catalyst.net.nz Bug 16749 introduced a nice way to have flexible paths. During the discussion on how to do it, we moved from having it contain the path to the git dir to just a boolean. The 'koha-shell' script didn't get attention it seems, and it is broken on dev installs. This was hidden by the fact that many of us run dev installs on kohadevbox, which sets a .bashrc file for de instance's user, containing the right path when opening the new shell. To reproduce: - On kohadevbox, run: $ sudo koha-shell kohadev -c "perl misc4dev/populate_db.pl" => FAIL: C4/Installer.pm not found on PERL5LIB error. Fix to be attached. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18502 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16749 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16749 [Bug 16749] Additional fixes for debian scripts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18502 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18502 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 62790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62790&action=edit Bug 18502: Make koha-shell set the right PERL5LIB on dev installs Bug 16749 introduced a nice way to have flexible paths. During the discussion on how to do it, we moved from having it contain the path to the git dir to just a boolean. The 'koha-shell' script didn't get attention it seems, and it is broken on dev installs. This was hidden by the fact that many of us run dev installs on kohadevbox, which sets a .bashrc file for de instance's user, containing the right path when opening the new shell. This patch changes the logic so on a dev install, intranetdir is picked as the right path. This is how it is handled in koha-functions.sh To test: - On kohadevbox, run: $ sudo koha-shell kohadev -c "perl misc4dev/populate_db.pl" => FAIL: C4/Installer.pm not found on PERL5LIB error. - Apply this patch - Replace /usr/bin/koha-shell with debian/scripts/koha-shell $ sudo cp kohaclone/debian/scripts/koha-shell /usr/bin/koha-shell - Run: $ sudo koha-shell kohadev -c "perl misc4dev/populate_db.pl" => SUCCESS: No warning about missing libs is raised. - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18502 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |tomascohen@gmail.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18502 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18502 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62790|0 |1 is obsolete| | --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 62792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62792&action=edit Bug 18502: Make koha-shell set the right PERL5LIB on dev installs Bug 16749 introduced a nice way to have flexible paths. During the discussion on how to do it, we moved from having it contain the path to the git dir to just a boolean. The 'koha-shell' script didn't get attention it seems, and it is broken on dev installs. This was hidden by the fact that many of us run dev installs on kohadevbox, which sets a .bashrc file for de instance's user, containing the right path when opening the new shell. This patch changes the logic so on a dev install, intranetdir is picked as the right path. This is how it is handled in koha-functions.sh To test: - On kohadevbox, run: $ sudo koha-shell kohadev -c "perl misc4dev/populate_db.pl" => FAIL: C4/Installer.pm not found on PERL5LIB error. - Apply this patch - Replace /usr/bin/koha-shell with debian/scripts/koha-shell $ sudo cp kohaclone/debian/scripts/koha-shell /usr/bin/koha-shell - Run: $ sudo koha-shell kohadev -c "perl misc4dev/populate_db.pl" => SUCCESS: No warning about missing libs is raised. - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18502 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18502 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18502 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62792|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 62907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62907&action=edit Bug 18502: Make koha-shell set the right PERL5LIB on dev installs Bug 16749 introduced a nice way to have flexible paths. During the discussion on how to do it, we moved from having it contain the path to the git dir to just a boolean. The 'koha-shell' script didn't get attention it seems, and it is broken on dev installs. This was hidden by the fact that many of us run dev installs on kohadevbox, which sets a .bashrc file for de instance's user, containing the right path when opening the new shell. This patch changes the logic so on a dev install, intranetdir is picked as the right path. This is how it is handled in koha-functions.sh To test: - On kohadevbox, run: $ sudo koha-shell kohadev -c "perl misc4dev/populate_db.pl" => FAIL: C4/Installer.pm not found on PERL5LIB error. - Apply this patch - Replace /usr/bin/koha-shell with debian/scripts/koha-shell $ sudo cp kohaclone/debian/scripts/koha-shell /usr/bin/koha-shell - Run: $ sudo koha-shell kohadev -c "perl misc4dev/populate_db.pl" => SUCCESS: No warning about missing libs is raised. - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18502 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18502 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62907|0 |1 is obsolete| | --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 62957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62957&action=edit Bug 18502: Make koha-shell set the right PERL5LIB on dev installs Bug 16749 introduced a nice way to have flexible paths. During the discussion on how to do it, we moved from having it contain the path to the git dir to just a boolean. The 'koha-shell' script didn't get attention it seems, and it is broken on dev installs. This was hidden by the fact that many of us run dev installs on kohadevbox, which sets a .bashrc file for de instance's user, containing the right path when opening the new shell. This patch changes the logic so on a dev install, intranetdir is picked as the right path. This is how it is handled in koha-functions.sh To test: - On kohadevbox, run: $ sudo koha-shell kohadev -c "perl misc4dev/populate_db.pl" => FAIL: C4/Installer.pm not found on PERL5LIB error. - Apply this patch - Replace /usr/bin/koha-shell with debian/scripts/koha-shell $ sudo cp kohaclone/debian/scripts/koha-shell /usr/bin/koha-shell - Run: $ sudo koha-shell kohadev -c "perl misc4dev/populate_db.pl" => SUCCESS: No warning about missing libs is raised. - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18502 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.05, thanks! For GBSD we want kohadevboxes to be populated automatically. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18502 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Missing piece for including bug 16733 - will come back to this later. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18502 Bug 18502 depends on bug 16749, which changed state. Bug 16749 Summary: Additional fixes for debian scripts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16749 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18502 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18502 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.08. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18502 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #8 from Mason James <mtj@kohaaloha.com> --- Blocked by Enhancement, skipping for 16.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org