[Bug 37860] New: Holds Awaiting Pickup table should include the patron main contact method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37860 Bug ID: 37860 Summary: Holds Awaiting Pickup table should include the patron main contact method Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: blawlor@clamsnet.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Our library staff would like to see the patron main contact method included in the Holds Awaiting so they can easily tell if they should call up the patron to pickup their holds. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37860 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |blawlor@clamsnet.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37860 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37860 --- Comment #1 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 171207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171207&action=edit Bug 37860: Add Main contact method to Holds awaiting pickup table This patch adds the main contact method to the patron column of the Holds awaiting pickup table. The style is intended to match the modal on the hold found modal. To test: 1. Apply patch and run yarn build && restart_all 2. Place a hold for a patron and check in the item 3. Notice the modal displays the main contact method in a yellow box 4. Go to Circulation > Holds awaiting pickup 5. Notice the main contact method displays in the Patron column in the same style -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37860 --- Comment #2 from Brendan Lawlor <blawlor@clamsnet.org> --- Not sure if this is the best way to do the CSS, but the concept is to make the styling match how main contact method is displayed in the hold found modal. See Bug 33398 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37860 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37860 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171207|0 |1 is obsolete| | --- Comment #3 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 171998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171998&action=edit Bug 37860: Add Main contact method to Holds awaiting pickup table This patch adds the main contact method to the patron column of the Holds awaiting pickup table. The style is intended to match the modal on the hold found modal. To test: 1. Apply patch and run yarn build && restart_all 2. Place a hold for a patron and check in the item 3. Notice the modal displays the main contact method in a yellow box 4. Go to Circulation > Holds awaiting pickup 5. Notice the main contact method displays in the Patron column in the same style Signed-off-by: Shi Yao Wang <shi-yao.wang@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37860 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |shi-yao.wang@inLibro.com Status|Needs Signoff |Signed Off --- Comment #4 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Works, but it seems to display the name of the db column as is. E.g. Secondary email shows "emailpro" in step 3 and 5. Maybe we want to display the actual text? Signed-off nonetheless -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37860 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |kyle@bywatersolutions.com --- Comment #5 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Couple easy to fix qa issues: 1) primary_contact_method sees be labeled as "Main contact method" in other templates. Can you update that? 2) The primary_contact_method output needs to be run through a an if/elseif or switch statement to it can be translatable. Here is the code from moremember.tt you could use: [% SWITCH patron.primary_contact_method %] [% CASE 'phone' %] <span>Primary phone</span> [% CASE 'phonepro' %] <span>Secondary phone</span> [% CASE 'mobile' %] <span>Other phone</span> [% CASE 'email' %] <span>Primary email</span> [% CASE 'emailpro' %] <span>Secondary email</span> [% CASE 'fax' %] <span>Fax</span> [% END %] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37860 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37860 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171998|0 |1 is obsolete| | --- Comment #6 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 176880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176880&action=edit Bug 37860: Add Main contact method to Holds awaiting pickup table This patch adds the main contact method to the patron column of the Holds awaiting pickup table. The style is intended to match the modal on the hold found modal. To test: 1. Apply patch and run yarn build && restart_all 2. Place a hold for a patron and check in the item 3. Notice the modal displays the main contact method in a yellow box 4. Go to Circulation > Holds awaiting pickup 5. Notice the main contact method displays in the Patron column in the same style Signed-off-by: Shi Yao Wang <shi-yao.wang@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37860 --- Comment #7 from Brendan Lawlor <blawlor@clamsnet.org> --- Thanks Kyle, I appreciate your help. I made those two changes. Adding the switch statement also addresses Shi Yao's commnet #4. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37860 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com --- Comment #8 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Looks fine to me. Maybe you want to add a gray chip when there is no primary method, as it is for messaging preference ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37860 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37860 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37860 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176880|0 |1 is obsolete| | --- Comment #9 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 179700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179700&action=edit Bug 37860: Add Main contact method to Holds awaiting pickup table This patch adds the main contact method to the patron column of the Holds awaiting pickup table. The style is intended to match the modal on the hold found modal. To test: 1. Apply patch and run yarn build && restart_all 2. Place a hold for a patron and check in the item 3. Notice the modal displays the main contact method in a yellow box 4. Go to Circulation > Holds awaiting pickup 5. Notice the main contact method displays in the Patron column in the same style Signed-off-by: Shi Yao Wang <shi-yao.wang@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37860 --- Comment #10 from Brendan Lawlor <blawlor@clamsnet.org> --- Thanks for looking Baptiste. I added a grey chip to display Main contact method: None -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37860 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37860 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179700|0 |1 is obsolete| | --- Comment #11 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 179715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179715&action=edit Bug 37860: Add Main contact method to Holds awaiting pickup table This patch adds the main contact method to the patron column of the Holds awaiting pickup table. The style is intended to match the modal on the hold found modal. To test: 1. Apply patch and run yarn build && restart_all 2. Place a hold for a patron and check in the item 3. Notice the modal displays the main contact method in a yellow box 4. Go to Circulation > Holds awaiting pickup 5. Notice the main contact method displays in the Patron column in the same style Signed-off-by: Shi Yao Wang <shi-yao.wang@inlibro.com> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37860 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179715|0 |1 is obsolete| | --- Comment #12 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 179716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179716&action=edit Bug 37860: Add Main contact method to Holds awaiting pickup table This patch adds the main contact method to the patron column of the Holds awaiting pickup table. The style is intended to match the modal on the hold found modal. To test: 1. Apply patch and run yarn build && restart_all 2. Place a hold for a patron and check in the item 3. Notice the modal displays the main contact method in a yellow box 4. Go to Circulation > Holds awaiting pickup 5. Notice the main contact method displays in the Patron column in the same style Signed-off-by: Shi Yao Wang <shi-yao.wang@inlibro.com> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> Current status: Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37860 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |baptiste.wojtkowski@biblibr |y.org |e.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37860 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Holds Awaiting Pickup table |Holds awaiting pickup table |should include the patron |should include the patron |main contact method |main contact method Status|Passed QA |Failed QA --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Noting a small thing: + [% CASE 'fax' %] + <span>Fax</span> + [% END %] + </div> + [% ELSE %] + <div class="main_contact_method none">Main contact method: None</div> + [% END %] I am not sure if we need the None case here. It takes up a lot of space in the table and could also be deducted from the info now shown. We also lose the distinction between label and content as it's now both combined into a string - not sure if that means something for accessibility. What do you think? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37860 --- Comment #14 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- (In reply to Katrin Fischer from comment #13)
Noting a small thing:
+ [% CASE 'fax' %] + <span>Fax</span> + [% END %] + </div> + [% ELSE %] + <div class="main_contact_method none">Main contact method: None</div> + [% END %]
I am not sure if we need the None case here. It takes up a lot of space in the table and could also be deducted from the info now shown. We also lose the distinction between label and content as it's now both combined into a string - not sure if that means something for accessibility.
What do you think?
I asked the dev to proceed to the add, I might be wrong but since it is working so for messaging preferences, I would have copied it. If it is still fresh in your mind, how would you deduce from information above ? I think it is important to have the information that nothing is filled, but if you say it can be easily deduced from before at one glance, it is fine for me :) I don't see how it would change accessibility, but I have very few knowledge in that field. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37860 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org Status|Failed QA |Passed QA --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Actually, you are right about the accessibility. When I looked at this I thought we had something like: <div><label>Main contact method: </label><span>method</span></div> But we always have below for all cases, including the none case: <div class="label main_contact_method">Main contact method: method</div> So it always represents as one long string. You can't easily hide the "Main contact method", but you could with some JS trickery. I think the "none" case is a bit cluttering as it always adds a lot of text. Same for "Main contact method:" being repeated over and over. Usually the cluttering get worse in German as words tend to be too long and not wrap nicely. To explain my background about changing like this :) I am setting back to PQA and adding Owen. Maybe he has a good idea, otherwise will push as is. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37860 --- Comment #16 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 181246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181246&action=edit Interface idea Is this too obscure? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37860 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Owen Leonard from comment #16)
Created attachment 181246 [details] Interface idea
Is this too obscure?
I like the basic idea, but do we display all the options from the main contact method to be able to put a star on them? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37860 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37860 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37860 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This adds the main contact release notes| |method recorded in the | |user's account to the table | |of holds awaiting pick-up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37860 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #19 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37860 --- Comment #20 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Looks like the css for this is broken on main or I don't remember well how this patch was supposed to happen. Is the attached document correct concerning contact method while checking in ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37860 --- Comment #21 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 193915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193915&action=edit Current UI on main -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org