[Bug 7449] New: The "billingplace" value isn't saved when creating a new basketgroup
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7449 Bug #: 7449 Summary: The "billingplace" value isn't saved when creating a new basketgroup Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_6 Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions AssignedTo: henridamien@koha-fr.org ReportedBy: fcapovilla@live.ca QAContact: ian.walls@bywatersolutions.com When creating a new basketgroup, the billingplace isn't saved. Because of that, the selected branch's informations aren't added to the pdf when printing the basketgroup. If the basket if modified and saved again, the billingplace then gets saved correctly. The problem seems to be around lines 463-472 of acqui/basketgroup.pl and in the NewBasketgroup subroutine : $billingplace isn't saved there. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7449 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@biblibre.co | |m Version|3.6 |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7449 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|henridamien@koha-fr.org |fridolyn.somers@biblibre.co | |m --- Comment #1 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 15608 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15608&action=edit Proposed patch See commit message -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7449 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|The "billingplace" value |billingplace and |isn't saved when creating a |freedeliveryplace not saved |new basketgroup |when creating a new | |basketgroup -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7449 --- Comment #2 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- I changed bug name because freedeliveryplace is also concerned. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7449 --- Comment #3 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Patch changes in C4/Acquisition.pm NewBasketgroup() so that it looks more like ModBasketgroup() witch is correct. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7449 --- Comment #4 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Created attachment 15996 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15996&action=edit Attachment to Bug 7449 - billingplace and freedeliveryplace not saved when creating a new basketgroup Bug 7449: billingplace and freedeliveryplace not saved when creating a new basketgroup billingplace and freedeliveryplace are missing in C4::Acquisition::NewBasketgroup. Test plan : - Go to a vendor basket groups - Create a new basket group - Enter a name - Choose a billing place - Do not choose a delivery place in combobox but enter a text in delivery place textarea - Enter a comment - Save - Edit created basket group => Check that billing place and free delivery place are ok Signed-off-by: Mathieu Saby <mathieu.saby@univ-rennes2.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7449 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mathieu.saby@univ-rennes2.f | |r -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7449 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15608|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7449 --- Comment #5 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- It works, I sign off. M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7449 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de QA Contact|koha.sekjal@gmail.com |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7449 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Fridolyn, this is certainly an improvement, but I think there is still a little problem with the setting for delivery place: 1) Created a new basket group, set delivery place to "-" 2) Added a delivery address in the text box. 3) Saved. 4) Edited basket group - delivery place is set to my current branch instead of "-" Could you take a look please? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7449 --- Comment #7 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Hello We consider it is a very strange behavior. When creating a basketgroup from a basket, billing and deliveryplace should be the same. But I think this was the behavior for deliveryplace before Fridolyn's patch. So maybe it can be changed in other patch? Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7449 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, I am not sure. But wouldn't it be possible that delivery could go to one branch while bills are handled centrally at the main library? The package would still have a list of delivered items I guess. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7449 --- Comment #9 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- So let's say the current behavior is correct -) Before changing it, we may ask the lists, and maybe made a syspref if there are different opinions on that question... Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7449 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, not sure I understand :) What would the syspref change? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7449 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Also, shouldn't the bug that you can't save the information correctly be fixed? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7449 --- Comment #12 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- I was thinking of a syspref for Using either the librairian's connecting site, or the site used in basket. But maybe not a good idea. What is sure, is that 7449 is already an improvement. For my colleagues it will change life! (currently we have to reopen each basketgroup to change the billingplace...) M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7449 --- Comment #13 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- (In reply to comment #6)
Hi Fridolyn,
this is certainly an improvement, but I think there is still a little problem with the setting for delivery place:
1) Created a new basket group, set delivery place to "-" 2) Added a delivery address in the text box. 3) Saved. 4) Edited basket group - delivery place is set to my current branch instead of "-"
Could you take a look please?
This is another problem : Creating a new basketgroup and editing one uses the same page and operation : acqui/basketgroup.pl?op=add&booksellerid=x&basketgroupid=x So when you edit an existing basketgroup, selected branches are librarian branch. Can you create a new bug ? This patch does not change any behavior, it is only a correction in SQL query building. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7449 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Fridolyn, I agree this can go on a separate bug. Taking another look now. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7449 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9993 Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7449 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7449 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15996|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 17230 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17230&action=edit [PASSED QA] Bug 7449: billingplace and freedeliveryplace not saved when creating a new basketgroup billingplace and freedeliveryplace are missing in C4::Acquisition::NewBasketgroup. Test plan : - Go to a vendor basket groups - Create a new basket group - Enter a name - Choose a billing place - Do not choose a delivery place in combobox but enter a text in delivery place textarea - Enter a comment - Save - Edit created basket group => Check that billing place and free delivery place are ok Signed-off-by: Mathieu Saby <mathieu.saby@univ-rennes2.fr> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works according to test plan, delivery place is now correctly saved into the databas and was before lost. All tests and QA script pass. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7449 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #16 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7449 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #17 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x will be in 3.10.5 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org