http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15337 Iming Chan <imingchan@yahoo.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Koha Item Type sorted by |Koha Item Type sorted by |Code instead of Description |Codes instead of | |Descriptions -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15337 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46257 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46257&action=edit Bug 15337: Add tests to ensure that GetItemTypes will return element ordered by desc -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15337 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15354 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15337 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #3 from Marc Véron <veron@veron.ch> --- Testing: Without patches: - Order in dropdown list of Koha item types is wrong (not alphabetically). - t/db_dependent/Koha.t passes green With first patch (tests): - t/db_dependent/Koha.t does not pass (not ok 10 - GetItemTypes test) (as expected) With second patch applied: - Order in dropdown is alphabetically (as expected) - t/db_dependent/Koha.t passes green (as expected) Going to sign off. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15337 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46258|0 |1 is obsolete| | --- Comment #5 from Marc Véron <veron@veron.ch> --- Created attachment 46275 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46275&action=edit Bug 15337: Make itemtypes retrieved with GetItemTypes ordered by descriptions Prior to this patch, the itemtypes were displayed ordered by the code (itemtypes.itemtype DB column). This patch will make them displayed by the description displayed (the translated description). Test plan: 0/ Do not apply this patch set 1/ Confirm that the itemtypes are displayed ordered by code (when adding an item, cataloguing/additem.pl) 2/ Confirm that t/db_dependent/Koha.t does not pass 3/ Apply the test patch 4/ Confirm that t/db_dependent/Koha.t pass 5/ Confirm that the itemtypes are not displayed by description (on additem.pl) See comment #3 Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15337 Heather Braum <hbraum@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum@nekls.org -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15337 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #6)

Hi Jonathan, this doesn't appear to work for me. I changed the english and the default description of my BK itemtype to "Z" - but it still appears first in list when adding a new item?

Cannot recreate that. I have changed my "CD" description to "Z", then go to /cataloguing/additem.pl?op=edititem&biblionumber=1986&itemnumber=2990#edititem I have my 995$r set as r type de document et support matériel Tab:10, | Koha field: items.itype, Not repeatable, Mandatory, | Auth value:itemtypes -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15337 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have no idea why, but 'Zooks' stays on top of list in the edit item screen no matter what I do. :( -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15337 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think it must have been some hidden whitespace. I reentered all descriptions, didn't notice an additional space, but after that - it works. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15337 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46274|0 |1 is obsolete| | Attachment #46275|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 46497 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46497&action=edit [PASSED QA] Bug 15337: Add tests to ensure that GetItemTypes will return element ordered by desc See comment #3 Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15337 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #14 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to master - thanks -- You are receiving this mail because: You are watching all bug changes.