[Bug 21455] New: Authority search options get shuffled around when you click on 'Search'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21455 Bug ID: 21455 Summary: Authority search options get shuffled around when you click on 'Search' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: arouss1980@gmail.com QA Contact: testopia@bugs.koha-community.org As per the attached screenshots, when you perform an authority search in the staff client and click on the 'Search' button, the selected values for the 'Search all headings:' and 'Search entire record:' options get flipped around. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21455 Andreas Roussos <arouss1980@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |arouss1980@gmail.com |ity.org | --- Comment #1 from Andreas Roussos <arouss1980@gmail.com> --- Created attachment 79650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79650&action=edit Authority search window before clicking on 'Search' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21455 --- Comment #2 from Andreas Roussos <arouss1980@gmail.com> --- Created attachment 79651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79651&action=edit Authority search window after clicking on 'Search' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21455 --- Comment #3 from Andreas Roussos <arouss1980@gmail.com> --- Created attachment 79652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79652&action=edit Bug 21455: Authority search options get shuffled around when you click on 'Search' In the staff client, when you perform an authority search the selected values for the 'Search all headings:' and 'Search entire record:' options get shuffled around when you click on the 'Search' button. This patch fixes that. Test plan: 1) Perform an authority search and set the 'Search all headings:' option to 'starts with'. 2) Click on the 'Search' button. 3) Notice how the 'Search all headings:' option is now 'contains', and 'starts with' has moved down to the 'Search entire record:' option. 4) Apply the patch. 5) Hit 'Search' again. This time the selected search options do not move around. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21455 Andreas Roussos <arouss1980@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Priority|P5 - low |P3 Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21455 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79652|0 |1 is obsolete| | --- Comment #4 from Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> --- Created attachment 80149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80149&action=edit Bug 21455: Authority search options get shuffled around when you click on 'Search' In the staff client, when you perform an authority search the selected values for the 'Search all headings:' and 'Search entire record:' options get shuffled around when you click on the 'Search' button. This patch fixes that. Test plan: 1) Perform an authority search and set the 'Search all headings:' option to 'starts with'. 2) Click on the 'Search' button. 3) Notice how the 'Search all headings:' option is now 'contains', and 'starts with' has moved down to the 'Search entire record:' option. 4) Apply the patch. 5) Hit 'Search' again. This time the selected search options do not move around. Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21455 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |pierre-marc.thibault@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21455 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This doesn't work for me yet, when I search, the tab still jumps back to the first. (applied patch, restart all, reloaded the page mulitple times) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21455 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Looking at the screenshots... I am in the wrong spot. I had checked the normal authority search. Filed a bug: Bug 21510 - Authority search always jumps back to the first search tab no matter what was searched for -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21455 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21455 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80149|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 80167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80167&action=edit Bug 21455: Authority search options get shuffled around when you click on 'Search' In the staff client, when you perform an authority search the selected values for the 'Search all headings:' and 'Search entire record:' options get shuffled around when you click on the 'Search' button. This patch fixes that. Test plan: 1) Perform an authority search and set the 'Search all headings:' option to 'starts with'. 2) Click on the 'Search' button. 3) Notice how the 'Search all headings:' option is now 'contains', and 'starts with' has moved down to the 'Search entire record:' option. 4) Apply the patch. 5) Hit 'Search' again. This time the selected search options do not move around. Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
This doesn't work for me yet, when I search, the tab still jumps back to the first. (applied patch, restart all, reloaded the page mulitple times) My bad really, now that I re-read the bug description and test plan for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21455 --- Comment #8 from Andreas Roussos <arouss1980@gmail.com> --- (In reply to Katrin Fischer from comment #5) the patch I realise I should have been more explicit. Nevertheless it's interesting to see how your testing led to the discovery of yet another authorities-related bug! ;-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21455 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21455 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21455 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21455 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #11 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.11.x for 17.11.12 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org