https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29434 --- Comment #1 from Andreas Roussos <a.roussos@dataly.gr> --- Created attachment 127420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127420&action=edit list of sample authorities in the Staff client -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29434 --- Comment #3 from Andreas Roussos <a.roussos@dataly.gr> --- Created attachment 127422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127422&action=edit relationship codes for MARC21 in the authority finder -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29434 Andreas Roussos <a.roussos@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |a.roussos@dataly.gr |ity.org | URL| |authorities/auth_finder.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29434 --- Comment #5 from Andreas Roussos <a.roussos@dataly.gr> --- Created attachment 127424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127424&action=edit Bug 29434: add UNIMARC relationship codes for authorities When using the authority finder plugin (authorities/auth_finder.pl), you can pick an entry from the 'Special relationship:' dropdown menu in order to set the relationship between authorities. However, in UNIMARC instances the relationship codes listed are those for MARC21. The correct codes for UNIMARC are listed in pages 93-94 of the IFLA UNIMARC Manual for Authorities. Test plan: 1) In a UNIMARC instance, launch authorities/auth_finder.pl in the Staff client, by clicking on the 'Tag editor' button. Notice how the 'Special relationship:' dropdown menu lists the relationship codes for MARC21 instead of UNIMARC. 2) Apply this patch. 3) Launch the authority finder again; this time the correct values should be listed in the 'Special relationship:' dropdown menu. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29434

--- Comment #7 from Andreas Roussos <a.roussos@dataly.gr> ---
(In reply to David Nind from comment #6)
> Hi Andreas.
Hi David!

> I'm not familiar with UNIMARC, but I would like to test this bug.
That's great! Thank you for your interest in this bug report.

> For step 1, how do I set things up so I can "launch
> authorities/auth_finder.pl"?
> - Are there any fields that have the tag editor already enabled?
There aren't any, no. See below for instructions on how to enable.

> - Do I need to edit the authority structure (Administration > Catalog >
> Authority types)?
Yes. I'll outline the steps required below:
- Go to 'Home > Administration > Authority types' and click on
  'Actions -> MARC structure' for the 'NP' (Personal Name) auth type.
- Next, search for tag 510 and click on 'Actions -> Subfields' for
  that tag.
- Finally, click 'Edit' next to subfield 'a' (Entry element), then
  pick 'CO' from the 'Thesaurus' dropdown menu. Save your settings
  and you're good to go! From now on, when editing a Personal Name
  authority, the 'Tag editor' button next to subfield 510$a will
  launch the authority finder plugin.

> - Where does the 'Special relationship:' dropdown menu appear?
It will appear when you launch the authority finder plugin via
the 'Tag editor' button. The menu itself will be near the bottom
of the popup window, under the 'Relationship information' section.

> - I assume I need to enable the AuthDisplayHierarchy system preference.
Actually you're not required to have this system preference enabled
if you just want to link authorities with other authorities.
It certainly helps to have in enabled, though, as you'll get
the nice hierarchical view of authorities in their Details page.

> I'm using koha-testing-docker and have a UNIMARC instance with the default
> sample data. Is there an existing authority record that you know of in the
> sample data with this already setup?
I ran a SELECT query on the SQL sample data for UNIMARC (provided
by koha-misc4dev) looking for records where the `authtrees` column
would be != NULL but couldn't find such a record. So, I guess
the answer is no.

> Apologies for such a basic question!
No worries, my test plan and the Bug Description did not include
all the information so your question is absolutely valid.
I apologise myself for the very late reply!

-- 
You are receiving this mail because:
You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29434 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127424|0 |1 is obsolete| | --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 138065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138065&action=edit Bug 29434: add UNIMARC relationship codes for authorities When using the authority finder plugin (authorities/auth_finder.pl), you can pick an entry from the 'Special relationship:' dropdown menu in order to set the relationship between authorities. However, in UNIMARC instances the relationship codes listed are those for MARC21. The correct codes for UNIMARC are listed in pages 93-94 of the IFLA UNIMARC Manual for Authorities. Test plan: 1) In a UNIMARC instance, launch authorities/auth_finder.pl in the Staff client, by clicking on the 'Tag editor' button. Notice how the 'Special relationship:' dropdown menu lists the relationship codes for MARC21 instead of UNIMARC. 2) Apply this patch. 3) Launch the authority finder again; this time the correct values should be listed in the 'Special relationship:' dropdown menu. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29434 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |fridolin.somers@biblibre.co |y.org |m CC| |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29434 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138065|0 |1 is obsolete| | --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 138885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138885&action=edit Bug 29434: add UNIMARC relationship codes for authorities When using the authority finder plugin (authorities/auth_finder.pl), you can pick an entry from the 'Special relationship:' dropdown menu in order to set the relationship between authorities. However, in UNIMARC instances the relationship codes listed are those for MARC21. The correct codes for UNIMARC are listed in pages 93-94 of the IFLA UNIMARC Manual for Authorities. Test plan: 1) In a UNIMARC instance, launch authorities/auth_finder.pl in the Staff client, by clicking on the 'Tag editor' button. Notice how the 'Special relationship:' dropdown menu lists the relationship codes for MARC21 instead of UNIMARC. 2) Apply this patch. 3) Launch the authority finder again; this time the correct values should be listed in the 'Special relationship:' dropdown menu. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29434 --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29434 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #13 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29434 --- Comment #14 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes.