[Bug 8419] New: Suspended holds appear on the daily holds queue
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8419 Priority: P5 - low Change sponsored?: --- Bug ID: 8419 CC: gmcharlt@gmail.com Assignee: koha-bugs@lists.koha-community.org Summary: Suspended holds appear on the daily holds queue Severity: enhancement Classification: Unclassified OS: All Reporter: kyle.m.hall@gmail.com Hardware: All Status: NEW Version: master Component: Hold requests Product: Koha Suspended holds are showing up in both the holds queue and holds to pull reports. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8419 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8419 --- Comment #1 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 10771 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10771&action=edit Bug 8419 - Suspended holds appear on the daily holds queue Suspended holds are showing up in both the holds queue and holds to pull reports. This patch adds to the sql queries such that any hold that is suspended is not selected. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8419 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8419 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10771|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 11383 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11383&action=edit [SIGNED-OFF] Bug 8419 - Suspended holds appear on the daily holds queue Suspended holds are showing up in both the holds queue and holds to pull reports. This patch adds to the sql queries such that any hold that is suspended is not selected. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8419 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Before the patch, a title with a single hold, suspended, appeared in the holds queue report. After the patch that hold no longer appeared in the report. I added another hold on that same title, rebuilt the holds queue report, and the new hold appeared. The holds to pull report appears correct as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8419 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA Comments: Seems good for me, marking as Passed QA. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8419 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8419 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x will be in 3.8.4 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8419 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable CC| |paul.poulain@biblibre.com Version|master |rel_3_8 --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> --- Pushed to master. Already pushed to stable, setting status accordingly -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8419 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED CC| |nengard@gmail.com Resolution|FIXED |--- --- Comment #7 from Nicole C. Engard <nengard@gmail.com> --- This appears to have resurfaced in 3.10.3 Nicole -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8419 --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- (In reply to comment #7)
This appears to have resurfaced in 3.10.3
Nicole
3.10.4 is the latest release have you tested that? Or 3.10.x itself? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8419 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8419 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11383|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 17451 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17451&action=edit Bug 8419 - Suspended holds appear on the daily holds queue This bug was reintroduced by the patch for bu 5911: Transport Cost Matrix Test Plan: 1) Place a hold on a record 2) Run build_holds_queue.pl 3) Verify the hold is showing in the holds queue 4) Suspend the hold 5) Re-run build_holds_queue.pl 6) Note the hold is still in the holds queue 7) Apply patch 8) Re-run build_holds_queue.pl 9) Note the hold is no longer in the holds queue -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8419 --- Comment #10 from Kyle M Hall <kyle.m.hall@gmail.com> --- I have tested and verified that this bug has been reintroduced in both 3.10.x and master. (In reply to comment #8)
(In reply to comment #7)
This appears to have resurfaced in 3.10.3
Nicole
3.10.4 is the latest release have you tested that? Or 3.10.x itself?
-- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8419 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.8 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8419 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle.m.hall@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8419 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8419 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17451|0 |1 is obsolete| | --- Comment #11 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 17782 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17782&action=edit Bug 8419 - Suspended holds appear on the daily holds queue This bug was reintroduced by the patch for bu 5911: Transport Cost Matrix Test Plan: 1) Place a hold on a record 2) Run build_holds_queue.pl 3) Verify the hold is showing in the holds queue 4) Suspend the hold 5) Re-run build_holds_queue.pl 6) Note the hold is still in the holds queue 7) Apply patch 8) Re-run build_holds_queue.pl 9) Note the hold is no longer in the holds queue Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8419 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8419 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17782|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 17818 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17818&action=edit [PASSED QA] Bug 8419 - Suspended holds appear on the daily holds queue This bug was reintroduced by the patch for bu 5911: Transport Cost Matrix Test Plan: 1) Place a hold on a record 2) Run build_holds_queue.pl 3) Verify the hold is showing in the holds queue 4) Suspend the hold 5) Re-run build_holds_queue.pl 6) Note the hold is still in the holds queue 7) Apply patch 8) Re-run build_holds_queue.pl 9) Note the hold is no longer in the holds queue Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes test plan and QA script. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8419 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #13 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8419 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #14 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x will be in 3.10.6 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8419 Joel Sasse <jsasse@plumcreeklibrary.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jsasse@plumcreeklibrary.net -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org