[Bug 42234] New: OPAC checkout history page table header contains no text
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42234 Bug ID: 42234 Summary: OPAC checkout history page table header contains no text Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Accessibility Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: martin.renvoize@openfifth.co.uk, matt.blenkinsop@openfifth.co.uk, oleonard@myacpl.org To recreate: 1. Have a user with checkouts 2. Log into the OPAC and go to "Checkout history". 3. In the checkout history table, the first <th> contains no text. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42234 --- Comment #1 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- This appears to be a "Cover image" column. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42234 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |Laura.escamilla@bywatersolu |ity.org |tions.com Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42234 --- Comment #2 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 198861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198861&action=edit Bug 42234: Add text to checkout history cover image table header 1. Enable at least one cover image service, such as GoogleJackets or OPACAmazonCoverImages. 2. Log in to the OPAC as a patron with checkout history. 3. Go to your account > Checkout history. 4. Inspect the checkout history table header. 5. Confirm the cover image column header contains "Cover image". 6. Confirm the table still displays correctly. 7. Confirm sorting/export behavior is unchanged for that column. 8. Sign off and have a wonderful day! :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42234 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42234 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198861|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42234 --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 199026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199026&action=edit Bug 42234: Add text to checkout history cover image table header 1. Enable at least one cover image service, such as GoogleJackets or OPACAmazonCoverImages. 2. Log in to the OPAC as a patron with checkout history. 3. Go to your account > Checkout history. 4. Inspect the checkout history table header. 5. Confirm the cover image column header contains "Cover image". 6. Confirm the table still displays correctly. 7. Confirm sorting/export behavior is unchanged for that column. 8. Sign off and have a wonderful day! :D Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42234 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes the patron release notes| |checkout history table in | |the OPAC. It adds a title | |to the cover image column | |("Cover image"). --- Comment #4 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Note that the export options for the table contain the star rating information in the title column (unchanged from before the patch). 2. I think there is bug for fixing this. 3. Possibly, another bug should be to only display the cover image column when the appropriate system preferences are enabled. At the moment the column is shown, even if there are no cover services enabled. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42234 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |blawlor@clamsnet.org |y.org | Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42234 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199026|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42234 --- Comment #5 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 199951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199951&action=edit Bug 42234: Add text to checkout history cover image table header 1. Enable at least one cover image service, such as GoogleJackets or OPACAmazonCoverImages. 2. Log in to the OPAC as a patron with checkout history. 3. Go to your account > Checkout history. 4. Inspect the checkout history table header. 5. Confirm the cover image column header contains "Cover image". 6. Confirm the table still displays correctly. 7. Confirm sorting/export behavior is unchanged for that column. 8. Sign off and have a wonderful day! :D Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42234 --- Comment #6 from Brendan Lawlor <blawlor@clamsnet.org> --- David's comments are valid, but outside the scope of this bug. Adding the "cover image" text to the table header addresses: WCAG 2.1 / 2.2 Success Criterion 1.3.1: Info and Relationships (Level A) The <th> text establishes the programmatic relationship with the <td> elements in that column. SC 4.1.2: Name, Role, Value (Level A) This also applies when the table is interactive, and in this case the sort buttons have the role button and aria labels, so it passes. SC 2.4.6: Headings and Labels (Level AA) This is also applicable here for making the content more descriptive. Good work. Passing QA! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42234 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42234 --- Comment #7 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42234 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.11.00 |26.11.00,26.05.01 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42234 --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to 26.05.x for the upcoming 26.05.01 release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42234 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com Version(s)|26.11.00,26.05.01 |26.11.00,26.05.01,25.11.07 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #9 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Pushed into 25.11.x for 25.11.07 nice work everyone -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org