http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10041 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 17411 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17411&action=edit Bug 10041 - Provide a koha-translate script to aid package users on installing translations Until we have solved the packaging of koha template translations, provide a command that manages the installed translations in a proper way. To test, build a Debian package of current master+the patches from this bug :-D and try the many options running koha-translate --help provide. The command itself can be grabbed from a git checkout with this patch applied to test the script's funcionality. If it (and its docs) fits the package building stuff, I'll test on monday when I can be back on my workstation. Sponsored-by: Universidad Nacional de Córdoba -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10041 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10041 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@enger.priv.no -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10041 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to comment #2)

Testing.

1) -i|u|r without lang code dies with (shift: can't shift that many) perhaps check if langcode and die with a graceful message. Unless you try to mimic what translate script do without lang code, install/update/remove all langs.

Ok, fixed.

2) List all. There are 2 files with "opac" in name (prog|ccsr), so you report twice. Perhaps using $(ls $PO_DIR *-i-opac-t-prog-v-3006000.po)?

I did't notice because the current packages don't ship the ccsr theme. Fixed.

3) Install. Could test if all lang files are present? (staf|opac|ccsr|pref) only to report any missing, and then proceed (translate script will complain anyway).

Added the -c|--check switches. The check is performed on update and install commands, and prevents from running if some .PO file is missing.

4) Remove ok. Sysprefs language and opaclanguages could reference a removed lang but I think it's harmless.

Oh, at least I wrote an 'rm -rf' command that does not fail!

5) Update. The message if you try to install again a lang is misleading. update option in 'misc/translator/translate' script is not to update translated files but to update translation files (PO). So, if your update is to re-install, do so (install) silently. Or change the message to reflect what you are really doing and allow a re-install. Or remove update option.

As I'm focusing on the end user (non-techie) the idea is that new .PO are provided and they can use the script to update the templates. So, different semantics from the 'translate' command. Fixed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10041 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17469|0 |1 is obsolete| | --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 17472 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17472&action=edit Bug 10041 - Provide a koha-translate script to aid package users on installing translations Until we have solved the packaging of koha template translations, provide a command that manages the installed translations in a proper way. To test, build a Debian package of current master+the patches from this bug :-D and try the many options running koha-translate --help provide. The command itself can be grabbed from a git checkout with this patch applied to test the script's funcionality. If it (and its docs) fits the package building stuff, I'll test on monday when I can be back on my workstation. Sponsored-by: Universidad Nacional de Córdoba -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10041 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17473|0 |1 is obsolete| | --- Comment #8 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 17494 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17494&action=edit [SIGNED-OFF] Bug 10041 - Provide a koha-translate script to aid package users on installing translations Until we have solved the packaging of koha template translations, provide a command that manages the installed translations in a proper way. To test, build a Debian package of current master+the patches from this bug :-D and try the many options running koha-translate --help provide. The command itself can be grabbed from a git checkout with this patch applied to test the script's funcionality. If it (and its docs) fits the package building stuff, I'll test on monday when I can be back on my workstation. Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Good adition. Work as described. No errors. Copied to /usr/local/bin. No errors on install, update, remove, list and check. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10041 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #9 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #8)

Created attachment 17494 [details] [review] [SIGNED-OFF] Bug 10041 - Provide a koha-translate script to aid package Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

QA-comment: woah, looks good! :) hmmm, one small problem for me - creating a fr-FR language dir failed Tomás, any ideas? see below... # which koha-translate /usr/sbin/koha-translate # koha-translate -l en en-NZ Kore-KR # koha-translate -l -a|grep FR fr-FR # koha-translate -i fr-FR Error: /usr/share/koha/misc/translator/po/fr-FR-opac-ccsr.po not found. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10041 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.