[Bug 5713] New: Intranet - Circulation - Fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5713 Summary: Intranet - Circulation - Fines Change sponsored?: Sponsored Product: Koha Version: rel_3_2 Platform: All OS/Version: All Status: ASSIGNED Severity: major Priority: P5 Component: Circulation AssignedTo: brice.sanchez@sys-tech.net ReportedBy: brice.sanchez@sys-tech.net QAContact: koha-bugs@lists.koha-community.org CC: gmcharlt@gmail.com Estimated Hours: 0.0 When a user has fines and we pay them and then we click to reverse them and after the pay them again, the calculation isn't done properly. Adrien Russo (SYS-TECH) provides you a patch to fix this problem: we do not create more new line after paying a fine, we edit it. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5713 Brice Sanchez <brice.sanchez@sys-tech.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Intranet - Circulation - |Intranet - Circulation - |Fines |Fines : debug calculation | |when fines are reversed | |then re-payed -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5713 --- Comment #1 from Brice Sanchez <brice.sanchez@sys-tech.net> 2011-02-08 15:09:43 UTC --- Created attachment 3092 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3092 patch for this bug -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5713 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Does not apply --- Comment #2 from Owen Leonard <oleonard@myacpl.org> 2011-02-08 17:14:32 UTC --- I tried to apply this patch using git am and got this message: Applying: debug calculation when fines are reversed then re-payed fatal: corrupt patch at line 77 Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 debug calculation when fines are reversed then re-payed -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5713 Brice Sanchez <brice.sanchez@sys-tech.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3092|0 |1 is obsolete| | --- Comment #3 from Brice Sanchez <brice.sanchez@sys-tech.net> 2011-02-08 18:05:25 UTC --- Created attachment 3098 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3098 patch for this bug -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5713 --- Comment #4 from Brice Sanchez <brice.sanchez@sys-tech.net> 2011-02-08 18:07:11 UTC --- try this patch, it should be good. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5713 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Patch Status|Does not apply |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5713 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3098|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-05-21 19:29:12 UTC --- Created attachment 4215 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4215 Signed off patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5713 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5713 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4215|0 |1 is obsolete| | --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> 2011-08-04 13:08:24 UTC --- Created attachment 4841 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4841 proposed patch (passed QA) QA comment * the indentation was made with <TAB> => brice = please use 4 spaces, this is the common rule for Koha. I've fixed the problem, but next time, i'll mark "failed QA" * The patch was conflicting with 6305 (removal of 3 my $sth). Solving the conflict was easy, so I made it too * Same comment as Katrin: could not reproduce the calculation error, but confirm accountlines table is not filled and filled and filled by payements/revers/payement => marking passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5713 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5713 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Version|rel_3_2 |rel_3_4 Patch Status|Passed QA |Patch Pushed --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> 2011-08-16 22:27:30 UTC --- Pushed please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5713 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED CC| |wizzyrea@gmail.com Resolution| |FIXED --- Comment #8 from Liz Rea <wizzyrea@gmail.com> 2011-08-22 16:35:36 UTC --- Tested, works great thanks! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org